bcg729 issueshttps://gitlab.linphone.org/BC/public/bcg729/-/issues2020-11-17T15:14:51Zhttps://gitlab.linphone.org/BC/public/bcg729/-/issues/3Configure- or compile-time version checking?2020-11-17T15:14:51ZGerald CombsConfigure- or compile-time version checking?Would it be possible to add the ability to detect the bcg729 version at configure or compile time, e.g. via a version macro in a header file? The recent switch to the GPLv3 means that we (Wireshark) are going to have to ensure that we bu...Would it be possible to add the ability to detect the bcg729 version at configure or compile time, e.g. via a version macro in a header file? The recent switch to the GPLv3 means that we (Wireshark) are going to have to ensure that we build with bcg729 < 1.1.0 since we're still under the GPLv2.https://gitlab.linphone.org/BC/public/bcg729/-/issues/2Discrepancies between the CMake and autotools configuration2020-11-17T15:17:05ZPeter WuDiscrepancies between the CMake and autotools configurationWhile trying to package bcg729 for Arch Linux, I noticed that the README marked autotools as deprecated and recommended CMake instead. Fair enough, I tried that but noticed some issues:
- Symbols are exported by default. Proposed fix is...While trying to package bcg729 for Arch Linux, I noticed that the README marked autotools as deprecated and recommended CMake instead. Fair enough, I tried that but noticed some issues:
- Symbols are exported by default. Proposed fix is to add `-fvisibility=hidden` as is done here: https://github.com/BelledonneCommunications/bcg729/pull/7
- pkgconfig (.pc) file is not installed. For compatibility with projects using pkg-config, it might be a good idea to install it even with CMake. (Fix is included with the above PR)
- CMake installs libbcg729.so.0 with symlinks libbcg729.so while autotools installs libbcg729.so.0.0.0 with symlinks libbcg729.so and libbcg729.so.0.0. Just an observation.
- -Werror is enabled by default and there is no `--disable-strict` equivalent.
While at it, I also noticed an issue with the autotools build:
- Its `AC_INIT` version still lists 1.0.3 while it should have been 1.0.4.
Aside from those technical issues, the README lacks information on where to report issues and whether contributions are even welcome.