Skip to content

GitLab

Commit d5103615 authored by jehan's avatar jehan
Browse files
Options

implement refresher support of PUBLISH method

parent 773624c7
Hide whitespace changes
Inline Side-by-side
Showing with 83 additions and 14 deletions
include/belle-sip/message.h
View file @ d5103615
......@@ -36,6 +36,8 @@ BELLESIP_EXPORT belle_sip_message_t* belle_sip_message_parse(const char* raw);
*/
BELLESIP_EXPORT belle_sip_message_t* belle_sip_message_parse_raw (const char* buff, size_t buff_length,size_t* message_length );
BELLESIP_EXPORT int belle_sip_message_is_request(belle_sip_message_t *msg);
BELLESIP_EXPORT belle_sip_request_t* belle_sip_request_new();
belle_sip_request_t* belle_sip_request_parse(const char* raw);
......@@ -62,6 +64,13 @@ void belle_sip_request_set_method(belle_sip_request_t* request,const char* metho
* */
BELLESIP_EXPORT belle_sip_uri_t* belle_sip_request_extract_origin(const belle_sip_request_t* req);
/**
* Clone all sip headers + body if any
* @param req message to be cloned
* @return newly allocated request
*/
BELLESIP_EXPORT belle_sip_request_t * belle_sip_request_clone_with_body(const belle_sip_request_t *initial_req);
int belle_sip_message_is_response(const belle_sip_message_t *msg);
BELLESIP_EXPORT belle_sip_header_t *belle_sip_message_get_header(const belle_sip_message_t *msg, const char *header_name);
......
src/channel.c
View file @ d5103615
......@@ -411,7 +411,7 @@ static void channel_invoke_state_listener_defered(belle_sip_channel_t *obj){
static void belle_sip_channel_handle_error(belle_sip_channel_t *obj){
/* see if you can retry on an alternate ip address.*/
if (obj->current_peer->ai_next){
if (obj->current_peer && obj->current_peer->ai_next){ /*obj->current_peer may be null in case of dns error*/
obj->current_peer=obj->current_peer->ai_next;
channel_set_state(obj,BELLE_SIP_CHANNEL_RETRY);
belle_sip_channel_connect(obj);
......
src/message.c
View file @ d5103615
......@@ -596,3 +596,16 @@ int belle_sip_response_fix_contact(const belle_sip_response_t* response,belle_si
}
return 0;
}
belle_sip_request_t * belle_sip_request_clone_with_body(const belle_sip_request_t *initial_req) {
belle_sip_request_t* req=BELLE_SIP_REQUEST(belle_sip_object_clone(BELLE_SIP_OBJECT(initial_req)));
if (belle_sip_message_get_body(BELLE_SIP_MESSAGE(initial_req))) {
belle_sip_header_content_length_t* content_lenth=belle_sip_message_get_header_by_type(initial_req,belle_sip_header_content_length_t);
if (content_lenth)
belle_sip_message_set_body(BELLE_SIP_MESSAGE(req)
,belle_sip_message_get_body(BELLE_SIP_MESSAGE(initial_req))
,belle_sip_header_content_length_get_content_length(content_lenth));
else
belle_sip_error("Cannot clone body from request [%p] because no content lenght header",initial_req);
}
return req;
}
src/refresher.c
View file @ d5103615
......@@ -246,7 +246,7 @@ static int belle_sip_refresher_refresh_internal(belle_sip_refresher_t* refresher
belle_sip_message("Refresher [%p] already have transaction [%p] in state [%s]" ,refresher
,refresher->transaction
,belle_sip_transaction_state_to_string(state));
request=BELLE_SIP_REQUEST(belle_sip_object_clone(BELLE_SIP_OBJECT(belle_sip_transaction_get_request(BELLE_SIP_TRANSACTION(refresher->transaction)))));
request=belle_sip_request_clone_with_body(belle_sip_transaction_get_request(BELLE_SIP_TRANSACTION(refresher->transaction)));
cseq=belle_sip_message_get_header_by_type(request,belle_sip_header_cseq_t);
belle_sip_header_cseq_set_seq_number(cseq,belle_sip_header_cseq_get_seq_number(cseq)+1);
} else {
......
src/transaction.c
View file @ d5103615
......@@ -474,7 +474,8 @@ belle_sip_refresher_t* belle_sip_client_transaction_create_refresher(belle_sip_c
}
belle_sip_request_t* belle_sip_client_transaction_create_authenticated_request(belle_sip_client_transaction_t *t,belle_sip_list_t** auth_infos) {
belle_sip_request_t* req=BELLE_SIP_REQUEST(belle_sip_object_clone(BELLE_SIP_OBJECT(belle_sip_transaction_get_request(BELLE_SIP_TRANSACTION(t)))));
belle_sip_request_t* initial_request=belle_sip_transaction_get_request(BELLE_SIP_TRANSACTION(t));
belle_sip_request_t* req=belle_sip_request_clone_with_body(initial_request);
belle_sip_header_cseq_t* cseq=belle_sip_message_get_header_by_type(req,belle_sip_header_cseq_t);
belle_sip_header_cseq_set_seq_number(cseq,belle_sip_header_cseq_get_seq_number(cseq)+1);
if (belle_sip_transaction_get_state(BELLE_SIP_TRANSACTION(t)) != BELLE_SIP_TRANSACTION_COMPLETED
......
tester/belle_sip_refresher_tester.c
View file @ d5103615
......@@ -32,6 +32,17 @@
#define PASSWD "secret"
static char publish_body[]=
"<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n"
"<impp:presence xmlns:impp=\"urn:ietf:params:xml:ns:pidf entity=\"pres:someone@example.com\">\n"
" <impp:tuple id=\"sg89ae\">\n"
" <impp:status>\n"
" <impp:basic>open</impp:basic>\n"
" </impp:status>\n"
" <impp:contact priority=\"0.8\">tel:+09012345678</impp:contact>\n"
" </impp:tuple>\n"
"</impp:presence>\n";
typedef enum auth_mode {
none
,digest
......@@ -213,13 +224,18 @@ static void server_process_request_event(void *obj, const belle_sip_request_even
}
belle_sip_message_add_header(BELLE_SIP_MESSAGE(resp),BELLE_SIP_HEADER(contact));
if (strcmp(belle_sip_request_get_method(req),"PUBLISH")==0) {
belle_sip_header_t* etag=belle_sip_message_get_header(BELLE_SIP_MESSAGE(resp),"SIP-ETag");
if (etag) {
/*etag already, check for sip_if_match*/
belle_sip_header_t* sip_if_match=belle_sip_message_get_header(BELLE_SIP_MESSAGE(resp),"SIP-If-Match");
CU_ASSERT_PTR_NOT_NULL(sip_if_match);
if (sip_if_match) CU_ASSERT_EQUAL(belle_sip_header_extension_get_value(BELLE_SIP_HEADER_EXTENSION(sip_if_match)),"blablietag");
belle_sip_header_t* sip_if_match=belle_sip_message_get_header(BELLE_SIP_MESSAGE(resp),"SIP-If-Match");
if (sip_if_match) {
CU_ASSERT_EQUAL(belle_sip_header_extension_get_value(BELLE_SIP_HEADER_EXTENSION(sip_if_match)),"blablietag");
}
/*check for body*/
CU_ASSERT_PTR_NOT_NULL(belle_sip_message_get_body(BELLE_SIP_MESSAGE(req)));
if (belle_sip_message_get_body(BELLE_SIP_MESSAGE(req))) {
CU_ASSERT_STRING_EQUAL(belle_sip_message_get_body(BELLE_SIP_MESSAGE(req)),publish_body);
}
CU_ASSERT_PTR_NOT_NULL(belle_sip_message_get_header_by_type(req,belle_sip_header_content_type_t));
CU_ASSERT_PTR_NOT_NULL(belle_sip_message_get_header_by_type(req,belle_sip_header_content_length_t));
belle_sip_message_add_header(BELLE_SIP_MESSAGE(resp),belle_sip_header_create("SIP-ETag","blablietag"));
}
} else {
......@@ -330,7 +346,11 @@ static endpoint_t* create_udp_endpoint(int port,belle_sip_listener_callbacks_t*
}
static void refresher_base(endpoint_t* client,endpoint_t *server, const char* method) {
static void refresher_base_with_body(endpoint_t* client
,endpoint_t *server
, const char* method
, belle_sip_header_content_type_t* content_type
,const char* body) {
belle_sip_request_t* req;
belle_sip_client_transaction_t* trans;
belle_sip_header_route_t* destination_route;
......@@ -366,6 +386,12 @@ static void refresher_base(endpoint_t* client,endpoint_t *server, const char* me
belle_sip_message_add_header(BELLE_SIP_MESSAGE(req),BELLE_SIP_HEADER(belle_sip_header_expires_create(1)));
belle_sip_message_add_header(BELLE_SIP_MESSAGE(req),BELLE_SIP_HEADER(destination_route));
if (content_type && body) {
size_t body_lenth=strlen(body);
belle_sip_message_add_header(BELLE_SIP_MESSAGE(req),BELLE_SIP_HEADER(content_type));
belle_sip_message_add_header(BELLE_SIP_MESSAGE(req),BELLE_SIP_HEADER(belle_sip_header_content_length_create(body_lenth)));
belle_sip_message_set_body(BELLE_SIP_MESSAGE(req),body,body_lenth);
}
trans=belle_sip_provider_create_client_transaction(client->provider,req);
belle_sip_object_ref(trans);/*to avoid trans from being deleted before refresher can use it*/
belle_sip_client_transaction_send_request(trans);
......@@ -402,11 +428,18 @@ static void refresher_base(endpoint_t* client,endpoint_t *server, const char* me
belle_sip_refresher_stop(refresher);
belle_sip_object_unref(refresher);
}
static void refresher_base(endpoint_t* client,endpoint_t *server, const char* method) {
refresher_base_with_body(client,server,method,NULL,NULL);
}
static void register_base(endpoint_t* client,endpoint_t *server) {
refresher_base(client,server,"REGISTER");
}
static void refresher_base_with_param(const char* method, unsigned char expire_in_contact,auth_mode_t auth_mode) {
static void refresher_base_with_param_and_body(const char* method
, unsigned char expire_in_contact
, auth_mode_t auth_mode
, int early_refresher
, belle_sip_header_content_type_t* content_type
,const char* body){
belle_sip_listener_callbacks_t client_callbacks;
belle_sip_listener_callbacks_t server_callbacks;
endpoint_t* client,*server;
......@@ -419,10 +452,15 @@ static void refresher_base_with_param(const char* method, unsigned char expire_i
server = create_udp_endpoint(6788,&server_callbacks);
server->expire_in_contact=client->expire_in_contact=expire_in_contact;
server->auth=auth_mode;
refresher_base(client,server,method);
client->early_refresher=early_refresher;
refresher_base_with_body(client,server,method,content_type,body);
destroy_endpoint(client);
destroy_endpoint(server);
}
static void refresher_base_with_param(const char* method, unsigned char expire_in_contact,auth_mode_t auth_mode) {
refresher_base_with_param_and_body(method,expire_in_contact,auth_mode,FALSE,NULL,NULL);
}
static void register_test_with_param(unsigned char expire_in_contact,auth_mode_t auth_mode) {
refresher_base_with_param("REGISTER",expire_in_contact,auth_mode);
}
......@@ -637,7 +675,14 @@ static void register_tcp_test_ipv6_to_ipv6_with_ipv6(void){
}
static void simple_publish() {
refresher_base_with_param("PUBLISH",FALSE,TRUE);
belle_sip_header_content_type_t* content_type=belle_sip_header_content_type_create("application","pidf+xml");
refresher_base_with_param_and_body("PUBLISH",FALSE,TRUE,FALSE, content_type,publish_body);
}
static void simple_publish_with_early_refresher() {
belle_sip_header_content_type_t* content_type=belle_sip_header_content_type_create("application","pidf+xml");
refresher_base_with_param_and_body("PUBLISH",FALSE,TRUE,TRUE, content_type,publish_body);
}
test_t refresher_tests[] = {
......@@ -649,6 +694,7 @@ test_t refresher_tests[] = {
{ "REGISTER with early refresher",register_early_refresher},
{ "SUBSCRIBE", subscribe_test },
{ "PUBLISH", simple_publish },
{ "PUBLISH with early refresher", simple_publish_with_early_refresher },
{ "REGISTER with unrecognizable Contact", register_with_unrecognizable_contact },
{ "REGISTER UDP from ipv6 to ipv4", register_test_ipv6_to_ipv4 },
{ "REGISTER UDP from ipv4 to ipv6", register_test_ipv4_to_ipv6 },
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment