Commit 5d2c6f42 authored by Stefano Sabatini's avatar Stefano Sabatini Committed by Anton Khirnov
Browse files

cmdutils: remove list_fmts(), simplify

The function was only used in opt_sample_fmt() for listing the sample
formats. Move list_fmts() functionality directly into

Also fix the warning:
ffmpeg.c: In function ‘opt_audio_sample_fmt’:
ffmpeg.c:2877: warning: passing argument 1 of ‘list_fmts’ from incompatible pointer type
cmdutils.h:163: note: expected ‘void (*)(char *, int,  int)’ but argument is of type ‘char * (*)(char *, int,  enum AVSampleFormat)’
Signed-off-by: default avatarAnton Khirnov <>
parent c3e40410
......@@ -571,16 +571,6 @@ void show_license(void)
void list_fmts(void (*get_fmt_string)(char *buf, int buf_size, int fmt), int nb_fmts)
int i;
char fmt_str[128];
for (i=-1; i < nb_fmts; i++) {
get_fmt_string (fmt_str, sizeof(fmt_str), i);
fprintf(stdout, "%s\n", fmt_str);
void show_formats(void)
AVInputFormat *ifmt=NULL;
......@@ -161,8 +161,6 @@ void set_context_opts(void *ctx, void *opts_ctx, int flags, AVCodec *codec);
void print_error(const char *filename, int err);
void list_fmts(void (*get_fmt_string)(char *buf, int buf_size, int fmt), int nb_fmts);
* Print the program banner to stderr. The banner contents depend on the
* current version of the repository and of the libav* libraries used by
......@@ -2859,7 +2859,10 @@ static void opt_audio_sample_fmt(const char *arg)
} else {
list_fmts(av_get_sample_fmt_string, AV_SAMPLE_FMT_NB);
int i;
char fmt_str[128];
for (i = -1; i < AV_SAMPLE_FMT_NB; i++)
printf("%s\n", av_get_sample_fmt_string(fmt_str, sizeof(fmt_str), i));
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment