• Xi Wang's avatar
    apetag: fix error handling in ff_ape_parse_tag() · b655cfef
    Xi Wang authored
    
    
    The following error handling is broken due to signedness.
    
        int file_size;
        uint32_t tag_bytes;
        int64_t tag_start;
        ...
        tag_start = file_size - tag_bytes - APE_TAG_FOOTER_BYTES;
        if (tag_start < 0) { ... }
    
    Note that tag_bytes is unsigned, which makes the right-hand side of
    `tag_start = ...' unsigned, too.  The 32-bit unsigned value is then
    zero-extended to 64 bits.  Therefore, tag_start must be non-negative,
    and the check (tag_start < 0) is always false, which breaks the error
    handling.  This patch fixes the check.
    
    Signed-off-by: default avatarXi Wang <xi.wang@gmail.com>
    Signed-off-by: default avatarAnton Khirnov <anton@khirnov.net>
    b655cfef