From 1d3ca088f669aeee5ed638ba1964d02aaf779974 Mon Sep 17 00:00:00 2001 From: Tom Finegan <tomfinegan@google.com> Date: Thu, 20 Feb 2014 22:20:58 -0800 Subject: [PATCH] obj_int_extract.bat: Pass obj_int_extract.exe path to obj_int_extract.bat. - Update the vcxproj generator to pass the path to the batch file. - Update the batch file the take the path to obj_int_extract.exe as arg 2. Fixes this warning: warning MSB8012: TargetPath does not match Linker's OutputFile property value. Change-Id: I5825f1d1d79f370aeb295bbd2aeb08b22c0e73ab --- build/arm-msvs/obj_int_extract.bat | 8 ++++++-- build/make/gen_msvs_vcxproj.sh | 12 +++++++----- build/x86-msvs/obj_int_extract.bat | 5 ++++- 3 files changed, 17 insertions(+), 8 deletions(-) diff --git a/build/arm-msvs/obj_int_extract.bat b/build/arm-msvs/obj_int_extract.bat index 7fd16a3035..267ed61d50 100644 --- a/build/arm-msvs/obj_int_extract.bat +++ b/build/arm-msvs/obj_int_extract.bat @@ -7,8 +7,12 @@ REM in the file PATENTS. All contributing project authors may REM be found in the AUTHORS file in the root of the source tree. echo on +REM Arguments: +REM %1 - Relative path to the directory containing the vp8 and vpx_scale +REM source directories. +REM %2 - Path to obj_int_extract.exe. cl /I "./" /I "%1" /nologo /c /DWINAPI_FAMILY=WINAPI_FAMILY_PHONE_APP "%1/vp8/encoder/vp8_asm_enc_offsets.c" -obj_int_extract.exe rvds "vp8_asm_enc_offsets.obj" > "vp8_asm_enc_offsets.asm" +%2\obj_int_extract.exe rvds "vp8_asm_enc_offsets.obj" > "vp8_asm_enc_offsets.asm" cl /I "./" /I "%1" /nologo /c /DWINAPI_FAMILY=WINAPI_FAMILY_PHONE_APP "%1/vpx_scale/vpx_scale_asm_offsets.c" -obj_int_extract.exe rvds "vpx_scale_asm_offsets.obj" > "vpx_scale_asm_offsets.asm" +%2\obj_int_extract.exe rvds "vpx_scale_asm_offsets.obj" > "vpx_scale_asm_offsets.asm" diff --git a/build/make/gen_msvs_vcxproj.sh b/build/make/gen_msvs_vcxproj.sh index a6315b9ee4..ba9e83a7cf 100755 --- a/build/make/gen_msvs_vcxproj.sh +++ b/build/make/gen_msvs_vcxproj.sh @@ -438,9 +438,13 @@ generate_vcxproj() { for config in Debug Release; do open_tag ItemDefinitionGroup \ Condition="'\$(Configuration)|\$(Platform)'=='$config|$plat'" - if [ "$name" = "vpx" ]; then + if [ "$name" == "vpx" ]; then + hostplat=$plat + if [ "$hostplat" == "ARM" ]; then + hostplat=Win32 + fi open_tag PreBuildEvent - tag_content Command "call obj_int_extract.bat $src_path_bare" + tag_content Command "call obj_int_extract.bat $src_path_bare $hostplat\\\$(Configuration)" close_tag PreBuildEvent fi open_tag ClCompile @@ -483,9 +487,7 @@ generate_vcxproj() { case "$proj_kind" in exe) open_tag Link - if [ "$name" = "obj_int_extract" ]; then - tag_content OutputFile "${name}.exe" - else + if [ "$name" != "obj_int_extract" ]; then tag_content AdditionalDependencies "$curlibs" tag_content AdditionalLibraryDirectories "$libdirs;%(AdditionalLibraryDirectories)" fi diff --git a/build/x86-msvs/obj_int_extract.bat b/build/x86-msvs/obj_int_extract.bat index 4e9b0ecd0d..44d095dc9c 100644 --- a/build/x86-msvs/obj_int_extract.bat +++ b/build/x86-msvs/obj_int_extract.bat @@ -7,6 +7,9 @@ REM in the file PATENTS. All contributing project authors may REM be found in the AUTHORS file in the root of the source tree. echo on +REM Arguments: +REM %1 - Relative path to the directory containing the vp8 source directory. +REM %2 - Path to obj_int_extract.exe. cl /I "./" /I "%1" /nologo /c "%1/vp8/encoder/vp8_asm_enc_offsets.c" -obj_int_extract.exe rvds "vp8_asm_enc_offsets.obj" > "vp8_asm_enc_offsets.asm" +%2\obj_int_extract.exe rvds "vp8_asm_enc_offsets.obj" > "vp8_asm_enc_offsets.asm" -- GitLab