diff --git a/build/make/gen_msvs_proj.sh b/build/make/gen_msvs_proj.sh index 660436d3aceb986fa3306877c0df78e0b116b8d1..f1cc04ea50593fed28135be9299dbd792732629d 100755 --- a/build/make/gen_msvs_proj.sh +++ b/build/make/gen_msvs_proj.sh @@ -176,7 +176,8 @@ for opt in "$@"; do -*) die_unknown $opt ;; *) - file_list[${#file_list[@]}]="$(fix_path $opt)" + # The paths in file_list are fixed outside of the loop. + file_list[${#file_list[@]}]="$opt" case "$opt" in *.asm) uses_asm=true ;; @@ -184,6 +185,10 @@ for opt in "$@"; do ;; esac done + +# Make one call to fix_path for file_list to improve performance. +fix_file_list + outfile=${outfile:-/dev/stdout} guid=${guid:-`generate_uuid`} asm_use_custom_step=false diff --git a/build/make/gen_msvs_vcxproj.sh b/build/make/gen_msvs_vcxproj.sh index 4ae511e54eb4797e4a89b42eb85cccb51da67e46..eee354dc7f48e1814812f48d9a13a0287f589ffa 100755 --- a/build/make/gen_msvs_vcxproj.sh +++ b/build/make/gen_msvs_vcxproj.sh @@ -198,7 +198,8 @@ for opt in "$@"; do -*) die_unknown $opt ;; *) - file_list[${#file_list[@]}]="$(fix_path $opt)" + # The paths in file_list are fixed outside of the loop. + file_list[${#file_list[@]}]="$opt" case "$opt" in *.asm|*.s) uses_asm=true ;; @@ -206,6 +207,10 @@ for opt in "$@"; do ;; esac done + +# Make one call to fix_path for file_list to improve performance. +fix_file_list + outfile=${outfile:-/dev/stdout} guid=${guid:-`generate_uuid`} asm_use_custom_step=false diff --git a/build/make/msvs_common.sh b/build/make/msvs_common.sh index eb2eb7bcfc236a66561da8e7f7dd31d16d001b19..90c14888c24be28410eb1d41b084780d2ae5d70a 100644 --- a/build/make/msvs_common.sh +++ b/build/make/msvs_common.sh @@ -13,7 +13,7 @@ if [ "$(uname -o 2>/dev/null)" = "Cygwin" ] \ && cygpath --help >/dev/null 2>&1; then FIXPATH='cygpath -m' else - FIXPATH='echo' + FIXPATH='echo_path' fi die() { @@ -27,8 +27,23 @@ die_unknown(){ exit 1 } +echo_path() { + for path; do + echo "$path" + done +} + +# Output one, possibly changed based on the system, path per line. fix_path() { - $FIXPATH "$1" + $FIXPATH "$@" +} + +# Corrects the paths in file_list in one pass for efficiency. +fix_file_list() { + # TODO(jzern): this could be more generic and take the array as a param. + files=$(fix_path "${file_list[@]}") + local IFS=$'\n' + file_list=($files) } generate_uuid() {