1. 27 Jul, 2012 2 commits
    • Johann's avatar
      Be consistent with SAD values · 11610551
      Johann authored
      SAD returns unsigned values. Make all the declarations the same.
      
      Remove bestsad initialization and check. It is always set to the
      result of a SAD call so it will never remain UINT_MAX
      
      Use ja instead of jg to test unsigned comparison instead of signed.
      
      Update test.
      
      Change-Id: I46336ab45f4e60fc37caf20bd36bc5782079c7a5
      11610551
    • Attila Nagy's avatar
      Optimizes updates of encoder block ptrs · e66e9ddf
      Attila Nagy authored
      Precalculated block ptrs do not need updates during encoding.
      Set these at init stage.
      
      Moved the allocation of 'mt_current_mb_col' (last encoded MB on each
      row) to vp8_alloc_compressor_data(), so that it is correctly
      reallocated when frame size is changing.
      
      Change-Id: Idcdaa2d0cf3a7f782b7d888626b7cf22a4ffb5c1
      e66e9ddf
  2. 26 Jul, 2012 2 commits
    • Johann's avatar
      SAD cosmetic cleanup · dd0100dd
      Johann authored
      Change-Id: Iae915f2988081697cca6b65943afaca1d8de8df3
      dd0100dd
    • Yunqing Wang's avatar
      multi-res: add drop_frame support · 4066c8b2
      Yunqing Wang authored
      Added drop_frame support in multi-resolution encoder.
      
      If one frame is dropped at a lower-resolution level, the next
      upper-resolution level encoder needs to encode that frame
      independently without any lower-resolution level motion
      information.
      
      Another issue is that if one frame is dropped at some but not all
      resolution levels, a frame after that one may use different set
      of reference frames at different resolution levels. This reference
      frame asynchronization could degrade motion search precision in
      upper-resolution level encoding, which uses lower-resolution level
      motion result. This change compares the lower-resolution and upper-
      resolution level's reference frames. If they are not the same, the
      upper-resolution level encoder can not use lower-resolution level
      motion result.
      
      Change-Id: I61afa4f313630e75b7cbdd5742e230e8724a988a
      4066c8b2
  3. 02 Jul, 2012 1 commit
    • Yunqing Wang's avatar
      Fix subpixel_predict initialization · b2936985
      Yunqing Wang authored
      xd->subpixel_predict16x16 is called in first pass, but isn't
      initialized in first pass, which causes segfault. This patch
      fixed that problem.
      
      Change-Id: Ibd2cad4e2d32ea589fc3e0876d60d3079ae836e7
      b2936985
  4. 20 Jun, 2012 2 commits
    • John Koleszar's avatar
      Fix compilation with -werror · 6291dd4c
      John Koleszar authored
      Fix a last few warnings with multithread, arm, 32 bit
      
      Change-Id: Ic7c67616c370d0ff87562a232fb1e5df0702dc86
      6291dd4c
    • Paul Wilkins's avatar
      Fix segmentation updates with vp8_set_roimap() · 7c32cb52
      Paul Wilkins authored
      Changes relating to Issue 411
      
      Removed code that was clearing down the segmentation data each
      frame.
      
      Added range/parameter checking in vp8_set_roimap(); Return error
      if called when cyclic_refresh is enabled.
      
      Correct setup_features() so that it sets or clears the segment update
      flags as appropriate.
      
      Change-Id: Ib31ac53006640ddf1ba7b9ec8f8b952e3eff860a
      7c32cb52
  5. 12 Jun, 2012 1 commit
  6. 11 Jun, 2012 2 commits
    • John Koleszar's avatar
      Fix pedantic compiler warnings · 0164a1cc
      John Koleszar authored
      Allows building the library with the gcc -pedantic option, for improved
      portabilty. In particular, this commit removes usage of C99/C++ style
      single-line comments and dynamic struct initializers. This is a
      continuation of the work done in commit 97b766a4, which removed most
      of these warnings for decode only builds.
      
      Change-Id: Id453d9c1d9f44cc0381b10c3869fabb0184d5966
      0164a1cc
    • John Koleszar's avatar
      Fix bad merge · 52ec78be
      John Koleszar authored
      Change-Id: I45849dde0ee9b7e87fa32adb65ade8486bb66556
      52ec78be
  7. 07 Jun, 2012 2 commits
    • Yunqing Wang's avatar
      Fix decimation_count in drop_frame · 53d92e61
      Yunqing Wang authored
      Frame dropping decision is made by evaluating both current frame
      and next frame's buffer_level. If both buffer_levels are less
      than drop_mark, next frame is dropped. When frame dropping is
      over, namely, buffer_level becomes normal again, we need to
      reset decimation_count to 0.
      
      Change-Id: Iae182612e61e0da367fbd43afdc90738d975d1a3
      53d92e61
    • Yunqing Wang's avatar
      Remove unused code in drop_frame · 9904c28f
      Yunqing Wang authored
      Removed unused parameters and code related to drop_frame.
      
      Change-Id: I594e050d49b1805c6f72abf06005ef624256bb57
      9904c28f
  8. 06 Jun, 2012 1 commit
    • Marco Paniconi's avatar
      Reset Q for key frame when spatial resizing occurs. · baedcedc
      Marco Paniconi authored
      The logic for spatial resizing is done after the Q is selected for the
      frame. This causes a problem that the Q we select for the (resized)
      key frame may be based on a different resolution than the frame we
      will encode.
      
      This fix is to ensure that, when resize is on, the selected Q is still
      based on the resolution of the frame to be encoded.
      
      Change-Id: Ia49a9eac5f64e48d1c00dfc7ed4ce26fe84d3fa1
      baedcedc
  9. 04 Jun, 2012 2 commits
    • Johann's avatar
      Remove extra enum · 965d8686
      Johann authored
      VP8_REFFRAME is the same as vpx_ref_frame_type
      
      Change-Id: I63c2ddfb39f6ec87d1e5eb6a8852846464552b1b
      965d8686
    • Johann's avatar
      Explicitly discard fwrite/fread return values · c8a88a76
      Johann authored
      Using if(); triggers an empty body warning with clang
      
      Change-Id: I0fa2ee676400a974b40f8eaafca9ae668107eebb
      c8a88a76
  10. 31 May, 2012 4 commits
  11. 30 May, 2012 5 commits
    • Stefan Holmer's avatar
      Added another denoising threshold for finding DC shifts. · dd6134b4
      Stefan Holmer authored
      Compares the sum of differences between the input block and the averaged
      block. If they differ too much the block will not be filtered. Negligible
      perfomance hit.
      
      Change-Id: Ib1c31a265efd4d100b3abc4a1ea6675038c8ddde
      dd6134b4
    • Alpha Lam's avatar
      Make libvpx Chromium build friendly · fc2fc899
      Alpha Lam authored
      Add PRIVATE macro for adding private_extern directive for yasm
      to hide global symbols. This is only enabled if -DCHROMIUM is used
      with YASM.
      
      Also fixed a small problem with	rtcd_defs.sh to guard TEMPORAL_DENOISING.
      
      Change-Id: I9027fce3ebddcf20078293e4b86b396f21da7857
      fc2fc899
    • Jim Bankoski's avatar
      fix denoiser for temporal patterns and rd · f78e5a04
      Jim Bankoski authored
      This extends the denoiser to work for temporally scalable
      coding.
      
      I believe this also fixes a very rare but really bad bug in the original
      implementation.
      
      Change-Id: I8b3593a8c54b86eb76f785af1970935f7d56262a
      f78e5a04
    • Christian Duvivier's avatar
      Inline Intrinsic optimized Denoiser · 5715c39c
      Christian Duvivier authored
      Faster version of denoiser, cut cost by 1.7x for C path, by 3.3x for
      SSE2 path.
      
      Change-Id: I154786308550763bc0e3497e5fa5bfd1ce651beb
      5715c39c
    • Stefan Holmer's avatar
      Added another denoising threshold for finding DC shifts. · d8500344
      Stefan Holmer authored
      Compares the sum of differences between the input block and the averaged
      block. If they differ too much the block will not be filtered. Negligible
      perfomance hit.
      
      Change-Id: Ib1c31a265efd4d100b3abc4a1ea6675038c8ddde
      d8500344
  12. 24 May, 2012 2 commits
    • Jim Bankoski's avatar
      fix denoiser for temporal patterns and rd · 57faddb7
      Jim Bankoski authored
      This extends the denoiser to work for temporally scalable
      coding.
      
      I believe this also fixes a very rare but really bad bug in the original
      implementation.
      
      
      Change-Id: I8b3593a8c54b86eb76f785af1970935f7d56262a
      57faddb7
    • Alpha Lam's avatar
      Make libvpx Chromium build friendly · 0f7e4665
      Alpha Lam authored
      Add PRIVATE macro for adding private_extern directive for yasm
      to hide global symbols. This is only enabled if -DCHROMIUM is used
      with YASM.
      
      Also fixed a small problem with	rtcd_defs.sh to guard TEMPORAL_DENOISING.
      
      Change-Id: I9027fce3ebddcf20078293e4b86b396f21da7857
      0f7e4665
  13. 23 May, 2012 3 commits
    • Attila Nagy's avatar
      Fix another multithreaded encoder loopfilter race condition · 48908530
      Attila Nagy authored
      After a key frame encoding, the frame type could change while
      filtering is still going on. Pass the frame type as parameter to the
      loopfilter function and don't read it from common storage.
      
      vp8cx_set_alt_lf_level has to be done before packing the stream.
      Currently alt_lf_level is not used so there hasn't been any visible
      problem here.
      
      Change-Id: Ia114162158cd833c2b16e3b89303cc9c91f19165
      48908530
    • John Koleszar's avatar
      Fix memory leak in vpx_codec_enc_config_set() · cf097015
      John Koleszar authored
      Resolution changes in calls to vpx_codec_enc_config_set() would cause
      a memory leak due to failing to release the lookahead and alt ref
      buffers.
      
      Change-Id: I48392ea25e71fe2760d60cfde3fb3874598cc85f
      cf097015
    • Attila Nagy's avatar
      Fix another multithreaded encoder loopfilter race condition · ea392d47
      Attila Nagy authored
      After a key frame encoding, the frame type could change while
      filtering is still going on. Pass the frame type as parameter to the
      loopfilter function and don't read it from common storage.
      
      vp8cx_set_alt_lf_level has to be done before packing the stream.
      Currently alt_lf_level is not used so there hasn't been any visible
      problem here.
      
      Change-Id: Ia114162158cd833c2b16e3b89303cc9c91f19165
      ea392d47
  14. 22 May, 2012 2 commits
    • John Koleszar's avatar
      Move all tests to test/ directory · 2d225689
      John Koleszar authored
      Consolodate the unit tests under vp8/ to the test/ directory
      
      Change-Id: I6d6a0fb60f5e3874a4d6710e9e121dd3e81a93db
      2d225689
    • John Koleszar's avatar
      Build unit tests monolithically · e82d261d
      John Koleszar authored
      Rework unit tests  to have a single executable rather than many, which
      should avoid pollution of the visual studio project namespace, improve
      build times, and make it easier to use the gtest test sharding system
      when we get these going on the continuous build cluster.
      
      Change-Id: If4c3e5d4b3515522869de6c89455c2a64697cca6
      e82d261d
  15. 21 May, 2012 1 commit
  16. 16 May, 2012 1 commit
    • Yunqing Wang's avatar
      multi-res: force Key frame sychronization · 65dd157c
      Yunqing Wang authored
      In multi-resolution encoding, frame_type decision for each frame
      is made by the lowest-resolution encoder. For all other higher-
      resolution encoders, kf_mode is always set to VPX_KF_DISABLED,
      and they are forced to use the same frame_type picked by the
      lowest-resolution encoder.
      
      Change-Id: Ic4d52ec65bbc012ca9c2d236210e28a295591eaf
      65dd157c
  17. 11 May, 2012 1 commit
  18. 08 May, 2012 1 commit
    • Jim Bankoski's avatar
      vp8e - boolcoder unit test · 9851486b
      Jim Bankoski authored
      Adds a unit test to the boolcoder that tests encoding 
      and decoding thousands of different bits, with different 
      probabilities in different patterns.   
      
      Code borrowed from the webp project - and its committers.
      
      Change-Id: Icabbb884d57e666496490c961dd29b246144ab3e
      9851486b
  19. 04 May, 2012 5 commits
    • John Koleszar's avatar
      fix vp8_ namespace issues · 14d827f4
      John Koleszar authored
      Make functions only referenced from one translation unit static. Other
      symbols with extern linkage get a vp8/vpx prefix.
      
      Change-Id: I928c7e0d0d36e89ac78cb54ff8bb28748727834f
      14d827f4
    • John Koleszar's avatar
      Formalize encodeframe.c forward delclarations · 22f56b93
      John Koleszar authored
      Change If4321cc5 fixed a bug caused by forward declarations not being
      kept in sync across C files, resulting in a function call with the
      wrong arguments. The commit moves the affected function declarations
      into a header file, along with the other symbols from encodeframe.c
      that were being sloppily shared.
      
      Change-Id: I76a7b4c66d4fe175f9cbef7e52148655e4bb9ba1
      22f56b93
    • Attila Nagy's avatar
      Fix multi-resolution threaded encoding · 3e32105d
      Attila Nagy authored
      mb_row and mb_col was not passed to vp8cx_encode_inter_macroblock in
      threaded encoding.
      
      Change-Id: If4321cc59bf91e991aa31e772f882ed5f2bbb201
      3e32105d
    • Attila Nagy's avatar
      Make global data const · f039a85f
      Attila Nagy authored
      Removes all runtime initialization of global data. This commit is a
      squashed version of the following series cherry-picked from master.
      This is necessary because of a change that was merged to the tester
      that depends on the scaler being moved to the RTCD framework, which
      is a worthwhile thing to include in Eider anyway.
      
        - a91b42f0 Makes all global data in entropy.c const
        - b35a0db0 Makes all global data in tokenize.c const
        - 441cac8e Makes all mode token tables const
        - 5948a021 Ports vpx_xcaler to new RTCD method
        - 317d4244 Makes all mode token tables const part 2
      
      Change-Id: Ifeaea24df2b731e7c509fa6c6ef6891a374afc26
      f039a85f
    • Attila Nagy's avatar
      Fix multi-resolution threaded encoding · 357800e7
      Attila Nagy authored
      mb_row and mb_col was not passed to vp8cx_encode_inter_macroblock in
      threaded encoding.
      
      Change-Id: If4321cc59bf91e991aa31e772f882ed5f2bbb201
      357800e7