1. 29 Jul, 2015 1 commit
  2. 17 Jul, 2015 1 commit
  3. 15 Jul, 2015 1 commit
  4. 14 Jul, 2015 2 commits
    • Marco's avatar
      Fix to resize logic for 1 pass mode. · dc7da005
      Marco authored
      Proper use/update of resize_state and resize_pending to constrain
      the total amount of downsizing to be at most one scale down, for now.
      
      Change-Id: Id18fc32499f2fbdbec16728dcdc9e4eac09098f0
      dc7da005
    • Debargha Mukherjee's avatar
      Fixes part of merge regression from adding arf parameters. · 3c524488
      Debargha Mukherjee authored
      From Change  Ibf0c30b72074b3f71918ab278ccccc02a95a70a0
      There is still an issue relating to one animated test clip with repeat
      patterns where this change effectively increase the default  maximum
      arf interval by +1. This can be examined seperately.
      
      Change-Id: Idd01d5480fc45202d8a059a0c3afc0997cc5bdd1
      3c524488
  5. 06 Jul, 2015 1 commit
    • Debargha Mukherjee's avatar
      Expose params min-gf-interval/max-gf-interval · 98526433
      Debargha Mukherjee authored
      Adds two new vp9 parameters --min-gf-interval and --max-gf-interval
      to enable testing based on frequency of alt-ref frames.
      
      Also adds a unit-test to test enforcement of min-gf-interval.
      
      For both these parameters the default value is 0, which indicates
      they are picked by the encoder, based on resolution and framerate
      considerations. If they are greater than zero, the specified
      parameter is honored.
      
      (Additional note by paulwilkins)
      Note that there is a slight oddity in that key frames are also GFs and
      considered part of  GF only group. However they are treated as not
      being part of an arf group because for arf groups the previous GF is
      assumed to be the terminal or overlay frame for the previous group.
      
      (end note)
      
      Change-Id: Ibf0c30b72074b3f71918ab278ccccc02a95a70a0
      98526433
  6. 25 Jun, 2015 1 commit
    • Marco's avatar
      Update to dynamic resize logic for 1pass CBR. · 1c7b1f9a
      Marco authored
      Only do the check for resizing if the feature is selected
      (i.e., resize_mode = RESIZE_DYNAMIC).
      
      And modify condition for checking to be resize_count >= window,
      (since framerate can change).
      
      Change-Id: Idceb4e50956bb965a1492b4993b0dcb393c9be4d
      1c7b1f9a
  7. 19 Jun, 2015 2 commits
    • Yaowu Xu's avatar
      Fix a msvc compiler warning · d8428ae3
      Yaowu Xu authored
      Change-Id: Ida8a04370895ed14bd118324ec2577da926e4648
      d8428ae3
    • Marco's avatar
      Add dynamic resize logic for 1 pass CBR. · d77f51ba
      Marco authored
      Decision to scale down/up is based on buffer state and average QP
      over previous time window. Limit the total amount of down-scaling
      to be at most one scale down for now.
      
      Reset certain quantities after resize (buffer level, cyclic refresh,
      rate correction factor).
      
      Feature is enable via the setting rc_resize_allowed = 1.
      
      Change-Id: I9b1a53024e1e1e953fb8a1e1f75d21d160280dc7
      d77f51ba
  8. 02 Jun, 2015 1 commit
    • Marco's avatar
      Vidyo patch: Rate control for SVC, 1 pass CBR mode. · c139b81a
      Marco authored
      -Make Rate control work for SVC 1 pass CBR mode.
      -Added temporal layering mode.
      -Fixed bug in non-rd variance partition.
      -Modified/updated the sample encoders (vp9_spatial_svc_encoder, vpx_temporal_svc_encoder).
      -Added datarate unittest(s) for 1 pass CBR SVC.
      
      Change-Id: Ie94b1b68a56ea1267b5087c625e5df04def2ee48
      c139b81a
  9. 20 May, 2015 2 commits
    • paulwilkins's avatar
      Fast feedback of bits on undershoot. · 883fdd45
      paulwilkins authored
      This patch provides a partial rapid feedback of bits
      resulting from extreme undershoot.
      
      Some  improvement on some problem animated material
      but in its current form only a small impact on the metrics results
      of our standard test sets.
      
      Change-Id: Ie03036ea8123bc2553437cb8c8c9e7a9fc5dac5d
      883fdd45
    • paulwilkins's avatar
      Fix issues with mixed ARF and GF groups. · ade9693a
      paulwilkins authored
      This patch addresses two issues that can occur when the
      encoder chooses to use a mixture of ARF and GF groups.
      
      The first issue relates to a failure to reset the "ARF active" flag
      correctly when transitioning from coding ARF groups to coding
      GF groups. This caused some golden frames to be  encoded
      with an incorrect bit rate target as if they were ARF overlay frames.
      
      The second issue relates to the encoding of a single short GF group
      just before a key frame.  Where the last group before a key frame
      is an ARF group we expect the final frame before the key frame  to
      be an low data rate overlay frame. However, when the last  group
      is a GF group, the final frame before the key frame should be a normal
      frame with a normal bit allocation. This issue had the potential to cause
      a single poorly coded frame just before a key frame. If that key frame
      were a forced key frame rather than a real scene cut, this might cause
      pulsing.
      
      Change-Id: Idf1eb5eaf63a231495a74de7899236e1ead9fb00
      ade9693a
  10. 15 May, 2015 1 commit
  11. 13 May, 2015 1 commit
    • Johann's avatar
      Relocate memory operations for common code · 1d7ccd53
      Johann authored
      With the sad functions, and hopefully the variance functions soon,
      moving to the vpx_dsp location, place the defines used in the
      reference C code in a common location.
      
      Change-Id: I4c8ce7778eb38a0a3ee674d2f1c488eda01cfeca
      1d7ccd53
  12. 11 May, 2015 1 commit
    • Marco's avatar
      Fix rate control issue with layers and aq-mode=3. · 913862be
      Marco authored
      When aq-mode=3 is enabled, only for base layer frames should the
      qp of the frame incorporate the segment delta-qp.
      
      This was causing more rate mismatch for the enhancement layer frames
      when running temporal layers with aq-mode=3 on.
      
      Change-Id: I1c5e69d1ef8a51188af8696753c17fd8f67699b3
      913862be
  13. 01 May, 2015 1 commit
    • paulwilkins's avatar
      Adjust ARF min and max interval. · e0786c28
      paulwilkins authored
      Previously limit on max interval  set to 0.5 seconds.
      Though this helped some low frame rate material it
      appears to be a bit too aggressive for some 24 and 25 fps
      content. This patch relaxes the limit to 0.75 seconds.
      
      The patch also adds a new minimum interval variable
      to replace the current hard wired value. This allows us
      to impose a limit on the maximum number of primary
      arfs per second for high frame rate (e.g. 50 & 60fps)
      content. This is to address concerns regarding playback
      performance on some platforms if there is a high base
      frame rate and very frequent arfs.
      
      Change-Id: I373e8b6b2a8ef522eced6c6d2cceb234ff763fcf
      e0786c28
  14. 16 Apr, 2015 1 commit
    • paulwilkins's avatar
      Limit arf interval for low fpf clips. · effd974b
      paulwilkins authored
      This patch limits  the maximum arf interval length to
      approximately half a second. In some low fps animations in
      particular the existing code was selecting an overly long interval
      which was hurting visual quality. For a sample problem test clip
      (360P animation , 15fps, ~200Kbit/s) this change also improved
      metrics by >0.5 db.
      
      There may be some clips where this hurts metrics a little, but the
      worst case impact visually is likely to be less than having an
      interval that is much too long. On more normal material at 24
      fps or higher, the impact is likely to be nil/minimal.
      
      Change-Id: Id8b57413931a670c861213ea91d7cc596375a297
      effd974b
  15. 11 Mar, 2015 2 commits
  16. 10 Mar, 2015 2 commits
    • Marco's avatar
      Modify update golden reference update under aq-mode=3 mode. · fb31aa09
      Marco authored
      For non-SVC 1 pass CBR: make the GF update interval a multiple of the
      cyclic refresh period, and use encoding stats to prevent GF update at certain times.
      
      Change-Id: I4c44cacc2f70f1d27391a47644837e1eaa065017
      fb31aa09
    • Adrian Grange's avatar
      Fix vp9_compute_qdelta_by_rate loop behavior · 78df7122
      Adrian Grange authored
      The return value from vp9_compute_qdelta_by_rate, which is
      a delta value for the quantizer, could never be 0 if
      (qindex == rc->worst_quality).
      
      This occurs because target_index was setup unconditionally
      in the loop and yet the loop counter stopped at
      (rc->worst_quality - 1).
      
      Change-Id: I6b59cd9b5811ff33357e71cd7d814c5e53d291f2
      78df7122
  17. 09 Mar, 2015 1 commit
    • paulwilkins's avatar
      Allow q adjustment for VPX_CQ and VPX_CBR. · 2cff9c4e
      paulwilkins authored
      Adjustment previously only enabled in VBR mode.
      
      This patch allows adjustment of min and max q for CBR
      and adjustment of max q only for CQ mode.
      
      Change-Id: Id5e583f3d50453cd544fc57249acacd946457482
      2cff9c4e
  18. 13 Feb, 2015 1 commit
    • Yaowu Xu's avatar
      Fix an encoder/decode mismatch bug · 4bc7f482
      Yaowu Xu authored
      This commit prevent the encoder to update last_frame_type when a frame
      is dropped in the encoder. Prior to this fix, if there is a dropped
      frame immediatedly after a key frame, decoder would have the value of
      last_frame_type as key frame, different from encoder as the dropped
      frame in encoder would have updated the value to an inter frame. This
      leads to different probability update in encoder and decoder, thereby
      encoder/decoder mismatch.
      
      This fixes issue #941
      
      Change-Id: I27115224b138bec43ae3916c016574f5740822b0
      4bc7f482
  19. 11 Feb, 2015 1 commit
  20. 10 Feb, 2015 1 commit
    • Adrian Grange's avatar
      Auto-adaptive encoder frame resizing logic · 23ebacdb
      Adrian Grange authored
      Note: This feature is still in development.
      
      Add an option for the encoder to decide the resolution
      at which to encode each frame.
      
      Each KF/GF/ARF goup is tested to see if it would be
      better encoded at a lower resolution. At present, each
      KF/GF/ARF is coded first at full-size and if the coded
      size exceeds a threshold (twice target data rate) at
      the maximum active Q then the entire group is encoded
      at lower resolution.
      
      This feature is enabled in vpxenc by setting:
        --resize-allowed=1
      
      In addition, if the vpxenc command line also specifies
      valid frame dimensions using:
        --resize-width=XXXX & --resize_height=YYYY
      then *all* frames will be encoded at this resolution.
      
      Change-Id: I13f341e0a82512f9e84e144e0f3b5aed8a65402b
      23ebacdb
  21. 28 Jan, 2015 1 commit
  22. 21 Jan, 2015 1 commit
    • Paul Wilkins's avatar
      Bug when last group before forced key frame is short. · 0bff1efc
      Paul Wilkins authored
      Just before a forced key frame we often get a foreshortened
      arf/gf group. In such a case, we do not want to update
      rc->last_boosted_qindex, which is used to define the Q range
      for the forced key frame itself.
      
      This gives a small average metrics gain for the YT and YT-HD sets
      (eg. YT SSIM +0.141%).
      
      Change-Id: Ie06698bc4f249e87183b8f8fb27ff8f3fde216d9
      0bff1efc
  23. 05 Dec, 2014 1 commit
  24. 03 Dec, 2014 1 commit
  25. 02 Dec, 2014 1 commit
  26. 25 Nov, 2014 1 commit
    • Yaowu Xu's avatar
      Separate rate_correction_factor for boosted GFs · e4234b3f
      Yaowu Xu authored
      When the golden frame is boosted, the rate correction factor is not
      correlated well with other inter frames even in CBR mode. This commit
      changes to use GF specific rate_correction_factor when gf_cbr_boost
      is greater than 20%.
      
      Change-Id: I6312c1564387bcacc11f4c5e8a9cfdc781b5c3ab
      e4234b3f
  27. 19 Nov, 2014 1 commit
    • Yaowu Xu's avatar
      Add a reset to rc tracking for dropped frames · 21db24ef
      Yaowu Xu authored
      VP9/DatarateTestVP9Large.ChangingDropFrameThresh/[34] fails post the
      merge of commit#ffa06b37. This commit adds reset of rc tracking info
      when frame is dropped, and fixes the causes of the bad interaction
      between the tests and the previous commit.
      
      Change-Id: I848acfd9fcb336359662274325190f94aac76eae
      21db24ef
  28. 18 Nov, 2014 1 commit
    • Yaowu Xu's avatar
      Prevent severe rate control errors in CBR mode · ffa06b37
      Yaowu Xu authored
      In rare cases, the interaction between rate correction factor and Q
      choices may cause severe oscillating frame sizes that are way off
      target bandwidth. This commit adds tracking of rate control results
      for last two frames, and use the information to prevent oscillating
      Q choices.
      
      Change-Id: I9a6d125a15652b9bcac0e1fec6d7a1aedc4ed97e
      ffa06b37
  29. 17 Nov, 2014 1 commit
    • Marco's avatar
      Modify active_worst_quality setting for one pass CBR. · b660f723
      Marco authored
      Current setting had active_worst_quality set too high (close to worst_quality)
      for first frame(s) following first key frame. This changes that to be somewhat
      more aggressive in allowing active_worst_quality to be lower following key frame.
      
      Also remove the 4/5 reduction in active_worst for key frame as
      this should be set by the user qp_max setting.
      
      Change-Id: I0530b3ddcc85c00e3eb7568de1b14a31206c4a4c
      b660f723
  30. 13 Nov, 2014 2 commits
    • Adrian Grange's avatar
      Prepare for dynamic frame resizing in the recode loop · 0d085ebc
      Adrian Grange authored
      Prepare for the introduction of frame-size change
      logic into the recode loop.
      
      Separated the speed dependent features into
      separate static and dynamic parts, the latter being
      those features that are dependent on the frame size.
      
      Change-Id: Ia693e28c5cf069a1a7bf12e49ecf83e440e1d313
      0d085ebc
    • Yaowu Xu's avatar
      adapt the adjustment limit for rate correction factor in RTC mode · 9f79259e
      Yaowu Xu authored
      Rate correction factor is used to correct the estimated rate for any
      given quantizer, and feeds into rate control for quantizer selection.
      We make use of the actual bits used to calculate this rate correction
      factor with an adjustment limit to prevent over-adjustment.
      
      This commit adapts the adjustment limit to the difference between the
      estimated bits and the actual bits, allows the adjustment limit to vary
      between 0.125 (when estimate is close to actual) and 0.625 (when there
      is >10X factor off between estimated and actual bits). By doing this,
      the commit appears to have largely corrected two observed issues:
      1. Adjustment is too slow when the actual bits used is way off from
      estimate due to the small adjustment limit.
      2. Extreme oscillating quantizer choices due to the feedback loop.
      
      Change-Id: I4ee148d2c9d26d173b6c48011313ddb07ce2d7d6
      9f79259e
  31. 11 Nov, 2014 1 commit
    • Yaowu Xu's avatar
      Use normal rate_correction_factor for gf in CBR mode · f2b978e8
      Yaowu Xu authored
      I0c5f010 changed to allow update golden reference buffer in CBR mode,
      this commit changes the use of rate_correction_factor for those frames
      to be aligned with the new usage. This commit attempts to solve two
      issues:
      
      a. Initialization of rate correction factor for Golden Frame
      Prior to this patch, even the regular inter frame has been update
      the rate correction factor based on content and encoding results,
      the first golden frame would still use the ininitialized value
      that can be way off.
      
      b. Allowing rate correction factor update to be slightly faster
      Prior to this patch, when the rate correction factor is off, the
      update to the factor is too slow, the factor could not get close
      to a semi-correct value even after many frames.
      
      The commit helps all clips in psnr/ssim metric, but especially to
      a few clip in RTC set that rate correction was way off. For example
      thaloundeskmtgvga gained about .5dB for both overall/average psnr.
      
      Change-Id: I0be5c41691be57891d824505348b64be87fa3545
      f2b978e8
  32. 28 Oct, 2014 1 commit
    • Yaowu Xu's avatar
      Allow update of golden refernce buffer in CBR mode · e5cd5188
      Yaowu Xu authored
      This commit changes to allow the usage of golden reference frame in
      VP9 CBR mode to improve quality. VP9 supports potentially up to 8
      reference buffers, it has reference buffers available for this
      purpose. This was not possible in VP8 as golden and alt-ref buffers
      were used for temporal scalability purpose in CBR mode in WebRTC.
      
      For frames that update golden frame, there can be a quality boost.
      The amount of allowed bitrate boost can be controlled via parameter
      rc_max_inter_bitrate_pct. The inital value of the boost ratior is
      currently based on over_shoot_pct. Further experiments will work
      out the adaption of this boost value.
      
      Change-Id: I0c5f010c8fd8b7b598f69779c1b30e5b2ac30a4d
      e5cd5188
  33. 24 Oct, 2014 1 commit
  34. 23 Oct, 2014 1 commit
    • Paul Wilkins's avatar
      Enable dual arf with constant q. · 8fc3ab77
      Paul Wilkins authored
      Add second level arf Q adjustment when using dual arfs
      in constant Q mode.
      
      Previously in constant Q mode enabling dual arf hurt by ~5%
      but with this change the average benefit is ~1-1.5% with some
      mid range data points up ~10%.
      
      Note however that it still hurts on some clips including
      some very low motion show content.
      
      Change-Id: I5b7789a2f42a6127d9e801cc010c20a7113bdd9b
      8fc3ab77