Commit 97b766a4 authored by Timothy B. Terriberry's avatar Timothy B. Terriberry Committed by John Koleszar

Eliminate more warnings.

This eliminates a large set of warnings exposed by the Mozilla build
 system (Use of C++ comments in ISO C90 source, commas at the end of
 enum lists, a couple incomplete initializers, and signed/unsigned
 comparisons).
It also eliminates many (but not all) of the warnings expose by newer
 GCC versions and _FORTIFY_SOURCE (e.g., calling fread and fwrite
 without checking the return values).
There are a few spurious warnings left on my system:

../vp8/encoder/encodemb.c:274:9: warning: 'sz' may be used
 uninitialized in this function
gcc seems to be unable to figure out that the value shortcut doesn't
 change between the two if blocks that test it here.

../vp8/encoder/onyx_if.c:5314:5: warning: comparison of unsigned
 expression >= 0 is always true
../vp8/encoder/onyx_if.c:5319:5: warning: comparison of unsigned
 expression >= 0 is always true
This is true, so far as it goes, but it's comparing against an enum,
 and the C standard does not mandate that enums be unsigned, so the
 checks can't be removed.

Change-Id: Iead6cd561a2afaa3d801fd63f1d8d58953da7426
parent 6fda7668
...@@ -61,8 +61,8 @@ int main(int argc, char **argv) { ...@@ -61,8 +61,8 @@ int main(int argc, char **argv) {
die("Failed to open %s for writing", argv[2]); die("Failed to open %s for writing", argv[2]);
/* Read file header */ /* Read file header */
fread(file_hdr, 1, IVF_FILE_HDR_SZ, infile); if(!(fread(file_hdr, 1, IVF_FILE_HDR_SZ, infile) == IVF_FILE_HDR_SZ
if(!(file_hdr[0]=='D' && file_hdr[1]=='K' && file_hdr[2]=='I' && file_hdr[0]=='D' && file_hdr[1]=='K' && file_hdr[2]=='I'
&& file_hdr[3]=='F')) && file_hdr[3]=='F'))
die("%s is not an IVF file.", argv[1]); die("%s is not an IVF file.", argv[1]);
......
...@@ -48,7 +48,7 @@ for(plane=0; plane < 3; plane++) { ...@@ -48,7 +48,7 @@ for(plane=0; plane < 3; plane++) {
unsigned char *buf =img->planes[plane]; unsigned char *buf =img->planes[plane];
for(y=0; y<img->d_h >> (plane?1:0); y++) { for(y=0; y<img->d_h >> (plane?1:0); y++) {
fwrite(buf, 1, img->d_w >> (plane?1:0), outfile); if(fwrite(buf, 1, img->d_w >> (plane?1:0), outfile));
buf += img->stride[plane]; buf += img->stride[plane];
} }
} }
......
...@@ -85,7 +85,7 @@ static void write_ivf_file_header(FILE *outfile, ...@@ -85,7 +85,7 @@ static void write_ivf_file_header(FILE *outfile,
mem_put_le32(header+24, frame_cnt); /* length */ mem_put_le32(header+24, frame_cnt); /* length */
mem_put_le32(header+28, 0); /* unused */ mem_put_le32(header+28, 0); /* unused */
fwrite(header, 1, 32, outfile); if(fwrite(header, 1, 32, outfile));
} }
...@@ -103,7 +103,7 @@ static void write_ivf_frame_header(FILE *outfile, ...@@ -103,7 +103,7 @@ static void write_ivf_frame_header(FILE *outfile,
mem_put_le32(header+4, pts&0xFFFFFFFF); mem_put_le32(header+4, pts&0xFFFFFFFF);
mem_put_le32(header+8, pts >> 32); mem_put_le32(header+8, pts >> 32);
fwrite(header, 1, 12, outfile); if(fwrite(header, 1, 12, outfile));
} }
int main(int argc, char **argv) { int main(int argc, char **argv) {
......
...@@ -61,8 +61,8 @@ if(vpx_codec_encode(&codec, frame_avail? &raw : NULL, frame_cnt, ...@@ -61,8 +61,8 @@ if(vpx_codec_encode(&codec, frame_avail? &raw : NULL, frame_cnt,
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PROCESS_FRAME ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PROCESS_FRAME
case VPX_CODEC_CX_FRAME_PKT: case VPX_CODEC_CX_FRAME_PKT:
write_ivf_frame_header(outfile, pkt); write_ivf_frame_header(outfile, pkt);
fwrite(pkt->data.frame.buf, 1, pkt->data.frame.sz, if(fwrite(pkt->data.frame.buf, 1, pkt->data.frame.sz,
outfile); outfile));
break; break;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PROCESS_FRAME ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PROCESS_FRAME
......
...@@ -228,4 +228,4 @@ enum mkv ...@@ -228,4 +228,4 @@ enum mkv
// TagString = 0x4487, // TagString = 0x4487,
// TagBinary = 0x4485, // TagBinary = 0x4485,
}; };
#endif #endif
\ No newline at end of file
...@@ -56,7 +56,7 @@ int vp8_alloc_frame_buffers(VP8_COMMON *oci, int width, int height) ...@@ -56,7 +56,7 @@ int vp8_alloc_frame_buffers(VP8_COMMON *oci, int width, int height)
vp8_de_alloc_frame_buffers(oci); vp8_de_alloc_frame_buffers(oci);
// our internal buffers are always multiples of 16 /* our internal buffers are always multiples of 16 */
if ((width & 0xf) != 0) if ((width & 0xf) != 0)
width += 16 - (width & 0xf); width += 16 - (width & 0xf);
...@@ -153,7 +153,7 @@ void vp8_setup_version(VP8_COMMON *cm) ...@@ -153,7 +153,7 @@ void vp8_setup_version(VP8_COMMON *cm)
cm->full_pixel = 1; cm->full_pixel = 1;
break; break;
default: default:
//4,5,6,7 are reserved for future use /*4,5,6,7 are reserved for future use*/
cm->no_lpf = 0; cm->no_lpf = 0;
cm->simpler_lpf = 0; cm->simpler_lpf = 0;
cm->use_bilinear_mc_filter = 0; cm->use_bilinear_mc_filter = 0;
...@@ -177,10 +177,10 @@ void vp8_create_common(VP8_COMMON *oci) ...@@ -177,10 +177,10 @@ void vp8_create_common(VP8_COMMON *oci)
oci->clr_type = REG_YUV; oci->clr_type = REG_YUV;
oci->clamp_type = RECON_CLAMP_REQUIRED; oci->clamp_type = RECON_CLAMP_REQUIRED;
// Initialise reference frame sign bias structure to defaults /* Initialise reference frame sign bias structure to defaults */
vpx_memset(oci->ref_frame_sign_bias, 0, sizeof(oci->ref_frame_sign_bias)); vpx_memset(oci->ref_frame_sign_bias, 0, sizeof(oci->ref_frame_sign_bias));
// Default disable buffer to buffer copying /* Default disable buffer to buffer copying */
oci->copy_buffer_to_gf = 0; oci->copy_buffer_to_gf = 0;
oci->copy_buffer_to_arf = 0; oci->copy_buffer_to_arf = 0;
} }
......
...@@ -49,7 +49,7 @@ extern void vp8_filter_block2d_bil_second_pass_armv6 ...@@ -49,7 +49,7 @@ extern void vp8_filter_block2d_bil_second_pass_armv6
const short *vp8_filter const short *vp8_filter
); );
/* #if 0
void vp8_filter_block2d_bil_first_pass_6 void vp8_filter_block2d_bil_first_pass_6
( (
unsigned char *src_ptr, unsigned char *src_ptr,
...@@ -66,14 +66,14 @@ void vp8_filter_block2d_bil_first_pass_6 ...@@ -66,14 +66,14 @@ void vp8_filter_block2d_bil_first_pass_6
{ {
for ( j=0; j<output_width; j++ ) for ( j=0; j<output_width; j++ )
{ {
// Apply bilinear filter /* Apply bilinear filter */
output_ptr[j] = ( ( (int)src_ptr[0] * vp8_filter[0]) + output_ptr[j] = ( ( (int)src_ptr[0] * vp8_filter[0]) +
((int)src_ptr[1] * vp8_filter[1]) + ((int)src_ptr[1] * vp8_filter[1]) +
(VP8_FILTER_WEIGHT/2) ) >> VP8_FILTER_SHIFT; (VP8_FILTER_WEIGHT/2) ) >> VP8_FILTER_SHIFT;
src_ptr++; src_ptr++;
} }
// Next row... /* Next row... */
src_ptr += src_pixels_per_line - output_width; src_ptr += src_pixels_per_line - output_width;
output_ptr += output_width; output_ptr += output_width;
} }
...@@ -96,7 +96,7 @@ void vp8_filter_block2d_bil_second_pass_6 ...@@ -96,7 +96,7 @@ void vp8_filter_block2d_bil_second_pass_6
{ {
for ( j=0; j<output_width; j++ ) for ( j=0; j<output_width; j++ )
{ {
// Apply filter /* Apply filter */
Temp = ((int)src_ptr[0] * vp8_filter[0]) + Temp = ((int)src_ptr[0] * vp8_filter[0]) +
((int)src_ptr[output_width] * vp8_filter[1]) + ((int)src_ptr[output_width] * vp8_filter[1]) +
(VP8_FILTER_WEIGHT/2); (VP8_FILTER_WEIGHT/2);
...@@ -104,12 +104,12 @@ void vp8_filter_block2d_bil_second_pass_6 ...@@ -104,12 +104,12 @@ void vp8_filter_block2d_bil_second_pass_6
src_ptr++; src_ptr++;
} }
// Next row... /* Next row... */
//src_ptr += src_pixels_per_line - output_width; /*src_ptr += src_pixels_per_line - output_width;*/
output_ptr += output_pitch; output_ptr += output_pitch;
} }
} }
*/ #endif
void vp8_filter_block2d_bil_armv6 void vp8_filter_block2d_bil_armv6
( (
...@@ -124,13 +124,13 @@ void vp8_filter_block2d_bil_armv6 ...@@ -124,13 +124,13 @@ void vp8_filter_block2d_bil_armv6
) )
{ {
unsigned short FData[36*16]; // Temp data bufffer used in filtering unsigned short FData[36*16]; /* Temp data bufffer used in filtering */
// First filter 1-D horizontally... /* First filter 1-D horizontally... */
// pixel_step = 1; /* pixel_step = 1; */
vp8_filter_block2d_bil_first_pass_armv6(src_ptr, FData, src_pixels_per_line, Height + 1, Width, HFilter); vp8_filter_block2d_bil_first_pass_armv6(src_ptr, FData, src_pixels_per_line, Height + 1, Width, HFilter);
// then 1-D vertically... /* then 1-D vertically... */
vp8_filter_block2d_bil_second_pass_armv6(FData, output_ptr, dst_pitch, Height, Width, VFilter); vp8_filter_block2d_bil_second_pass_armv6(FData, output_ptr, dst_pitch, Height, Width, VFilter);
} }
......
...@@ -20,13 +20,13 @@ ...@@ -20,13 +20,13 @@
DECLARE_ALIGNED(16, static const short, sub_pel_filters[8][6]) = DECLARE_ALIGNED(16, static const short, sub_pel_filters[8][6]) =
{ {
{ 0, 0, 128, 0, 0, 0 }, // note that 1/8 pel positions are just as per alpha -0.5 bicubic { 0, 0, 128, 0, 0, 0 }, /* note that 1/8 pel positions are just as per alpha -0.5 bicubic */
{ 0, -6, 123, 12, -1, 0 }, { 0, -6, 123, 12, -1, 0 },
{ 2, -11, 108, 36, -8, 1 }, // New 1/4 pel 6 tap filter { 2, -11, 108, 36, -8, 1 }, /* New 1/4 pel 6 tap filter */
{ 0, -9, 93, 50, -6, 0 }, { 0, -9, 93, 50, -6, 0 },
{ 3, -16, 77, 77, -16, 3 }, // New 1/2 pel 6 tap filter { 3, -16, 77, 77, -16, 3 }, /* New 1/2 pel 6 tap filter */
{ 0, -6, 50, 93, -9, 0 }, { 0, -6, 50, 93, -9, 0 },
{ 1, -8, 36, 108, -11, 2 }, // New 1/4 pel 6 tap filter { 1, -8, 36, 108, -11, 2 }, /* New 1/4 pel 6 tap filter */
{ 0, -1, 12, 123, -6, 0 }, { 0, -1, 12, 123, -6, 0 },
}; };
...@@ -93,34 +93,34 @@ void vp8_sixtap_predict_armv6 ...@@ -93,34 +93,34 @@ void vp8_sixtap_predict_armv6
{ {
const short *HFilter; const short *HFilter;
const short *VFilter; const short *VFilter;
DECLARE_ALIGNED_ARRAY(4, short, FData, 12*4); // Temp data bufffer used in filtering DECLARE_ALIGNED_ARRAY(4, short, FData, 12*4); /* Temp data bufffer used in filtering */
HFilter = sub_pel_filters[xoffset]; // 6 tap HFilter = sub_pel_filters[xoffset]; /* 6 tap */
VFilter = sub_pel_filters[yoffset]; // 6 tap VFilter = sub_pel_filters[yoffset]; /* 6 tap */
// Vfilter is null. First pass only /* Vfilter is null. First pass only */
if (xoffset && !yoffset) if (xoffset && !yoffset)
{ {
//vp8_filter_block2d_first_pass_armv6 ( src_ptr, FData+2, src_pixels_per_line, 4, 4, HFilter ); /*vp8_filter_block2d_first_pass_armv6 ( src_ptr, FData+2, src_pixels_per_line, 4, 4, HFilter );
//vp8_filter_block2d_second_pass_armv6 ( FData+2, dst_ptr, dst_pitch, 4, VFilter ); vp8_filter_block2d_second_pass_armv6 ( FData+2, dst_ptr, dst_pitch, 4, VFilter );*/
vp8_filter_block2d_first_pass_only_armv6(src_ptr, dst_ptr, src_pixels_per_line, 4, dst_pitch, HFilter); vp8_filter_block2d_first_pass_only_armv6(src_ptr, dst_ptr, src_pixels_per_line, 4, dst_pitch, HFilter);
} }
// Hfilter is null. Second pass only /* Hfilter is null. Second pass only */
else if (!xoffset && yoffset) else if (!xoffset && yoffset)
{ {
vp8_filter_block2d_second_pass_only_armv6(src_ptr, dst_ptr, src_pixels_per_line, 4, dst_pitch, VFilter); vp8_filter_block2d_second_pass_only_armv6(src_ptr, dst_ptr, src_pixels_per_line, 4, dst_pitch, VFilter);
} }
else else
{ {
// Vfilter is a 4 tap filter /* Vfilter is a 4 tap filter */
if (yoffset & 0x1) if (yoffset & 0x1)
{ {
vp8_filter_block2d_first_pass_armv6(src_ptr - src_pixels_per_line, FData + 1, src_pixels_per_line, 4, 7, HFilter); vp8_filter_block2d_first_pass_armv6(src_ptr - src_pixels_per_line, FData + 1, src_pixels_per_line, 4, 7, HFilter);
vp8_filter4_block2d_second_pass_armv6(FData + 2, dst_ptr, dst_pitch, 4, VFilter); vp8_filter4_block2d_second_pass_armv6(FData + 2, dst_ptr, dst_pitch, 4, VFilter);
} }
// Vfilter is 6 tap filter /* Vfilter is 6 tap filter */
else else
{ {
vp8_filter_block2d_first_pass_armv6(src_ptr - (2 * src_pixels_per_line), FData, src_pixels_per_line, 4, 9, HFilter); vp8_filter_block2d_first_pass_armv6(src_ptr - (2 * src_pixels_per_line), FData, src_pixels_per_line, 4, 9, HFilter);
...@@ -129,7 +129,7 @@ void vp8_sixtap_predict_armv6 ...@@ -129,7 +129,7 @@ void vp8_sixtap_predict_armv6
} }
} }
/* #if 0
void vp8_sixtap_predict8x4_armv6 void vp8_sixtap_predict8x4_armv6
( (
unsigned char *src_ptr, unsigned char *src_ptr,
...@@ -142,33 +142,33 @@ void vp8_sixtap_predict8x4_armv6 ...@@ -142,33 +142,33 @@ void vp8_sixtap_predict8x4_armv6
{ {
const short *HFilter; const short *HFilter;
const short *VFilter; const short *VFilter;
DECLARE_ALIGNED_ARRAY(4, short, FData, 16*8); // Temp data bufffer used in filtering DECLARE_ALIGNED_ARRAY(4, short, FData, 16*8); /* Temp data bufffer used in filtering */
HFilter = sub_pel_filters[xoffset]; // 6 tap HFilter = sub_pel_filters[xoffset]; /* 6 tap */
VFilter = sub_pel_filters[yoffset]; // 6 tap VFilter = sub_pel_filters[yoffset]; /* 6 tap */
// if (xoffset && !yoffset) /*if (xoffset && !yoffset)
// { {
// vp8_filter_block2d_first_pass_only_armv6 ( src_ptr, dst_ptr, src_pixels_per_line, 8, dst_pitch, HFilter ); vp8_filter_block2d_first_pass_only_armv6 ( src_ptr, dst_ptr, src_pixels_per_line, 8, dst_pitch, HFilter );
// } }*/
// Hfilter is null. Second pass only /* Hfilter is null. Second pass only */
// else if (!xoffset && yoffset) /*else if (!xoffset && yoffset)
// { {
// vp8_filter_block2d_second_pass_only_armv6 ( src_ptr, dst_ptr, src_pixels_per_line, 8, dst_pitch, VFilter ); vp8_filter_block2d_second_pass_only_armv6 ( src_ptr, dst_ptr, src_pixels_per_line, 8, dst_pitch, VFilter );
// } }
// else else
// { {
// if (yoffset & 0x1) if (yoffset & 0x1)
// vp8_filter_block2d_first_pass_armv6 ( src_ptr-src_pixels_per_line, FData+1, src_pixels_per_line, 8, 7, HFilter ); vp8_filter_block2d_first_pass_armv6 ( src_ptr-src_pixels_per_line, FData+1, src_pixels_per_line, 8, 7, HFilter );
// else else*/
vp8_filter_block2d_first_pass_armv6 ( src_ptr-(2*src_pixels_per_line), FData, src_pixels_per_line, 8, 9, HFilter ); vp8_filter_block2d_first_pass_armv6 ( src_ptr-(2*src_pixels_per_line), FData, src_pixels_per_line, 8, 9, HFilter );
vp8_filter_block2d_second_pass_armv6 ( FData+2, dst_ptr, dst_pitch, 4, 8, VFilter ); vp8_filter_block2d_second_pass_armv6 ( FData+2, dst_ptr, dst_pitch, 4, 8, VFilter );
// } /*}*/
} }
*/ #endif
void vp8_sixtap_predict8x8_armv6 void vp8_sixtap_predict8x8_armv6
( (
...@@ -182,16 +182,16 @@ void vp8_sixtap_predict8x8_armv6 ...@@ -182,16 +182,16 @@ void vp8_sixtap_predict8x8_armv6
{ {
const short *HFilter; const short *HFilter;
const short *VFilter; const short *VFilter;
DECLARE_ALIGNED_ARRAY(4, short, FData, 16*8); // Temp data bufffer used in filtering DECLARE_ALIGNED_ARRAY(4, short, FData, 16*8); /* Temp data bufffer used in filtering */
HFilter = sub_pel_filters[xoffset]; // 6 tap HFilter = sub_pel_filters[xoffset]; /* 6 tap */
VFilter = sub_pel_filters[yoffset]; // 6 tap VFilter = sub_pel_filters[yoffset]; /* 6 tap */
if (xoffset && !yoffset) if (xoffset && !yoffset)
{ {
vp8_filter_block2d_first_pass_only_armv6(src_ptr, dst_ptr, src_pixels_per_line, 8, dst_pitch, HFilter); vp8_filter_block2d_first_pass_only_armv6(src_ptr, dst_ptr, src_pixels_per_line, 8, dst_pitch, HFilter);
} }
// Hfilter is null. Second pass only /* Hfilter is null. Second pass only */
else if (!xoffset && yoffset) else if (!xoffset && yoffset)
{ {
vp8_filter_block2d_second_pass_only_armv6(src_ptr, dst_ptr, src_pixels_per_line, 8, dst_pitch, VFilter); vp8_filter_block2d_second_pass_only_armv6(src_ptr, dst_ptr, src_pixels_per_line, 8, dst_pitch, VFilter);
...@@ -224,16 +224,16 @@ void vp8_sixtap_predict16x16_armv6 ...@@ -224,16 +224,16 @@ void vp8_sixtap_predict16x16_armv6
{ {
const short *HFilter; const short *HFilter;
const short *VFilter; const short *VFilter;
DECLARE_ALIGNED_ARRAY(4, short, FData, 24*16); // Temp data bufffer used in filtering DECLARE_ALIGNED_ARRAY(4, short, FData, 24*16); /* Temp data bufffer used in filtering */
HFilter = sub_pel_filters[xoffset]; // 6 tap HFilter = sub_pel_filters[xoffset]; /* 6 tap */
VFilter = sub_pel_filters[yoffset]; // 6 tap VFilter = sub_pel_filters[yoffset]; /* 6 tap */
if (xoffset && !yoffset) if (xoffset && !yoffset)
{ {
vp8_filter_block2d_first_pass_only_armv6(src_ptr, dst_ptr, src_pixels_per_line, 16, dst_pitch, HFilter); vp8_filter_block2d_first_pass_only_armv6(src_ptr, dst_ptr, src_pixels_per_line, 16, dst_pitch, HFilter);
} }
// Hfilter is null. Second pass only /* Hfilter is null. Second pass only */
else if (!xoffset && yoffset) else if (!xoffset && yoffset)
{ {
vp8_filter_block2d_second_pass_only_armv6(src_ptr, dst_ptr, src_pixels_per_line, 16, dst_pitch, VFilter); vp8_filter_block2d_second_pass_only_armv6(src_ptr, dst_ptr, src_pixels_per_line, 16, dst_pitch, VFilter);
......
...@@ -35,8 +35,8 @@ extern loop_filter_uvfunction vp8_mbloop_filter_vertical_edge_uv_neon; ...@@ -35,8 +35,8 @@ extern loop_filter_uvfunction vp8_mbloop_filter_vertical_edge_uv_neon;
#if HAVE_ARMV6 #if HAVE_ARMV6
//ARMV6 loopfilter functions /*ARMV6 loopfilter functions*/
// Horizontal MB filtering /* Horizontal MB filtering */
void vp8_loop_filter_mbh_armv6(unsigned char *y_ptr, unsigned char *u_ptr, unsigned char *v_ptr, void vp8_loop_filter_mbh_armv6(unsigned char *y_ptr, unsigned char *u_ptr, unsigned char *v_ptr,
int y_stride, int uv_stride, loop_filter_info *lfi, int simpler_lpf) int y_stride, int uv_stride, loop_filter_info *lfi, int simpler_lpf)
{ {
...@@ -60,7 +60,7 @@ void vp8_loop_filter_mbhs_armv6(unsigned char *y_ptr, unsigned char *u_ptr, unsi ...@@ -60,7 +60,7 @@ void vp8_loop_filter_mbhs_armv6(unsigned char *y_ptr, unsigned char *u_ptr, unsi
vp8_loop_filter_simple_horizontal_edge_armv6(y_ptr, y_stride, lfi->mbflim, lfi->lim, lfi->mbthr, 2); vp8_loop_filter_simple_horizontal_edge_armv6(y_ptr, y_stride, lfi->mbflim, lfi->lim, lfi->mbthr, 2);
} }
// Vertical MB Filtering /* Vertical MB Filtering */
void vp8_loop_filter_mbv_armv6(unsigned char *y_ptr, unsigned char *u_ptr, unsigned char *v_ptr, void vp8_loop_filter_mbv_armv6(unsigned char *y_ptr, unsigned char *u_ptr, unsigned char *v_ptr,
int y_stride, int uv_stride, loop_filter_info *lfi, int simpler_lpf) int y_stride, int uv_stride, loop_filter_info *lfi, int simpler_lpf)
{ {
...@@ -84,7 +84,7 @@ void vp8_loop_filter_mbvs_armv6(unsigned char *y_ptr, unsigned char *u_ptr, unsi ...@@ -84,7 +84,7 @@ void vp8_loop_filter_mbvs_armv6(unsigned char *y_ptr, unsigned char *u_ptr, unsi
vp8_loop_filter_simple_vertical_edge_armv6(y_ptr, y_stride, lfi->mbflim, lfi->lim, lfi->mbthr, 2); vp8_loop_filter_simple_vertical_edge_armv6(y_ptr, y_stride, lfi->mbflim, lfi->lim, lfi->mbthr, 2);
} }
// Horizontal B Filtering /* Horizontal B Filtering */
void vp8_loop_filter_bh_armv6(unsigned char *y_ptr, unsigned char *u_ptr, unsigned char *v_ptr, void vp8_loop_filter_bh_armv6(unsigned char *y_ptr, unsigned char *u_ptr, unsigned char *v_ptr,
int y_stride, int uv_stride, loop_filter_info *lfi, int simpler_lpf) int y_stride, int uv_stride, loop_filter_info *lfi, int simpler_lpf)
{ {
...@@ -112,7 +112,7 @@ void vp8_loop_filter_bhs_armv6(unsigned char *y_ptr, unsigned char *u_ptr, unsig ...@@ -112,7 +112,7 @@ void vp8_loop_filter_bhs_armv6(unsigned char *y_ptr, unsigned char *u_ptr, unsig
vp8_loop_filter_simple_horizontal_edge_armv6(y_ptr + 12 * y_stride, y_stride, lfi->flim, lfi->lim, lfi->thr, 2); vp8_loop_filter_simple_horizontal_edge_armv6(y_ptr + 12 * y_stride, y_stride, lfi->flim, lfi->lim, lfi->thr, 2);
} }
// Vertical B Filtering /* Vertical B Filtering */
void vp8_loop_filter_bv_armv6(unsigned char *y_ptr, unsigned char *u_ptr, unsigned char *v_ptr, void vp8_loop_filter_bv_armv6(unsigned char *y_ptr, unsigned char *u_ptr, unsigned char *v_ptr,
int y_stride, int uv_stride, loop_filter_info *lfi, int simpler_lpf) int y_stride, int uv_stride, loop_filter_info *lfi, int simpler_lpf)
{ {
...@@ -142,8 +142,8 @@ void vp8_loop_filter_bvs_armv6(unsigned char *y_ptr, unsigned char *u_ptr, unsig ...@@ -142,8 +142,8 @@ void vp8_loop_filter_bvs_armv6(unsigned char *y_ptr, unsigned char *u_ptr, unsig
#endif #endif
#if HAVE_ARMV7 #if HAVE_ARMV7
// NEON loopfilter functions /* NEON loopfilter functions */
// Horizontal MB filtering /* Horizontal MB filtering */
void vp8_loop_filter_mbh_neon(unsigned char *y_ptr, unsigned char *u_ptr, unsigned char *v_ptr, void vp8_loop_filter_mbh_neon(unsigned char *y_ptr, unsigned char *u_ptr, unsigned char *v_ptr,
int y_stride, int uv_stride, loop_filter_info *lfi, int simpler_lpf) int y_stride, int uv_stride, loop_filter_info *lfi, int simpler_lpf)
{ {
...@@ -164,7 +164,7 @@ void vp8_loop_filter_mbhs_neon(unsigned char *y_ptr, unsigned char *u_ptr, unsig ...@@ -164,7 +164,7 @@ void vp8_loop_filter_mbhs_neon(unsigned char *y_ptr, unsigned char *u_ptr, unsig
vp8_loop_filter_simple_horizontal_edge_neon(y_ptr, y_stride, lfi->mbflim, lfi->lim, lfi->mbthr, 2); vp8_loop_filter_simple_horizontal_edge_neon(y_ptr, y_stride, lfi->mbflim, lfi->lim, lfi->mbthr, 2);
} }
// Vertical MB Filtering /* Vertical MB Filtering */
void vp8_loop_filter_mbv_neon(unsigned char *y_ptr, unsigned char *u_ptr, unsigned char *v_ptr, void vp8_loop_filter_mbv_neon(unsigned char *y_ptr, unsigned char *u_ptr, unsigned char *v_ptr,
int y_stride, int uv_stride, loop_filter_info *lfi, int simpler_lpf) int y_stride, int uv_stride, loop_filter_info *lfi, int simpler_lpf)
{ {
...@@ -185,7 +185,7 @@ void vp8_loop_filter_mbvs_neon(unsigned char *y_ptr, unsigned char *u_ptr, unsig ...@@ -185,7 +185,7 @@ void vp8_loop_filter_mbvs_neon(unsigned char *y_ptr, unsigned char *u_ptr, unsig
vp8_loop_filter_simple_vertical_edge_neon(y_ptr, y_stride, lfi->mbflim, lfi->lim, lfi->mbthr, 2); vp8_loop_filter_simple_vertical_edge_neon(y_ptr, y_stride, lfi->mbflim, lfi->lim, lfi->mbthr, 2);
} }
// Horizontal B Filtering /* Horizontal B Filtering */
void vp8_loop_filter_bh_neon(unsigned char *y_ptr, unsigned char *u_ptr, unsigned char *v_ptr, void vp8_loop_filter_bh_neon(unsigned char *y_ptr, unsigned char *u_ptr, unsigned char *v_ptr,
int y_stride, int uv_stride, loop_filter_info *lfi, int simpler_lpf) int y_stride, int uv_stride, loop_filter_info *lfi, int simpler_lpf)
{ {
...@@ -210,7 +210,7 @@ void vp8_loop_filter_bhs_neon(unsigned char *y_ptr, unsigned char *u_ptr, unsign ...@@ -210,7 +210,7 @@ void vp8_loop_filter_bhs_neon(unsigned char *y_ptr, unsigned char *u_ptr, unsign
vp8_loop_filter_simple_horizontal_edge_neon(y_ptr + 12 * y_stride, y_stride, lfi->flim, lfi->lim, lfi->thr, 2); vp8_loop_filter_simple_horizontal_edge_neon(y_ptr + 12 * y_stride, y_stride, lfi->flim, lfi->lim, lfi->thr, 2);
} }
// Vertical B Filtering /* Vertical B Filtering */
void vp8_loop_filter_bv_neon(unsigned char *y_ptr, unsigned char *u_ptr, unsigned char *v_ptr, void vp8_loop_filter_bv_neon(unsigned char *y_ptr, unsigned char *u_ptr, unsigned char *v_ptr,
int y_stride, int uv_stride, loop_filter_info *lfi, int simpler_lpf) int y_stride, int uv_stride, loop_filter_info *lfi, int simpler_lpf)
{ {
......
...@@ -23,7 +23,7 @@ void vp8_recon_mb_neon(const vp8_recon_rtcd_vtable_t *rtcd, MACROBLOCKD *x) ...@@ -23,7 +23,7 @@ void vp8_recon_mb_neon(const vp8_recon_rtcd_vtable_t *rtcd, MACROBLOCKD *x)
unsigned char *udst_ptr = x->dst.u_buffer; unsigned char *udst_ptr = x->dst.u_buffer;
unsigned char *vdst_ptr = x->dst.v_buffer; unsigned char *vdst_ptr = x->dst.v_buffer;
int ystride = x->dst.y_stride; int ystride = x->dst.y_stride;
//int uv_stride = x->dst.uv_stride; /*int uv_stride = x->dst.uv_stride;*/
vp8_recon16x16mb_neon(pred_ptr, diff_ptr, dst_ptr, ystride, udst_ptr, vdst_ptr); vp8_recon16x16mb_neon(pred_ptr, diff_ptr, dst_ptr, ystride, udst_ptr, vdst_ptr);
} }
...@@ -24,7 +24,7 @@ void vpx_log(const char *format, ...); ...@@ -24,7 +24,7 @@ void vpx_log(const char *format, ...);
#define TRUE 1 #define TRUE 1
#define FALSE 0 #define FALSE 0
//#define DCPRED 1 /*#define DCPRED 1*/
#define DCPREDSIMTHRESH 0 #define DCPREDSIMTHRESH 0
#define DCPREDCNTTHRESH 3 #define DCPREDCNTTHRESH 3
...@@ -39,7 +39,7 @@ void vpx_log(const char *format, ...); ...@@ -39,7 +39,7 @@ void vpx_log(const char *format, ...);
#define MAX_REF_LF_DELTAS 4 #define MAX_REF_LF_DELTAS 4
#define MAX_MODE_LF_DELTAS 4 #define MAX_MODE_LF_DELTAS 4
// Segment Feature Masks /* Segment Feature Masks */
#define SEGMENT_DELTADATA 0 #define SEGMENT_DELTADATA 0
#define SEGMENT_ABSDATA 1 #define SEGMENT_ABSDATA 1
...@@ -75,11 +75,11 @@ typedef enum ...@@ -75,11 +75,11 @@ typedef enum
typedef enum typedef enum
{ {
DC_PRED, // average of above and left pixels DC_PRED, /* average of above and left pixels */
V_PRED, // vertical prediction V_PRED, /* vertical prediction */
H_PRED, // horizontal prediction H_PRED, /* horizontal prediction */
TM_PRED, // Truemotion prediction TM_PRED, /* Truemotion prediction */
B_PRED, // block based prediction, each block has its own prediction mode B_PRED, /* block based prediction, each block has its own prediction mode */
NEARESTMV, NEARESTMV,
NEARMV, NEARMV,
...@@ -90,16 +90,16 @@ typedef enum ...@@ -90,16 +90,16 @@ typedef enum
MB_MODE_COUNT MB_MODE_COUNT
} MB_PREDICTION_MODE; } MB_PREDICTION_MODE;
// Macroblock level features /* Macroblock level features */
typedef enum typedef enum
{ {
MB_LVL_ALT_Q = 0, // Use alternate Quantizer .... MB_LVL_ALT_Q = 0, /* Use alternate Quantizer .... */
MB_LVL_ALT_LF = 1, // Use alternate loop filter value... MB_LVL_ALT_LF = 1, /* Use alternate loop filter value... */
MB_LVL_MAX = 2, // Number of MB level features supported MB_LVL_MAX = 2 /* Number of MB level features supported */
} MB_LVL_FEATURES; } MB_LVL_FEATURES;
// Segment Feature Masks /* Segment Feature Masks */
#define SEGMENT_ALTQ 0x01 #define SEGMENT_ALTQ 0x01
#define SEGMENT_ALT_LF 0x02 #define SEGMENT_ALT_LF 0x02
...@@ -110,11 +110,11 @@ typedef enum ...@@ -110,11 +110,11 @@ typedef enum
typedef enum typedef enum
{ {
B_DC_PRED, // average of above and left pixels B_DC_PRED, /* average of above and left pixels */
B_TM_PRED, B_TM_PRED,
B_VE_PRED, // vertical prediction B_VE_PRED, /* vertical prediction */
B_HE_PRED, // horizontal prediction B_HE_PRED, /* horizontal prediction */
B_LD_PRED, B_LD_PRED,
B_RD_PRED, B_RD_PRED,
...@@ -170,13 +170,13 @@ typedef struct ...@@ -170,13 +170,13 @@ typedef struct
} mv; } mv;
unsigned char partitioning; unsigned char partitioning;
unsigned char mb_skip_coeff; //does this mb has coefficients at all, 1=no coefficients, 0=need decode tokens unsigned char mb_skip_coeff; /* does this mb has coefficients at all, 1=no coefficients, 0=need decode tokens */
unsigned char dc_diff; unsigned char dc_diff;
unsigned char need_to_clamp_mvs; unsigned char need_to_clamp_mvs;
unsigned char segment_id; // Which set of segmentation parameters should be used for this MB unsigned char segment_id; /* Which set of segmentation parameters should be used for this MB */
unsigned char force_no_skip; //encoder only unsigned char force_no_skip; /* encoder only */
} MB_MODE_INFO; } MB_MODE_INFO;
...@@ -197,7 +197,7 @@ typedef struct ...@@ -197,7 +197,7 @@ typedef struct
short *dequant; short *dequant;
// 16 Y blocks, 4 U blocks, 4 V blocks each with 16 entries /* 16 Y blocks, 4 U blocks, 4 V blocks each with 16 entries */
unsigned char **base_pre; unsigned char **base_pre;
int pre; int pre;
int pre_stride; int pre_stride;
...@@ -214,17 +214,17 @@ typedef struct ...@@ -214,17 +214,17 @@ typedef struct