From e8bdca74b513b58d3db892d838b3a499365ca7e2 Mon Sep 17 00:00:00 2001
From: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
Date: Thu, 12 May 2016 21:15:58 +0200
Subject: [PATCH] optimize ProString::toInt()/toShort()
QStringRef has respective overloads now.
Change-Id: I9b94c53092ef3fdd62a68f5d3c5bacb98a14d8ec
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
---
qmake/library/proitems.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qmake/library/proitems.h b/qmake/library/proitems.h
index 721abb90d03..d22fa0f11e3 100644
--- a/qmake/library/proitems.h
+++ b/qmake/library/proitems.h
@@ -130,8 +130,8 @@ public:
bool contains(const QString &s, Qt::CaseSensitivity cs = Qt::CaseSensitive) const { return indexOf(s, 0, cs) >= 0; }
bool contains(const char *s, Qt::CaseSensitivity cs = Qt::CaseSensitive) const { return indexOf(QLatin1String(s), 0, cs) >= 0; }
bool contains(QChar c, Qt::CaseSensitivity cs = Qt::CaseSensitive) const { return indexOf(c, 0, cs) >= 0; }
- int toInt(bool *ok = 0, int base = 10) const { return toQString().toInt(ok, base); } // XXX optimize
- short toShort(bool *ok = 0, int base = 10) const { return toQString().toShort(ok, base); } // XXX optimize
+ int toInt(bool *ok = 0, int base = 10) const { return toQStringRef().toInt(ok, base); }
+ short toShort(bool *ok = 0, int base = 10) const { return toQStringRef().toShort(ok, base); }
uint hash() const { return m_hash; }
static uint hash(const QChar *p, int n);
--
GitLab