From dadf66728911c9e6a1b8251e5b7f00fa2c77e43c Mon Sep 17 00:00:00 2001
From: Alex Blasche <alexander.blasche@digia.com>
Date: Mon, 11 Aug 2014 10:32:38 +0200
Subject: [PATCH] Avoid potential double deletion when handling OSM route
replies
Change-Id: I15ab944e7b9e7cecc8ff9122183c438fd006e65b
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
---
src/plugins/geoservices/osm/qgeoroutereplyosm.cpp | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/plugins/geoservices/osm/qgeoroutereplyosm.cpp b/src/plugins/geoservices/osm/qgeoroutereplyosm.cpp
index c15bb48fd..deac5b9e2 100644
--- a/src/plugins/geoservices/osm/qgeoroutereplyosm.cpp
+++ b/src/plugins/geoservices/osm/qgeoroutereplyosm.cpp
@@ -339,6 +339,7 @@ void QGeoRouteReplyOsm::networkReplyFinished()
if (m_reply->error() != QNetworkReply::NoError) {
setError(QGeoRouteReply::CommunicationError, m_reply->errorString());
m_reply->deleteLater();
+ m_reply = 0;
return;
}
@@ -357,6 +358,7 @@ void QGeoRouteReplyOsm::networkReplyFinished()
if (0 != status) {
setError(QGeoRouteReply::UnknownError, statusMessage);
m_reply->deleteLater();
+ m_reply = 0;
return;
}
@@ -397,6 +399,7 @@ void QGeoRouteReplyOsm::networkReplyFinished()
}
m_reply->deleteLater();
+ m_reply = 0;
}
void QGeoRouteReplyOsm::networkReplyError(QNetworkReply::NetworkError error)
--
GitLab