From 448c992972d4078af1eee7ad9ccc8d86c0f2e78d Mon Sep 17 00:00:00 2001
From: Pierre Hallot <pierre.hallot@sensefly.com>
Date: Thu, 8 Mar 2018 14:34:22 +0100
Subject: [PATCH] Fix warning on deleteLater on nullptr in QSampleCache
It is possible to have a loading thread running, but with no network
manager.
In that case, calling deleteLater() on m_networkAccessManager results in
a warning: postEvent: Unexpected null receiver.
Fix this issue by checking whether the network manager exists before
calling deleteLater() on it.
Task-number: QTBUG-66910
Change-Id: I818a87a605b4e906dee47c6c815a6b8112b16829
Reviewed-by: VaL Doroshchuk <valentyn.doroshchuk@qt.io>
---
src/multimedia/audio/qsamplecache_p.cpp | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/multimedia/audio/qsamplecache_p.cpp b/src/multimedia/audio/qsamplecache_p.cpp
index 43f948cef..c956d764b 100644
--- a/src/multimedia/audio/qsamplecache_p.cpp
+++ b/src/multimedia/audio/qsamplecache_p.cpp
@@ -141,8 +141,10 @@ void QSampleCache::loadingRelease()
m_loadingRefCount--;
if (m_loadingRefCount == 0) {
if (m_loadingThread.isRunning()) {
- m_networkAccessManager->deleteLater();
- m_networkAccessManager = nullptr;
+ if (m_networkAccessManager) {
+ m_networkAccessManager->deleteLater();
+ m_networkAccessManager = nullptr;
+ }
m_loadingThread.exit();
}
}
--
GitLab