From 59f2bf186400241c62a02044265d9ecab81c1749 Mon Sep 17 00:00:00 2001
From: Thiago Macieira <thiago.macieira@intel.com>
Date: Sun, 23 Nov 2014 07:23:50 -0800
Subject: [PATCH] Remove unused private members
One is not used, the others are not even initialized, so don't use the
memory.
qsoundeffect_pulse_p.h:172:20: warning: private field 'm_resourceStatus' is not used [-Wunused-private-field]
qvideowidget_p.h:211:25: warning: private field 'm_aspectRatioMode' is not used [-Wunused-private-field]
qalsaaudioinput.h:156:22: warning: private field 'timestamp' is not used [-Wunused-private-field]
qalsaaudiooutput.h:135:22: warning: private field 'timestamp' is not used [-Wunused-private-field]
Change-Id: I7c9f50d57c4d29ee0dfd7dc086771d721cdb5b05
Reviewed-by: Yoann Lopes <yoann.lopes@theqtcompany.com>
---
src/multimedia/audio/qsoundeffect_pulse_p.h | 7 -------
src/multimediawidgets/qvideowidget.cpp | 1 -
src/multimediawidgets/qvideowidget_p.h | 1 -
src/plugins/alsa/qalsaaudioinput.h | 1 -
src/plugins/alsa/qalsaaudiooutput.h | 1 -
5 files changed, 11 deletions(-)
diff --git a/src/multimedia/audio/qsoundeffect_pulse_p.h b/src/multimedia/audio/qsoundeffect_pulse_p.h
index 9275d97ea..9846caee7 100644
--- a/src/multimedia/audio/qsoundeffect_pulse_p.h
+++ b/src/multimedia/audio/qsoundeffect_pulse_p.h
@@ -163,13 +163,6 @@ private:
int m_position;
QSoundEffectRef *m_ref;
- enum ResourceStatus {
- NoResources,
- WaitingResources,
- GrantedResources,
- DeniedResources
- };
- ResourceStatus m_resourceStatus;
bool m_resourcesAvailable;
QMediaPlayerResourceSetInterface *m_resources;
diff --git a/src/multimediawidgets/qvideowidget.cpp b/src/multimediawidgets/qvideowidget.cpp
index 8634907c6..439e77d08 100644
--- a/src/multimediawidgets/qvideowidget.cpp
+++ b/src/multimediawidgets/qvideowidget.cpp
@@ -306,7 +306,6 @@ QWindowVideoWidgetBackend::QWindowVideoWidgetBackend(
: m_service(service)
, m_windowControl(control)
, m_widget(widget)
- , m_aspectRatioMode(Qt::KeepAspectRatio)
{
connect(control, SIGNAL(brightnessChanged(int)), m_widget, SLOT(_q_brightnessChanged(int)));
connect(control, SIGNAL(contrastChanged(int)), m_widget, SLOT(_q_contrastChanged(int)));
diff --git a/src/multimediawidgets/qvideowidget_p.h b/src/multimediawidgets/qvideowidget_p.h
index 578fb92af..f447d1f2e 100644
--- a/src/multimediawidgets/qvideowidget_p.h
+++ b/src/multimediawidgets/qvideowidget_p.h
@@ -208,7 +208,6 @@ private:
QMediaService *m_service;
QVideoWindowControl *m_windowControl;
QWidget *m_widget;
- Qt::AspectRatioMode m_aspectRatioMode;
QSize m_pixelAspectRatio;
};
diff --git a/src/plugins/alsa/qalsaaudioinput.h b/src/plugins/alsa/qalsaaudioinput.h
index 5470c1b6d..abf67e2cd 100644
--- a/src/plugins/alsa/qalsaaudioinput.h
+++ b/src/plugins/alsa/qalsaaudioinput.h
@@ -153,7 +153,6 @@ private:
snd_pcm_uframes_t period_frames;
snd_pcm_access_t access;
snd_pcm_format_t pcmformat;
- snd_timestamp_t* timestamp;
snd_pcm_hw_params_t *hwparams;
qreal m_volume;
};
diff --git a/src/plugins/alsa/qalsaaudiooutput.h b/src/plugins/alsa/qalsaaudiooutput.h
index 5b9b45d38..2a245f38f 100644
--- a/src/plugins/alsa/qalsaaudiooutput.h
+++ b/src/plugins/alsa/qalsaaudiooutput.h
@@ -132,7 +132,6 @@ private:
snd_pcm_t* handle;
snd_pcm_access_t access;
snd_pcm_format_t pcmformat;
- snd_timestamp_t* timestamp;
snd_pcm_hw_params_t *hwparams;
qreal m_volume;
};
--
GitLab