From 0f7e53142dbebd08b2d0fe90636648b0816d4d4e Mon Sep 17 00:00:00 2001 From: Caroline Chao <caroline.chao@digia.com> Date: Fri, 15 Feb 2013 15:14:23 +0100 Subject: [PATCH] TestBench: Small fix Check if the "on" signal ends with "Changed" to make sure we are dealing with a property. I.e. onClicked should be skipped. Also in that case it caused the substr to be empty and the call item[substr] to create an assert in V8. Change-Id: Ib04aa1773ef13a005e998659c7c903d3118bfc62 Reviewed-by: Jens Bache-Wiig <jens.bache-wiig@digia.com> --- tests/manual/testbench/main.qml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/manual/testbench/main.qml b/tests/manual/testbench/main.qml index 0ddb13877..216d31c74 100644 --- a/tests/manual/testbench/main.qml +++ b/tests/manual/testbench/main.qml @@ -123,7 +123,10 @@ ApplicationWindow { propertyModel.clear() for (var prop in item) { + if (!prop.indexOf("on")) { // look only for properties + if (prop.indexOf("Changed") !== (prop.length - 7)) + continue var substr = prop.slice(2, prop.length - 7) if (!substr.indexOf("__")) // filter private continue; -- GitLab