From 86874eaaf4a6bee0001491490ead790862e48fce Mon Sep 17 00:00:00 2001 From: J-P Nurmi <jpnurmi@digia.com> Date: Mon, 8 Apr 2013 12:00:28 +0200 Subject: [PATCH] Cleanup the superfluous \internal tags that are no longer needed Change-Id: I2eaaf7e82351e70a742eeadc32b8e1f8655a02c1 Reviewed-by: Caroline Chao <caroline.chao@digia.com> --- src/controls/ApplicationWindow.qml | 2 -- src/controls/CheckBox.qml | 4 ---- src/controls/ScrollView.qml | 1 - src/controls/Slider.qml | 1 - src/controls/SpinBox.qml | 6 ------ src/controls/SplitView.qml | 2 -- src/controls/StackView.qml | 2 -- src/controls/Tab.qml | 1 - src/controls/TabView.qml | 2 -- src/controls/TextField.qml | 2 -- 10 files changed, 23 deletions(-) diff --git a/src/controls/ApplicationWindow.qml b/src/controls/ApplicationWindow.qml index bfd67b2c0..5d501834a 100644 --- a/src/controls/ApplicationWindow.qml +++ b/src/controls/ApplicationWindow.qml @@ -117,10 +117,8 @@ Window { */ property Item statusBar - /*! \internal */ onToolBarChanged: { if (toolBar) { toolBar.parent = toolBarArea } } - /*! \internal */ onStatusBarChanged: { if (statusBar) { statusBar.parent = statusBarArea } } /*! \internal */ diff --git a/src/controls/CheckBox.qml b/src/controls/CheckBox.qml index 0f5098b58..7f03573e3 100644 --- a/src/controls/CheckBox.qml +++ b/src/controls/CheckBox.qml @@ -139,13 +139,11 @@ AbstractCheckable { __cycleStatesHandler: __cycleCheckBoxStates - /*! \internal */ onCheckedChanged: { if (!__ignoreChecked) checkedState = checked ? Qt.Checked : Qt.Unchecked; } - /*! \internal */ onCheckedStateChanged: { __ignoreChecked = true; if (checkedState === Qt.PartiallyChecked) { @@ -157,14 +155,12 @@ AbstractCheckable { __ignoreChecked = false; } - /*! \internal */ onPartiallyCheckedEnabledChanged: { if (exclusiveGroup && partiallyCheckedEnabled) { console.warn("Cannot have partially checked boxes in an ExclusiveGroup."); } } - /*! \internal */ onExclusiveGroupChanged: { if (exclusiveGroup && partiallyCheckedEnabled) { console.warn("Cannot have partially checked boxes in an ExclusiveGroup."); diff --git a/src/controls/ScrollView.qml b/src/controls/ScrollView.qml index 623d30278..19cdee965 100644 --- a/src/controls/ScrollView.qml +++ b/src/controls/ScrollView.qml @@ -140,7 +140,6 @@ FocusScope { activeFocusOnTab: true - /*! \internal */ onContentItemChanged: { if (contentItem.hasOwnProperty("contentY") && // Check if flickable diff --git a/src/controls/Slider.qml b/src/controls/Slider.qml index c606ff5e9..3ccf4a647 100644 --- a/src/controls/Slider.qml +++ b/src/controls/Slider.qml @@ -181,7 +181,6 @@ Control { return Math.round(v); } - /* \internal */ style: Qt.createComponent(Settings.THEME_PATH + "/SliderStyle.qml", slider) Keys.onRightPressed: value += (maximumValue - minimumValue)/10.0 diff --git a/src/controls/SpinBox.qml b/src/controls/SpinBox.qml index c6a6c8e46..2e7abf1c7 100644 --- a/src/controls/SpinBox.qml +++ b/src/controls/SpinBox.qml @@ -131,7 +131,6 @@ Control { */ property bool activeFocusOnPress: true - /*! \internal */ style: Qt.createComponent(Settings.THEME_PATH + "/SpinBoxStyle.qml", spinbox) /*! \internal */ @@ -191,19 +190,14 @@ Control { visible: false } - /*! \internal */ onDecimalsChanged: input.setValue(value) - /*! \internal */ onMaximumValueChanged: input.setValue(value) - /*! \internal */ onMinimumValueChanged: input.setValue(value) - /*! \internal */ Component.onCompleted: { __initialized = true; input.setValue(value) } - /*! \internal */ onValueChanged: if (__initialized) input.setValue(value) activeFocusOnTab: true diff --git a/src/controls/SplitView.qml b/src/controls/SplitView.qml index 1fc3ed081..36788c326 100644 --- a/src/controls/SplitView.qml +++ b/src/controls/SplitView.qml @@ -145,9 +145,7 @@ Item { clip: true Component.onCompleted: d.init() - /*! \internal */ onWidthChanged: d.updateLayout() - /*! \internal */ onHeightChanged: d.updateLayout() SystemPalette { id: pal } diff --git a/src/controls/StackView.qml b/src/controls/StackView.qml index 4a4be4e89..75d280565 100644 --- a/src/controls/StackView.qml +++ b/src/controls/StackView.qml @@ -726,13 +726,11 @@ Item { /*! \internal Stops the user from pushing items while preparing a transition */ property bool __guard: false - /*! \internal */ Component.onCompleted: { if (initialItem) push(initialItem) } - /*! \internal */ Component.onDestruction: { if (__currentTransition) __currentTransition.animation.complete() diff --git a/src/controls/Tab.qml b/src/controls/Tab.qml index 3c86cc3c4..dbcdc1370 100644 --- a/src/controls/Tab.qml +++ b/src/controls/Tab.qml @@ -62,7 +62,6 @@ Loader { activeFocusOnTab: false - /*! \internal */ onVisibleChanged: if (visible) active = true /*! \internal */ diff --git a/src/controls/TabView.qml b/src/controls/TabView.qml index fa60af232..88336eee2 100644 --- a/src/controls/TabView.qml +++ b/src/controls/TabView.qml @@ -131,7 +131,6 @@ FocusScope { /*! \internal */ property var __styleItem: loader.item - /*! \internal */ onCurrentIndexChanged: __setOpacities() /*! \internal */ @@ -188,7 +187,6 @@ FocusScope { property string style property int baseOverlap - /*! \internal */ Component.onCompleted: { for (var i = 0 ; i < stack.children.length ; ++i) { if (stack.children[i].Accessible.role === Accessible.PageTab) diff --git a/src/controls/TextField.qml b/src/controls/TextField.qml index e781d23db..b53dd8f97 100644 --- a/src/controls/TextField.qml +++ b/src/controls/TextField.qml @@ -530,10 +530,8 @@ Control { /*! \internal */ property alias __contentWidth: textInput.contentWidth - /*! \internal */ style: Qt.createComponent(Settings.THEME_PATH + "/TextFieldStyle.qml", textInput) - /*! \internal */ onFocusChanged: { if (textfield.activeFocus) textInput.forceActiveFocus(); -- GitLab