From bd38f7bb859c16796415765f0aca51c44e753a92 Mon Sep 17 00:00:00 2001
From: Oswald Buddenhagen <oswald.buddenhagen@digia.com>
Date: Fri, 17 Oct 2014 20:43:24 +0200
Subject: [PATCH] nuke pointless intermediate
the pipe can be read in one swoop.
Change-Id: I72f87996d26663d0203404e77d47e130046845b7
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
---
git-hooks/gerrit-bot | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/git-hooks/gerrit-bot b/git-hooks/gerrit-bot
index 4eb28c4..bdd64b1 100755
--- a/git-hooks/gerrit-bot
+++ b/git-hooks/gerrit-bot
@@ -137,13 +137,15 @@ sub process_commit($$$$$)
my $worker = $WORKER;
$worker =~ s/\@SHA1\@/$rev/g;
open VERDICT, $worker." 2>&1 |" or die "cannot run worker: ".$!;
- my @verdict = <VERDICT>;
+ {
+ local $/;
+ $verdict = <VERDICT>;
+ }
close VERDICT;
die "Worker for commit ".$ref." in ".$project." crashed with signal ".$?.".\n" if ($? & 127);
$score = $? >> 8;
die "Worker returned invalid score ".$score." for commit ".$ref." in ".$project.".\n" if ($score > 20);
$score -= 10;
- $verdict = "@verdict";
if (length($verdict) > 20000) {
$verdict = substr($verdict, 0, 20000)."\n\n**** Output truncated. Fix the problems above to get more output.\n";
}
--
GitLab