From e76b413d5b5eca67c9d708f5dbee94d77327d4b6 Mon Sep 17 00:00:00 2001
From: Oswald Buddenhagen <oswald.buddenhagen@digia.com>
Date: Tue, 18 Mar 2014 21:17:11 +0100
Subject: [PATCH] complain about urls pointing to gerrit reviews and jira tasks
urls to reviews should be replaced by sha1s of merged commits.
urls to jira tasks should be replaced by task-number footers.
the rationale is keeping the history relocatable, and somewhat
independent from the infrastructure's software.
also, urls are pretty noisy.
Change-Id: I4b2c9ded8cbc02ca96daa4a2ff92c98c0a4b05f9
Reviewed-by: Sergio Ahumada <sahumada@blackberry.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
---
git-hooks/sanitize-commit | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/git-hooks/sanitize-commit b/git-hooks/sanitize-commit
index c31d8f2..79d6c89 100755
--- a/git-hooks/sanitize-commit
+++ b/git-hooks/sanitize-commit
@@ -96,6 +96,7 @@ my $iswip = defined($cfg{wip});
my $badrev = 0;
my $badsign = 0;
my $badid = defined($cfg{changeid});
+my $badurl = defined($cfg{url});
my $badlog = defined($cfg{log});
my $spell_check = !defined($cfg{spell});
my $parents = 0;
@@ -218,6 +219,10 @@ while (<MSG>) {
$badid = 1;
&complain("Gerrit change id outside Change-Id footer", "changeid");
}
+ if (!$badurl && /\bhttps?:\/\/(bugreports\.qt-project\.org\/browse\/|codereview\.qt-project\.org\/(\#change,)?\d+)/) {
+ $badurl = 1;
+ &complain("URL pointing to Gerrit or JIRA", "url");
+ }
my $ftr = 0;
if (/^\(cherry[- ]picked /) {
$cherry = 1 if (!/\)/);
--
GitLab