From 751e87f0c20a2b45b8e5928902813b19867dd18b Mon Sep 17 00:00:00 2001
From: Paul Wicking <paul.wicking@qt.io>
Date: Wed, 9 Oct 2019 14:21:38 +0200
Subject: [PATCH] QDoc: Minor clean-up in main.cpp
- Reserve memory for container
- Use range-based for loop
Change-Id: Ia37e4ab1d14b4243ea40dca147acffdd86d021ca
Reviewed-by: Martin Smith <martin.smith@qt.io>
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
---
src/qdoc/main.cpp | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/qdoc/main.cpp b/src/qdoc/main.cpp
index c85ddb44d..e2ae550c1 100644
--- a/src/qdoc/main.cpp
+++ b/src/qdoc/main.cpp
@@ -169,8 +169,9 @@ static void loadIndexFiles(Config &config, const QSet<QString> &formats)
highest UNIX timestamp.
*/
QStringList indexPaths;
- for (int k = 0; k < foundIndices.size(); k++)
- indexPaths << foundIndices[k].absoluteFilePath();
+ indexPaths.reserve(foundIndices.size());
+ for (const auto &found : qAsConst(foundIndices))
+ indexPaths << found.absoluteFilePath();
Location::null.warning(QString("Multiple index files found for dependency \"%1\":\n%2").arg(
qdocGlobals.dependModules()[i], indexPaths.join('\n')));
Location::null.warning(QString("Using %1 as index file for dependency \"%2\"").arg(
--
GitLab