From c67621a600de02dfc46fe5e4e5b1da73fcc6a37e Mon Sep 17 00:00:00 2001 From: Friedemann Kleint <Friedemann.Kleint@qt.io> Date: Wed, 16 Oct 2019 11:10:21 +0200 Subject: [PATCH] qdoc: Fix warnings about un-annotated fallthrough and missing break Amends 3f3cf9dd93bfcb6c8989afa45f391633d007c8ce. Task-number: PYSIDE-1088 Change-Id: Iba37b69f84c6024d7bfd33f6020938b04e07240f Reviewed-by: Paul Wicking <paul.wicking@qt.io> --- src/qdoc/webxmlgenerator.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/qdoc/webxmlgenerator.cpp b/src/qdoc/webxmlgenerator.cpp index ba1ad8389..05e1c9b42 100644 --- a/src/qdoc/webxmlgenerator.cpp +++ b/src/qdoc/webxmlgenerator.cpp @@ -782,7 +782,7 @@ void WebXMLGenerator::startLink(QXmlStreamWriter &writer, const Atom *atom, break; } } - // fall through + Q_FALLTHROUGH(); case Node::Page: writer.writeAttribute("page", fullName); break; @@ -792,8 +792,9 @@ void WebXMLGenerator::startLink(QXmlStreamWriter &writer, const Atom *atom, if (propertyNode->getters().size() > 0) writer.writeAttribute("getter", propertyNode->getters().at(0)->fullName()); } + break; default: - ; + break; } } inLink = true; -- GitLab