From 94be60ce8b7141442a37f0d91f3deeb2bdc25f3d Mon Sep 17 00:00:00 2001 From: Jocelyn Turcotte <jocelyn.turcotte@digia.com> Date: Thu, 7 Aug 2014 19:17:23 +0200 Subject: [PATCH] <chromium> Disable warnings as errors on Mac and Windows Since we have little chance of introducing warnings in Chromium code and that we allow building the code on more various toolchains, avoid breaking the build for warnings. We already disable them on os_posix==1 and OS!="mac" by overriding the werror% gyp variable in qtwebengine_extras.gypi. Change-Id: Ic233bcd018a9a78a508772dea126435e2226b721 Reviewed-by: Andras Becsi <andras.becsi@digia.com> --- chromium/build/common.gypi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/chromium/build/common.gypi b/chromium/build/common.gypi index 75ce2b70929..4c76aace6cf 100644 --- a/chromium/build/common.gypi +++ b/chromium/build/common.gypi @@ -1230,7 +1230,7 @@ # flag allows us to have warnings as errors in general to prevent # regressions in most modules, while working on the bits that are # remaining. - 'win_third_party_warn_as_error%': 'true', + 'win_third_party_warn_as_error%': 'false', # Clang stuff. 'clang%': '<(clang)', @@ -4535,7 +4535,7 @@ 'GCC_OBJC_CALL_CXX_CDTORS': 'YES', # -fobjc-call-cxx-cdtors 'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden 'GCC_THREADSAFE_STATICS': 'NO', # -fno-threadsafe-statics - 'GCC_TREAT_WARNINGS_AS_ERRORS': 'YES', # -Werror + 'GCC_TREAT_WARNINGS_AS_ERRORS': 'NO', # -Werror 'GCC_VERSION': '4.2', 'GCC_WARN_ABOUT_MISSING_NEWLINE': 'YES', # -Wnewline-eof 'USE_HEADERMAP': 'NO', @@ -5156,7 +5156,7 @@ 'EnableFunctionLevelLinking': 'true', 'RuntimeTypeInfo': 'false', 'WarningLevel': '4', - 'WarnAsError': 'true', + 'WarnAsError': 'false', 'DebugInformationFormat': '3', 'conditions': [ ['component=="shared_library"', { -- GitLab