From 121e7452879db6a7c84b039cdb00a097ab4d6586 Mon Sep 17 00:00:00 2001
From: Peter Varga <pvarga@inf.u-szeged.hu>
Date: Mon, 1 Apr 2019 11:16:22 +0200
Subject: [PATCH] Skip downloadToReadOnlyDir auto test on Windows
It should be rather skipped than blacklisted since it is not expected to
work on Windows.
See the corresponding warning about ACLs:
https://doc.qt.io/qt-5/qfile.html#setPermissions
Task-number: QTBUG-74698
Change-Id: Iad66c028583d6811b7a413dd9800e9095d8f6da7
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
---
tests/auto/widgets/qwebenginedownloaditem/BLACKLIST | 2 --
.../qwebenginedownloaditem/tst_qwebenginedownloaditem.cpp | 3 +++
2 files changed, 3 insertions(+), 2 deletions(-)
delete mode 100644 tests/auto/widgets/qwebenginedownloaditem/BLACKLIST
diff --git a/tests/auto/widgets/qwebenginedownloaditem/BLACKLIST b/tests/auto/widgets/qwebenginedownloaditem/BLACKLIST
deleted file mode 100644
index a51117ae0..000000000
--- a/tests/auto/widgets/qwebenginedownloaditem/BLACKLIST
+++ /dev/null
@@ -1,2 +0,0 @@
-[downloadToReadOnlyDir]
-windows
diff --git a/tests/auto/widgets/qwebenginedownloaditem/tst_qwebenginedownloaditem.cpp b/tests/auto/widgets/qwebenginedownloaditem/tst_qwebenginedownloaditem.cpp
index c41315cd7..3a38c115d 100644
--- a/tests/auto/widgets/qwebenginedownloaditem/tst_qwebenginedownloaditem.cpp
+++ b/tests/auto/widgets/qwebenginedownloaditem/tst_qwebenginedownloaditem.cpp
@@ -1059,6 +1059,9 @@ void tst_QWebEngineDownloadItem::downloadToNonExistentDir()
void tst_QWebEngineDownloadItem::downloadToReadOnlyDir()
{
+#ifdef Q_OS_WIN
+ QSKIP("Cannot change file permissions on Windows.");
+#endif
QString baseName("test(1.test)");
QString extension("txt");
QString fileName = QString("%1.%2").arg(baseName).arg(extension);
--
GitLab