From 1ecf3ac50b4ceca4b2b398089912a40aa7450ef1 Mon Sep 17 00:00:00 2001
From: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
Date: Wed, 14 Sep 2016 12:35:24 +0200
Subject: [PATCH] Fix memory leak on print
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
We need to delete the QPrintDialog.
Change-Id: I959f963ba2e44091acb0c762ac680037bccc5b43
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
---
examples/webenginewidgets/demobrowser/browsermainwindow.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/webenginewidgets/demobrowser/browsermainwindow.cpp b/examples/webenginewidgets/demobrowser/browsermainwindow.cpp
index 09f9a746b..6f66e5048 100644
--- a/examples/webenginewidgets/demobrowser/browsermainwindow.cpp
+++ b/examples/webenginewidgets/demobrowser/browsermainwindow.cpp
@@ -769,7 +769,7 @@ void BrowserMainWindow::printRequested(QWebEnginePage *page)
if (m_currentPrinter)
return;
m_currentPrinter = new QPrinter();
- QPrintDialog *dialog = new QPrintDialog(m_currentPrinter, this);
+ QScopedPointer<QPrintDialog> dialog(new QPrintDialog(m_currentPrinter, this));
dialog->setWindowTitle(tr("Print Document"));
if (dialog->exec() != QDialog::Accepted) {
slotHandlePagePrinted(false);
--
GitLab