From 595b3a9a65b0a34348b6860d0ad1c62ea7367a4f Mon Sep 17 00:00:00 2001
From: Leena Miettinen <riitta-leena.miettinen@qt.io>
Date: Mon, 5 Mar 2018 10:43:26 +0100
Subject: [PATCH] Doc: Fix function signatures in docs
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The "request" parameter has been renamed for
QWebEnginePage::fullScreenRequested() and
QWebEnginePage::quotaPermissionRequested(), which
causes QDoc warnings and broken docs.
Change-Id: I58ada7c882e381a6ab008f5523ca7bcdfc3e8212
Reviewed-by: Szabolcs David <davidsz@inf.u-szeged.hu>
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
---
src/webenginewidgets/api/qwebenginepage.cpp | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/webenginewidgets/api/qwebenginepage.cpp b/src/webenginewidgets/api/qwebenginepage.cpp
index 6017fe078..0d5f83bba 100644
--- a/src/webenginewidgets/api/qwebenginepage.cpp
+++ b/src/webenginewidgets/api/qwebenginepage.cpp
@@ -735,12 +735,12 @@ QWebEnginePage::QWebEnginePage(QObject* parent)
*/
/*!
- \fn QWebEnginePage::fullScreenRequested(QWebEngineFullScreenRequest request)
+ \fn QWebEnginePage::fullScreenRequested(QWebEngineFullScreenRequest fullScreenRequest)
This signal is emitted when the web page issues the request to enter fullscreen mode for
a web-element, usually a video element.
- The request object \a request can be used to accept or reject the request.
+ The request object \a fullScreenRequest can be used to accept or reject the request.
If the request is accepted the element requesting fullscreen will fill the viewport,
but it is up to the application to make the view fullscreen or move the page to a view
@@ -750,14 +750,14 @@ QWebEnginePage::QWebEnginePage(QObject* parent)
*/
/*!
- \fn QWebEnginePage::quotaPermissionRequested(QWebEngineQuotaPermissionRequest request)
+ \fn QWebEnginePage::quotaPermissionRequested(QWebEngineQuotaPermissionRequest quotaPermissionRequest)
\since 5.11
This signal is emitted when the web page requests larger persistent storage
than the application's current allocation in File System API. The default quota
is 0 bytes.
- The request object \a request can be used to accept or reject the request.
+ The request object \a quotaPermissionRequest can be used to accept or reject the request.
*/
/*!
--
GitLab