From 7696dcdb51b30e1a95d8a9b604aeaf58be9f50cf Mon Sep 17 00:00:00 2001
From: Frederik Gladhorn <frederik.gladhorn@digia.com>
Date: Mon, 14 Jul 2014 15:39:02 +0200
Subject: [PATCH] Accessibility: Improve roles
Section, Paragraph and WebDocument have been added to qtbase in Qt 5.4.
Change-Id: I6b249caf3af123e3a2c68fb981278f49c86a32ee
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
---
src/core/browser_accessibility_qt.cpp | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/core/browser_accessibility_qt.cpp b/src/core/browser_accessibility_qt.cpp
index f71a50610..2c1ac5cab 100644
--- a/src/core/browser_accessibility_qt.cpp
+++ b/src/core/browser_accessibility_qt.cpp
@@ -169,7 +169,7 @@ QAccessible::Role BrowserAccessibilityQt::role() const
// for this page, and a web area for a frame within this page.
case WebAXRoleWebArea:
case WebAXRoleRootWebArea: // not sure if we need to make a diff here, but this seems common
- return QAccessible::Document;
+ return QAccessible::WebDocument;
// These roles all directly correspond to blink accessibility roles,
// keep these alphabetical.
@@ -214,7 +214,7 @@ QAccessible::Role BrowserAccessibilityQt::role() const
case WebAXRoleDisclosureTriangle:
return QAccessible::NoRole; // FIXME
case WebAXRoleDiv:
- return QAccessible::NoRole; // FIXME
+ return QAccessible::Section;
case WebAXRoleDocument:
return QAccessible::Document;
case WebAXRoleDrawer:
@@ -247,6 +247,8 @@ QAccessible::Role BrowserAccessibilityQt::role() const
return QAccessible::NoRole; // FIXME
case WebAXRoleIncrementor:
return QAccessible::NoRole; // FIXME
+ case WebAXRoleInlineTextBox:
+ return QAccessible::EditableText;
case WebAXRoleLabel:
return QAccessible::StaticText;
case WebAXRoleLink:
@@ -286,9 +288,9 @@ QAccessible::Role BrowserAccessibilityQt::role() const
case WebAXRoleOutline:
return QAccessible::NoRole; // FIXME
case WebAXRoleParagraph:
- return QAccessible::NoRole; // FIXME
+ return QAccessible::Paragraph;
case WebAXRolePopUpButton:
- return QAccessible::NoRole; // FIXME
+ return QAccessible::ComboBox;
case WebAXRolePresentational:
return QAccessible::NoRole; // FIXME
case WebAXRoleProgressIndicator:
--
GitLab