From 772ba138c069b77b31604d190dd99a07b06d1d9f Mon Sep 17 00:00:00 2001
From: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
Date: Thu, 11 Sep 2014 18:41:15 +0200
Subject: [PATCH] Enable JavascriptCanOpenWindows and LocalStorageEnabled by
 default

Both QWebEnginePage::createWindow and QQuickWebEngineNewViewRequest
behave as if JavascriptCanOpenWindows was disabled by default, when
the application isn't handling new window signals.

LocalStorageEnabled should have no negative impact to be enabled
beside the used disk space, but is still less inconvenient than
cookies or disk cache, which are also enabled by default.

Change-Id: I3f5343c2410fac50bec08b386defe22baf3df440
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
---
 src/core/web_engine_settings.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/core/web_engine_settings.cpp b/src/core/web_engine_settings.cpp
index 6af3210bf..363cd9c6a 100644
--- a/src/core/web_engine_settings.cpp
+++ b/src/core/web_engine_settings.cpp
@@ -203,10 +203,10 @@ void WebEngineSettings::initDefaults()
     // Initialize the default settings.
     m_attributes.insert(AutoLoadImages, true);
     m_attributes.insert(JavascriptEnabled, true);
-    m_attributes.insert(JavascriptCanOpenWindows, false);
+    m_attributes.insert(JavascriptCanOpenWindows, true);
     m_attributes.insert(JavascriptCanAccessClipboard, false);
     m_attributes.insert(LinksIncludedInFocusChain, true);
-    m_attributes.insert(LocalStorageEnabled, false);
+    m_attributes.insert(LocalStorageEnabled, true);
     m_attributes.insert(LocalContentCanAccessRemoteUrls, false);
     m_attributes.insert(XSSAuditingEnabled, false);
     m_attributes.insert(SpatialNavigationEnabled, false);
-- 
GitLab