From c6b37bbd5fdfc0df6b53d787a2c6a0f4262de26b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=BCri=20Valdmann?= <juri.valdmann@qt.io> Date: Mon, 29 Apr 2019 12:58:37 +0200 Subject: [PATCH] QWebEngineUrlScheme: Prevent registration of standard schemes Change-Id: I05ef67b81d9b871d38fcc51639b742b2a7b8a387 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> --- src/core/api/qwebengineurlscheme.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/core/api/qwebengineurlscheme.cpp b/src/core/api/qwebengineurlscheme.cpp index 9b04f46c5..9cc5b5056 100644 --- a/src/core/api/qwebengineurlscheme.cpp +++ b/src/core/api/qwebengineurlscheme.cpp @@ -378,6 +378,11 @@ void QWebEngineUrlScheme::registerScheme(const QWebEngineUrlScheme &scheme) return; } + if (url::IsStandard(scheme.d->name.data(), url::Component(0, scheme.d->name.size()))) { + qWarning() << "QWebEngineUrlScheme::registerScheme: Scheme" << scheme.name() << "is a standard scheme"; + return; + } + if (g_schemesLocked) { qWarning() << "QWebEngineUrlScheme::registerScheme: Too late to register scheme" << scheme.name(); return; -- GitLab