From 0f62c3b6d48928710e2ac5c73cd4b69b8f423a87 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C4=99drzej=20Nowacki?= <jedrzej.nowacki@digia.com>
Date: Wed, 15 Jan 2014 17:09:39 +0100
Subject: [PATCH] Minor optimization, use QStringRef over QString
That way we avoid some unnecessary memory allocations
Change-Id: I597443393671d57b1a47b37eb15c3eca54ee4168
Reviewed-by: Mitch Curtis <mitch.curtis@digia.com>
---
tools/xmlpatterns/qapplicationargumentparser.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/xmlpatterns/qapplicationargumentparser.cpp b/tools/xmlpatterns/qapplicationargumentparser.cpp
index 9bf407ba..031e088b 100644
--- a/tools/xmlpatterns/qapplicationargumentparser.cpp
+++ b/tools/xmlpatterns/qapplicationargumentparser.cpp
@@ -464,7 +464,7 @@ QString QApplicationArgumentParserPrivate::lineWrap(const QString &input,
return input;
int from = wrapFinder.toPreviousBoundary();
- output.append(input.left(from));
+ output.append(input.leftRef(from));
while(true)
{
@@ -476,7 +476,7 @@ QString QApplicationArgumentParserPrivate::lineWrap(const QString &input,
output.append(QLatin1Char('\n'));
output.append(indent);
- output.append(input.mid(from, currentWidthPos - from).trimmed());
+ output.append(input.midRef(from, currentWidthPos - from).trimmed().toString());
from += (currentWidthPos - from);
}
else
@@ -484,7 +484,7 @@ QString QApplicationArgumentParserPrivate::lineWrap(const QString &input,
/* Append the remains. */
output.append(QLatin1Char('\n'));
output.append(indent);
- output.append(input.mid(from).trimmed());
+ output.append(input.midRef(from).trimmed().toString());
break;
}
}
--
GitLab