From e925560b37e148b468c2dcc5d6f163eb539df3e9 Mon Sep 17 00:00:00 2001
From: Thiago Macieira <thiago.macieira@intel.com>
Date: Fri, 6 Sep 2013 11:02:45 -0700
Subject: [PATCH] Fix Clang warning of constant-false comparison
qstringvaluefns.cpp:224:23: error: comparison of constant -1 with expression of type 'QString::NormalizationForm' is always false [-Werror,-Wtautological-constant-out-of-range-compare]
Change-Id: Ia0dd98f72521709712f5ed11ecf19a48acaf1998
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
---
src/xmlpatterns/functions/qstringvaluefns.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/xmlpatterns/functions/qstringvaluefns.cpp b/src/xmlpatterns/functions/qstringvaluefns.cpp
index 766856c4..6c4bac51 100644
--- a/src/xmlpatterns/functions/qstringvaluefns.cpp
+++ b/src/xmlpatterns/functions/qstringvaluefns.cpp
@@ -221,7 +221,7 @@ Expression::Ptr NormalizeUnicodeFN::compress(const StaticContext::Ptr &context)
m_normForm = static_cast<QString::NormalizationForm>(
determineNormalizationForm(context->dynamicContext()));
- if(m_normForm == -1)
+ if (int(m_normForm) == -1)
return m_operands.first();
/* Remove the operand since we don't need it anymore. */
--
GitLab