Commit a734fcce authored by Pekka Pessi's avatar Pekka Pessi
Browse files

Added disclaimers about bitfields in public structs.

darcs-hash:20060926170153-65a35-08302d5c1a53a76c124dcf4253da12106b0be52d.gz
parent 53b7a318
......@@ -264,6 +264,7 @@ typedef int msg_update_f(msg_common_t *, char const *name, isize_t namelen,
*/
struct msg_hclass_s
{
/* XXX size of header class missing. Someone has saved bits in wrong place. */
int hc_hash; /**< Header name hash or ID */
msg_parse_f *hc_parse; /**< Parse header. */
msg_print_f *hc_print; /**< Print header. */
......@@ -274,7 +275,7 @@ struct msg_hclass_s
short hc_len; /**< Length of hc_name. */
char hc_short[2];/**< Short name, if any. */
unsigned char hc_size; /**< Size of header structure. */
unsigned char hc_params; /**< Offset of parameters */
unsigned char hc_params; /**< Offset of parameter list */
unsigned hc_kind:3; /**< Kind of header (#msg_header_kind_t):
* single, append, list, apndlist, prepend. */
unsigned hc_critical:1; /**< True if header is critical */
......
......@@ -143,6 +143,8 @@ struct soa_session
/** Incremented once each time session is terminated */
unsigned ss_terminated;
/* XXX - this is part of public API. we should have no bitfields here */
unsigned ss_active:1; /**< Session has been activated */
/* Current Offer-Answer status */
......@@ -212,6 +214,8 @@ struct soa_session
char const *ss_cname;
/* XXX - this is part of public API. we should have no bitfields here */
/* Codec handling during negotiation */
unsigned ss_rtp_select:2;
unsigned ss_rtp_sort:2;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment