Allow creation of ConferenceSecurityEvent without faultyDevice

src/chat/encryption/lime-v2.cpp

@@ -175,8 +175,7 @@ ChatMessageModifier::Result LimeV2::processOutgoingMessage (const shared_ptr<Cha
 		lWarning() << "Sending encrypted message to multidevice participant, message rejected";
 
 		ConferenceSecurityEvent::SecurityAlertType securityAlertType = ConferenceSecurityEvent::SecurityAlertType::MultideviceParticipant;
-		IdentityAddress noFaultyDevice;
-		shared_ptr<ConferenceSecurityEvent> securityEvent = make_shared<ConferenceSecurityEvent>(time(nullptr), chatRoom->getConferenceId(), securityAlertType, noFaultyDevice);
+		shared_ptr<ConferenceSecurityEvent> securityEvent = make_shared<ConferenceSecurityEvent>(time(nullptr), chatRoom->getConferenceId(), securityAlertType);
 		shared_ptr<ClientGroupChatRoom> confListener = static_pointer_cast<ClientGroupChatRoom>(chatRoom);
 		confListener->onSecurityAlert(securityEvent);
 

src/event-log/conference/conference-security-event.cpp

@@ -40,7 +40,7 @@ ConferenceSecurityEvent::ConferenceSecurityEvent (
 	time_t creationTime,
 	const ConferenceId &conferenceId,
 	SecurityAlertType securityAlertType,
-	IdentityAddress faultyDevice
+	const IdentityAddress &faultyDevice
 ) : ConferenceEvent(
 	*new ConferenceSecurityEventPrivate,
 	Type::ConferenceSecurityAlert,
@@ -52,12 +52,26 @@ ConferenceSecurityEvent::ConferenceSecurityEvent (
 	d->faultyDevice = faultyDevice;
 }
 
+ConferenceSecurityEvent::ConferenceSecurityEvent (
+	time_t creationTime,
+	const ConferenceId &conferenceId,
+	SecurityAlertType securityAlertType
+) : ConferenceEvent(
+	*new ConferenceSecurityEventPrivate,
+	Type::ConferenceSecurityAlert,
+	creationTime,
+	conferenceId
+) {
+	L_D();
+	d->securityAlertType = securityAlertType;
+}
+
 ConferenceSecurityEvent::SecurityAlertType ConferenceSecurityEvent::getSecurityAlertType () const {
 	L_D();
 	return d->securityAlertType;
 }
 
-const IdentityAddress ConferenceSecurityEvent::getFaultyDevice () const {
+const IdentityAddress &ConferenceSecurityEvent::getFaultyDevice () const {
 	L_D();
 	return d->faultyDevice;
 }

src/event-log/conference/conference-security-event.h

@@ -48,11 +48,17 @@ public:
 		time_t creationTime,
 		const ConferenceId &conferenceId,
 		SecurityAlertType securityAlertType,
-		IdentityAddress faultyDevice
+		const IdentityAddress &faultyDevice
+	);
+
+	ConferenceSecurityEvent (
+		time_t creationTime,
+		const ConferenceId &conferenceId,
+		SecurityAlertType securityAlertType
 	);
 
 	SecurityAlertType getSecurityAlertType () const;
-	const IdentityAddress getFaultyDevice () const;
+	const IdentityAddress &getFaultyDevice () const;
 
 private:
 	L_DECLARE_PRIVATE(ConferenceSecurityEvent);