Commit b6496cbf authored by Ronan's avatar Ronan
Browse files

fix(core): remove useless default constructors and avoid memory leak on virtual destructor

parent cff45b8c
......@@ -29,8 +29,6 @@ LINPHONE_BEGIN_NAMESPACE
class LocalConferenceCallPrivate : public CallPrivate {
public:
LocalConferenceCallPrivate () = default;
std::shared_ptr<CallSession> getActiveSession () const override;
private:
......
......@@ -29,8 +29,6 @@ LINPHONE_BEGIN_NAMESPACE
class RemoteConferenceCallPrivate : public CallPrivate {
public:
RemoteConferenceCallPrivate () = default;
std::shared_ptr<CallSession> getActiveSession () const override;
private:
......
......@@ -54,8 +54,6 @@ public:
Started = 1 << 5,
};
ChatMessagePrivate () = default;
void setApplyModifiers (bool value) { applyModifiers = value; }
void setDirection (ChatMessage::Direction dir);
......@@ -138,7 +136,7 @@ public:
LinphoneContent *getFileTransferInformation () const;
void setFileTransferInformation (const LinphoneContent *content);
void addContent (Content &content);
void removeContent (const Content &content);
......
......@@ -28,9 +28,6 @@
LINPHONE_BEGIN_NAMESPACE
class BasicChatRoomPrivate : public ChatRoomPrivate {
public:
BasicChatRoomPrivate () = default;
private:
std::string subject;
std::list<std::shared_ptr<Participant>> participants;
......
......@@ -30,8 +30,6 @@ LINPHONE_BEGIN_NAMESPACE
class ClientGroupChatRoomPrivate : public ChatRoomPrivate {
public:
ClientGroupChatRoomPrivate () = default;
std::list<IdentityAddress> cleanAddressesList (const std::list<IdentityAddress> &addresses) const;
std::shared_ptr<CallSession> createSession ();
void notifyReceived (const std::string &body);
......
......@@ -34,8 +34,6 @@ public:
bool hasBeenRead;
};
RealTimeTextChatRoomPrivate () = default;
void realtimeTextReceived (uint32_t character, const std::shared_ptr<Call> &call);
void sendChatMessage (const std::shared_ptr<ChatMessage> &chatMessage) override;
void setCall (const std::shared_ptr<Call> &value) { call = value; }
......
......@@ -32,6 +32,8 @@ class Participant;
class ConferencePrivate {
public:
virtual ~ConferencePrivate () = default;
IdentityAddress conferenceAddress;
std::list<std::shared_ptr<Participant>> participants;
std::string subject;
......
......@@ -34,8 +34,6 @@ class CallSession;
class CallSessionParamsPrivate : public ClonableObjectPrivate {
public:
CallSessionParamsPrivate () = default;
void clone (const CallSessionParamsPrivate *src);
bool getInConference () const { return inConference; }
......
......@@ -20,8 +20,6 @@
#ifndef _L_MEDIA_SESSION_P_H_
#define _L_MEDIA_SESSION_P_H_
#include <utility>
#include "call-session-p.h"
#include "media-session.h"
......@@ -36,9 +34,6 @@
LINPHONE_BEGIN_NAMESPACE
class MediaSessionPrivate : public CallSessionPrivate {
public:
MediaSessionPrivate () = default;
public:
static int resumeAfterFailedTransfer (void *userData, unsigned int);
static bool_t startPendingRefer (void *userData);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment