Commit 21a5f1c0 authored by Ronan's avatar Ronan

fix(core): remove useless include, virtual... And add required virtual on some...

fix(core): remove useless include, virtual... And add required virtual on some classes (add a -Wdelete-non-virtual-dtor warning on clang)
parent 18d0c4ad
......@@ -284,7 +284,7 @@ else()
list(APPEND STRICT_OPTIONS_C "-fno-inline-small-functions")
endif()
if(CMAKE_C_COMPILER_ID MATCHES "Clang")
list(APPEND STRICT_OPTIONS_CPP "-Qunused-arguments" "-Wno-array-bounds")
list(APPEND STRICT_OPTIONS_CPP "-Qunused-arguments" "-Wno-array-bounds -Wdelete-non-virtual-dtor")
endif()
if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
list(APPEND STRICT_OPTIONS_CXX "-x c++")
......
......@@ -38,8 +38,6 @@ class RealTimeTextChatRoom;
class CallPrivate : public ObjectPrivate, public CallSessionListener {
public:
CallPrivate () = default;
void initiateIncoming ();
bool initiateOutgoing ();
void iterate (time_t currentRealTime, bool oneSecondElapsed);
......
......@@ -42,7 +42,7 @@ public:
SalCallOp *op,
const MediaSessionParams *msp
);
virtual ~RemoteConferenceCall ();
~RemoteConferenceCall ();
std::shared_ptr<Core> getCore () const;
......
......@@ -20,22 +20,18 @@
#ifndef _L_CONFERENCE_LISTENER_H_
#define _L_CONFERENCE_LISTENER_H_
#include <ctime>
#include <string>
#include <vector>
#include "linphone/utils/general.h"
#include "event-log/events.h"
// =============================================================================
LINPHONE_BEGIN_NAMESPACE
class IdentityAddress;
class ConferenceListener {
public:
virtual ~ConferenceListener () = default;
virtual void onConferenceCreated (const IdentityAddress &addr) {}
virtual void onConferenceKeywordsChanged (const std::vector<std::string> &keywords) {}
virtual void onConferenceTerminated (const IdentityAddress &addr) {}
......
......@@ -43,7 +43,7 @@ class LINPHONE_PUBLIC Conference :
friend class CallSessionPrivate;
public:
virtual ~Conference();
~Conference();
std::shared_ptr<Participant> getActiveParticipant () const;
......
......@@ -31,8 +31,6 @@ LINPHONE_BEGIN_NAMESPACE
class CallSessionPrivate : public ObjectPrivate, public CoreListener {
public:
CallSessionPrivate () = default;
int computeDuration () const;
virtual void initializeParamsAccordingToIncomingCallParams ();
void notifyReferState ();
......
......@@ -54,7 +54,7 @@ public:
L_DECLARE_ENUM(State, L_ENUM_VALUES_CALL_SESSION_STATE);
CallSession (const std::shared_ptr<Core> &core, const CallSessionParams *params, CallSessionListener *listener);
virtual ~CallSession ();
~CallSession ();
LinphoneStatus accept (const CallSessionParams *csp = nullptr);
LinphoneStatus acceptUpdate (const CallSessionParams *csp = nullptr);
......
......@@ -3432,7 +3432,7 @@ void MediaSessionPrivate::reportBandwidth () {
lInfo() << "Bandwidth usage for CallSession [" << q << "]:\n" << fixed << setprecision(2) <<
"\tRTP audio=[d=" << linphone_call_stats_get_download_bandwidth(audioStats) << ",u=" << linphone_call_stats_get_upload_bandwidth(audioStats) <<
"], video=[d=" << linphone_call_stats_get_download_bandwidth(videoStats) << ",u=" << linphone_call_stats_get_upload_bandwidth(videoStats) << ",ed=" << linphone_call_stats_get_estimated_download_bandwidth(videoStats) <<
"], video=[d=" << linphone_call_stats_get_download_bandwidth(videoStats) << ",u=" << linphone_call_stats_get_upload_bandwidth(videoStats) << ",ed=" << linphone_call_stats_get_estimated_download_bandwidth(videoStats) <<
"], text=[d=" << linphone_call_stats_get_download_bandwidth(textStats) << ",u=" << linphone_call_stats_get_upload_bandwidth(textStats) << "] kbits/sec\n" <<
"\tRTCP audio=[d=" << linphone_call_stats_get_rtcp_download_bandwidth(audioStats) << ",u=" << linphone_call_stats_get_rtcp_upload_bandwidth(audioStats) <<
"], video=[d=" << linphone_call_stats_get_rtcp_download_bandwidth(videoStats) << ",u=" << linphone_call_stats_get_rtcp_upload_bandwidth(videoStats) <<
......
......@@ -40,7 +40,7 @@ class LINPHONE_PUBLIC MediaSession : public CallSession {
public:
MediaSession (const std::shared_ptr<Core> &core, std::shared_ptr<Participant> me, const CallSessionParams *params, CallSessionListener *listener);
virtual ~MediaSession ();
~MediaSession ();
LinphoneStatus accept (const MediaSessionParams *msp = nullptr);
LinphoneStatus acceptEarlyMedia (const MediaSessionParams *msp = nullptr);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment