Commit d948afeb authored by jehan's avatar jehan
Browse files

update remote destination once a checklist is completed. Former behavior was...

update remote destination once a checklist is completed. Former behavior was to wait until all checklist to be completed. This new behavior speed up session establishement for communication with webrtc
parent 832cf417
......@@ -258,7 +258,6 @@ static bool_t ms_dtls_srtp_process_dtls_packet(mblk_t *msg, MSDtlsSrtpContext *c
if ((*(msg->b_rptr)>19) && (*(msg->b_rptr)<64)) {
DtlsRawPacket *incoming_dtls_packet;
RtpSession *rtp_session = ctx->stream_sessions->rtp_session;
incoming_dtls_packet = (DtlsRawPacket *)ms_malloc0(sizeof(DtlsRawPacket));
//DtlsRawPacket *incoming_dtls_packet = (DtlsRawPacket *)ms_malloc0(sizeof(DtlsRawPacket));
......@@ -267,7 +266,7 @@ static bool_t ms_dtls_srtp_process_dtls_packet(mblk_t *msg, MSDtlsSrtpContext *c
memcpy(incoming_dtls_packet->data, msg->b_rptr, msgLength);
/*required by webrtc in server case when ice is not completed yet*/
rtp_session_update_remote_sock_addr(rtp_session, msg,is_rtp,FALSE);
/* no more required because change is performed by ice.c once a check list is ready rtp_session_update_remote_sock_addr(rtp_session, msg,is_rtp,FALSE);*/
ms_message("DTLS Receive %s packet len %d sessions: %p rtp session %p ssl state is %x", is_rtp==TRUE?"RTP":"RTCP", (int)msgLength, ctx->stream_sessions, ctx->stream_sessions->rtp_session, ssl->state);
......@@ -2970,8 +2970,7 @@ static bool_t ice_session_contains_check_list(const IceSession *session, const I
return FALSE;
static void ice_continue_processing_on_next_check_list(IceCheckList *cl, RtpSession *rtp_session)
static void ice_continue_processing_on_next_check_list(IceCheckList *cl, RtpSession *rtp_session) {
IceCheckList *next_cl;
if (ice_session_contains_check_list(cl->session, cl) == FALSE) {
ms_error("ice: Could not find check list in the session");
......@@ -2990,6 +2989,7 @@ static void ice_continue_processing_on_next_check_list(IceCheckList *cl, RtpSess
cl->session->event_time = ice_add_ms(ice_current_time(), 1000);
cl->session->send_event = TRUE;
} else {
/* Activate the next check list. */
......@@ -3020,13 +3020,25 @@ static void ice_conclude_processing(IceCheckList *cl, RtpSession *rtp_session)
if (cb.result == TRUE) {
nb_losing_pairs = ice_check_list_nb_losing_pairs(cl);
if ((cl->state != ICL_Completed) && (nb_losing_pairs == 0)) {
const char *rtp_addr;
const char *rtcp_addr;
int rtp_port;
int rtcp_port;
bool_t result;
cl->state = ICL_Completed;
cl->nomination_delay_running = FALSE;
ms_message("ice: Finished ICE check list processing successfully!");
ms_message("ice: Finished ICE check list [%p] processing successfully!",cl);
/* Initialise keepalive time. */
cl->keepalive_time = ice_current_time();
result = ice_check_list_selected_valid_remote_candidate(cl, &rtp_addr, &rtp_port, &rtcp_addr, &rtcp_port);
if (result == TRUE) {
rtp_session_set_remote_addr_full(rtp_session, rtp_addr, rtp_port, rtcp_addr, rtcp_port);
} else {
ms_error("Cannot get remote candidate for check list [%p]",cl);
/* Notify the application of the successful processing. */
ortp_event_get_data(ev)->info.ice_processing_successful = TRUE;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment