- 21 Mar, 2012 - 2 commits
-
-
Marcelo Roberto Jimenez authored
-
Marcelo Roberto Jimenez authored
autoconf seems to generate the contents in another order, and it generates anoying changes to git.
-
- 18 Mar, 2012 - 2 commits
-
-
Fabrice Fontaine authored
Replace sprintf by snprintf in http_WriteHttpPost to avoid buffer overflow.
-
Fabrice Fontaine authored
Add infoSize parameter to get_sdk_info function to replace sprintf call by a snprintf call.
-
- 16 Mar, 2012 - 3 commits
-
-
Fabrice Fontaine authored
Check return code of ixmlDocument_CreateElementEx in ixmlDocument_CreateElement. Check return code of ixmlNode_setNodeName and ixmlNode_setNodeValue in ixmlNode_cloneCDATASect and ixmlNode_cloneTextNode.
-
Marcelo Roberto Jimenez authored
Also, really remove the dead code.
-
Fabrice Fontaine authored
Comment unused SERVER from DeviceShutdown. Comment unused max from parse_hostport. Comment unused nodeptr from ixmlNode_cloneDoc. Comment unused newNode from Parser_hasDefaultNamespace. Comment unused Parser_parseReference function Check return code of shutdown and display an error if needed.
-
- 15 Mar, 2012 - 5 commits
-
-
Marcelo Roberto Jimenez authored
src/genlib/net/http/httpreadwrite.c: In function ‘http_Download’: src/genlib/net/http/httpreadwrite.c:790:5: warning: format ‘%d’ expects type ‘int’, but argument 6 has type ‘size_t’ src/genlib/net/http/httpreadwrite.c:790:5: warning: format ‘%d’ expects type ‘int’, but argument 7 has type ‘size_t’ (cherry picked from commit 5969530d)
-
Fabrice Fontaine authored
Replace HAVE_UPNP_OPTSSDP by UPNP_HAVE_OPTSSDP in upnpapi.c.
-
Fabrice Fontaine authored
Modify configure.ac to add --disable-optssdp option. This option will remove OPT, 01-NLS and X_USER_AGENT headers from SSDP messages as those headers are optional. If --disable-gena and disable-optssdp are both used, uuid part will not be compiled anymore.
-
Fabrice Fontaine authored
Commit d48d7372 added a bug in ixmlNode_allowChildren, this function was returning FALSE instead of TRUE when newChild->nodeName was eELEMENT_NODE.
-
Fabrice Fontaine authored
Change ret_code from int to parse_status_t in match. Set back return code of ReadResponseLineAndHeaders from parse_status_t to int as this function can return UPNP_E_BAD_HTTPMSG. As a result, do not cast the result of this function into parse_status_t in http_OpenHttpGetProxy and http_OpenHttpGetEx. Use switch with PARSE_OK in parsetools.c. Add missing explicit casts of integer constants in uri.c and httpreadwrite.c. Use switch, int and sa_family_t with AF_INET in uri.c. Print an error in http_Download if realloc failed.
-
- 14 Mar, 2012 - 9 commits
-
-
Fabrice Fontaine authored
Replace if statements with switch when using HND_DEVICE and HND_CLIENT enum constants. Correct also UpnpUnRegisterRootDeviceLowPower and UpnpUnRegisterClient as those functions were wrongly awaiting an UPNP_E_INVALID_HANDLE instead of HND_INVALID from GetHandleInfo.
-
Fabrice Fontaine authored
Do not compile CreateClientRequestPacketUlaGua if IPv6 is disable. Cast DestAddr->sa_family from sa_family_t into int when calling CreateServicePacket as this function has been set back to accept int in a692e591. Use switch instead of if with AF_INET and AF_INET6. Add missing casts from AF_INET and AF_INET6 into sa_family_t when using them to set sin_family and sin6_family. Add missing explicit casts into size_t or lu when using integer constants with strlen or unsigned long indexes. Set SSDP_PAUSE to be unsigned as it is used with usleep.
-
Fabrice Fontaine authored
Replace if statements with switch when using enums in ixml. Remove uneeded initialization in ixmlAttr_init, Parser_init and ixmlNode_init which was added by wrongly added in commit 06660b63.
-
Fabrice Fontaine authored
Replace if statements with switch when using enums in threadutil.
-
Fabrice Fontaine authored
There was a missing break in PARSE_INCOMPLETE_ENTITY due to commit 2eb3e069.
-
Yoichi NAKAYAMA authored
Commit c40d2bc0 has a problem at removing the parentheses in parser_parse_responseline. Difference of pointers was used with intention, don't cast them separately.
-
Yoichi NAKAYAMA authored
Include UpnpStdInt.h for ssize_t. Define sa_family_t in UpnpInet.h.
-
Yoichi NAKAYAMA authored
Handle overflow before changing SsdpEvent. Because the behavior of "snprintf" is platform dependent in such case.
-
Yoichi NAKAYAMA authored
SF Bug Tracker id 3502958 - The commit 5944960e prevents a pupnp client (amule) from receiving replies from an IGD device. Previous change broke the feature. The error of unique_service_name in ssdp_request_type should be ignored. This reverts commit 5944960e.
-
- 13 Mar, 2012 - 3 commits
-
-
Marcelo Roberto Jimenez authored
src/genlib/net/sock.c: In function ‘sock_read_write’: src/genlib/net/sock.c:172:4: warning: conversion to ‘long int’ from ‘size_t’ may change the sign of the result
-
Marcelo Roberto Jimenez authored
Reference: "man 2 socket".
-
Marcelo Roberto Jimenez authored
(This is a fix to commit 86bef097)
-
- 12 Mar, 2012 - 1 commit
-
-
Marcelo Roberto Jimenez authored
This is a fix to commit 2fb791c9.
-
- 11 Mar, 2012 - 2 commits
-
-
Fabrice Fontaine authored
Remove more "implicit integer or enum conversions" errors as well as dead code.
-
Yoichi NAKAYAMA authored
It is a static function and is called with AF_INET6, so there is no real problem.
-
- 10 Mar, 2012 - 1 commit
-
-
Fabrice Fontaine authored
Remove more "implicit integer or enum conversions" as well as memset before snprintf.
-
- 11 Mar, 2012 - 2 commits
-
-
Yoichi NAKAYAMA authored
There was a problem in HDR_ACCEPT_LANGUAGE case. It may read from TmpBuf larger amount than allocated, since condition was always true. Terminate RespInstr->AcceptLanguageHeader correctly. Skip allocation if there is already sufficient buffer.
-
Yoichi NAKAYAMA authored
It is a static function and is called with AF_INET or AF_INET6, so there is no real problem.
-
- 10 Mar, 2012 - 10 commits
-
-
Fabrice Fontaine authored
Remove some of the "implicit integer or enum conversions" as well as some access to NULL reference in upnp part.
-
Fabrice Fontaine authored
If ThreadPoolInit returned EAGAIN, tp->lock was not freed.
-
Fabrice Fontaine authored
Remove "implicit integer conversions" and "dereference NULL return value" errors in ixml part.
-
Yoichi NAKAYAMA authored
-
Yoichi NAKAYAMA authored
-
Yoichi NAKAYAMA authored
Respect unique_service_name error in ssdp_request_type so as not to touch non-terminated buffer under Evt.
-
Yoichi NAKAYAMA authored
-
Yoichi NAKAYAMA authored
Pass output buffer size to addrToString and detect overflow. Handle addrToString error in configure_urlbase.
-
Yoichi NAKAYAMA authored
Pass output buffer size to CreateClientRequestPacket(UlaGua) from SearchByTarget and detect overflow. Handle SearchByTarget error in UpnpSearchAsync.
-
Yoichi NAKAYAMA authored
-