• Timothy B. Terriberry's avatar
    Eliminate more warnings. · c4d7e5e6
    Timothy B. Terriberry authored
    This eliminates a large set of warnings exposed by the Mozilla build
     system (Use of C++ comments in ISO C90 source, commas at the end of
     enum lists, a couple incomplete initializers, and signed/unsigned
     comparisons).
    It also eliminates many (but not all) of the warnings expose by newer
     GCC versions and _FORTIFY_SOURCE (e.g., calling fread and fwrite
     without checking the return values).
    There are a few spurious warnings left on my system:
    
    ../vp8/encoder/encodemb.c:274:9: warning: 'sz' may be used
     uninitialized in this function
    gcc seems to be unable to figure out that the value shortcut doesn't
     change between the two if blocks that test it here.
    
    ../vp8/encoder/onyx_if.c:5314:5: warning: comparison of unsigned
     expression >= 0 is always true
    ../vp8/encoder/onyx_if.c:5319:5: warning: comparison of unsigned
     expression >= 0 is always true
    This is true, so far as it goes, but it's comparing against an enum, and the C
     standard does not mandate that enums be unsigned, so the checks can't be
     removed.
    
    Change-Id: Iaf689ae3e3d0ddc5ade00faa474debe73b8d3395
    c4d7e5e6
activeinfo3d_p.h 2.76 KiB
/****************************************************************************
**
** Copyright (C) 2014 Digia Plc and/or its subsidiary(-ies).
** Contact: http://www.qt-project.org/legal
**
** This file is part of the QtCanvas3D module of the Qt Toolkit.
**
** $QT_BEGIN_LICENSE:LGPL$
** Commercial License Usage
** Licensees holding valid commercial Qt licenses may use this file in
** accordance with the commercial license agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
** a written agreement between you and Digia.  For licensing terms and
** conditions see http://qt.digia.com/licensing.  For further information
** use the contact form at http://qt.digia.com/contact-us.
** GNU Lesser General Public License Usage
** Alternatively, this file may be used under the terms of the GNU Lesser
** General Public License version 3 as published by the Free Software
** Foundation and appearing in the file LICENSE.LGPLv3 included in the
** packaging of this file.  Please review the following information to
** ensure the GNU Lesser General Public License version 3 requirements
** will be met: https://www.gnu.org/licenses/lgpl.html.
** GNU General Public License Usage
** Alternatively, this file may be used under the terms of the GNU
** General Public License version 2.0 or later as published by the Free
** Software Foundation and appearing in the file LICENSE.GPL included in
** the packaging of this file.  Please review the following information to
** ensure the GNU General Public License version 2.0 requirements will be
** met: http://www.gnu.org/licenses/gpl-2.0.html.
** $QT_END_LICENSE$
****************************************************************************/
//  W A R N I N G
//  -------------
// This file is not part of the QtCanvas3D API.  It exists purely as an
// implementation detail.  This header file may change from version to
// version without notice, or even be removed.
// We mean it.
#ifndef CANVASACTIVEINFO_P_H
#define CANVASACTIVEINFO_P_H
#include <QObject>
#include "context3d_p.h"
class CanvasActiveInfo : public QObject
    Q_OBJECT
    Q_PROPERTY(int size READ size NOTIFY sizeChanged)
    Q_PROPERTY(CanvasContext::glEnums type READ type NOTIFY typeChanged)
    Q_PROPERTY(QString name READ name NOTIFY nameChanged)
public:
    explicit CanvasActiveInfo(int size, CanvasContext::glEnums type,
                              QString name, QObject *parent = 0);
    int size() const;
    CanvasContext::glEnums type() const;
    const QString name() const;
signals:
    void sizeChanged(int size);
7172737475767778798081
void typeChanged(CanvasContext::glEnums type); void nameChanged(const QString name); private: int m_size; CanvasContext::glEnums m_type; QString m_name; }; #endif // CANVASACTIVEINFO_P_H