Skip to content
  • Giuseppe D'Angelo's avatar
    PCRE2: port QRegularExpression to PCRE2 · 9ca63548
    Giuseppe D'Angelo authored
    PCRE1 is going towards EOL. PCRE2 is the way forward in terms
    of new features, performance, and security improvements. The
    APIs that QRegularExpression uses are similar so the required
    modifications aren't extensive.
    
    The biggest difference comes to JIT-compiling of the pattern.
    
    In PCRE1, JIT-compiling did not modify the processed PCRE pattern,
    but returned a new chunk of data.
    
    This allowed multiple threads to keep matching using the same
    processed data and NULL for the JIT data, until a thread
    JIT-compiled and atomically set the shared JIT data to the results
    of the compilation.
    
    In PCRE2, JIT-compiling _modifies_ the processed PCRE pattern in a
    way that it's thread unsafe [1]; the results of JIT-compilation
    are stored somewhere inside the processed pattern.
    This means the above approach cannot work -- a thread may be
    matching while another one JIT-compiles, causing a data race.
    
    While waiting for better workarounds from upstream, employ a
    read/write mutex to protect the matching from JIT-compilation.
    
    [1] https://lists.exim.org/lurker/message/20160104.105831.3cb25b39.en.html
    
    
    
    [ChangeLog][General] QRegularExpression now requires the PCRE2
    library, at least version 10.20. Support for the PCRE1 library
    has been dropped. A copy of PCRE2 is shipped with Qt and will
    automatically be used on those platforms which lack it.
    
    Change-Id: I9fe11104230a096796df2d0bdcea861acf769f57
    Reviewed-by: default avatarThiago Macieira <thiago.macieira@intel.com>
    9ca63548