Commit 136ccaa2 authored by John Brooks's avatar John Brooks Committed by Shawn Rutledge
Browse files

Ignore alert on an active window


When QWindow::alert() is called with a duration of 0, it calls
QPlatformWindow::setAlertState(true), and expects the alert state to be
reset when the window is next activated. Other calls to alert are
ignored while alertState is still true.

If alert was called for an active window, it would remain in the alert
state until deactivated and activated again, and on some platforms calls
to alert would be broken while deactivated.

Alerting doesn't make sense for active windows, so we can simply ignore
it, which was the behavior with Qt 4 on some platforms.

Change-Id: Ia3324da4c89db711b63eb31cddf0bf742bb4e3b8
Found-By: default avatarJan Noertemann <jan.noertemann@uni-dortmund.de>
Reviewed-by: default avatarFriedemann Kleint <Friedemann.Kleint@digia.com>
Reviewed-by: default avatarMartin Gräßlin <mgraesslin@kde.org>
Reviewed-by: default avatarShawn Rutledge <shawn.rutledge@digia.com>
parent 0b49ce2f
Showing with 2 additions and 2 deletions
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment