- Jan 02, 2016
-
-
Marc Mutz authored
- populate the widget with addItems(QStringList) instead of looping over addItem(QString) - Use findText() instead of looping over itemText(int). QComboBox::findText() delegates searching to the model (via QAbstractItemModel::match()), so is potentially much faster. I say potentially, because match() isn't properly reimplemented in most models, yet. But that is something to fix in the models. Change-Id: I6e52cf5af810ab7869c0270504a241868a5ca281 Reviewed-by:
Olivier Goffart (Woboq GmbH) <ogoffart@woboq.com>
-
- Sep 04, 2015
-
-
David Faure authored
Change-Id: Ie5fdfd6aa3866c14b6fbfabf4533327f5c73c5a3 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@theqtcompany.com> Reviewed-by:
Frederik Gladhorn <frederik.gladhorn@theqtcompany.com> Reviewed-by:
Marc Mutz <marc.mutz@kdab.com>
-
- Sep 03, 2015
-
-
Andy Shaw authored
Change-Id: Ia74edf45e78fb81256da86d572459b3ed38663d4 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@theqtcompany.com>
-
- Aug 13, 2015
-
-
David Faure authored
This happens when the cwd got deleted meanwhile; this warning is printed out: QFileSystemEngine::currentPath: getcwd() failed and currentPath() is empty. Not a problem in itself, but qprintdialog should not assume it's not empty, then. Change-Id: I5c89992b36ca58b6325ced399cff33aca9efb7ec Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
- Feb 11, 2015
-
-
Jani Heikkinen authored
Qt copyrights are now in The Qt Company, so we could update the source code headers accordingly. In the same go we should also fix the links to point to qt.io. Outdated header.LGPL removed (use header.LGPL21 instead) Old header.LGPL3 renamed to header.LGPL3-COMM to match actual licensing combination. New header.LGPL-COMM taken in the use file which were using old header.LGPL3 (src/plugins/platforms/android/extract.cpp) Added new header.LGPL3 containing Commercial + LGPLv3 + GPLv2 license combination Change-Id: I6f49b819a8a20cc4f88b794a8f6726d975e8ffbe Reviewed-by:
Matti Paaso <matti.paaso@theqtcompany.com>
-
- Dec 03, 2014
-
-
Olivier Goffart authored
Done automatically with clang-modernize on linux (But does not add Q_DECL_OVERRIDE to the function that are marked as inline because it a compilation error with MSVC2010) Change-Id: I2196ee26e3e6fe20816834ecea5ea389eeab3171 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
- Sep 24, 2014
-
-
Matti Paaso authored
- Renamed LICENSE.LGPL to LICENSE.LGPLv21 - Added LICENSE.LGPLv3 - Removed LICENSE.GPL Change-Id: Iec3406e3eb3f133be549092015cefe33d259a3f2 Reviewed-by:
Iikka Eklund <iikka.eklund@digia.com>
-
- Mar 17, 2014
-
-
John Layt authored
We no longer use QLibrary to load CUPS, so remove checks. Switch from using QCupsSupport and QPrinterInfo to QPlatformPrintDevice. The remaining use of QCupsSupport is only for utilities to set CUPS specific options which don't need to link to CUPS directly, these will be replaced later with generic cross-platform API. Change-Id: I6e3d9e9a59633c33af0555eb28443a9fc192b27c Reviewed-by:
Lars Knoll <lars.knoll@digia.com>
-
John Layt authored
Convert the Linux / CUPS version of the QPageSetupDialog to use QPageSize and QPageLayout internally. As this is an almost complete re-write of the internals the liberty has been taken of doing renames and code moves that would normally be done in separate commits, but in this case would have been mostly pointless done separately. Change-Id: I6eaa7c1fbf0a04cb3425f1d322fcae89239e83b7 Reviewed-by:
Lars Knoll <lars.knoll@digia.com>
-
- Jan 06, 2014
-
-
John Layt authored
If you click on the properties button and change the page settings and click OK, then click properties a second time and click cancel, then your original changes are forgotten. Ensure the properties dialog is only deleted if the OK button has never been clicked. Change-Id: I81be8a2c941eeec36c03647d7fea8f498154930a Reviewed-by:
Andy Shaw <andy.shaw@digia.com>
-
- Dec 09, 2013
-
-
John Layt authored
First set up the selected output format, printer and page size, and then setup the selected job options. This ensures all values are correctly setup for the requested format and printer as not all settings may be able to persist across the change in output format or printer. Change-Id: I67f261f4e3be479a9018139633886ee8e570f42a Reviewed-by:
Andy Shaw <andy.shaw@digia.com>
-
- Dec 08, 2013
-
-
John Layt authored
The print dialog was setting the PageOrder on the QPrinter as soon as the check box was toggled and not when the Print button was pressed, meaning the change is not forgotten when Cancel is pressed. Change-Id: I19637b7efacfb5388c70d2e7d9d05a05ecc5b2ea Reviewed-by:
Andy Shaw <andy.shaw@digia.com>
-
- Nov 07, 2013
-
-
Tor Arne Vestbø authored
The library needs to do Q_INIT_RESOURCE for all resources it uses internally, otherwise static linking will fail, and the user has no idea how to rectify it as the name of the missing resource is not known. The Q_INIT_RESOURCE needs to happen outside of any namespace, hence the use of static initResources() functions. Change-Id: I8f7d36b440b05809d97dd489cf8789f345633cec Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
- Sep 20, 2013
-
-
Martin Klapetek authored
Some apps may not support printing only a particular page range, but with CUPS we can do "server-side print range", ie. we can select the page range for the application. If CUPS is available, the Page Range widget is now displayed if app advertises no such capability and page range is selected on the server instead. [ChangeLog][QtPrintSupport][QPrintDialog] Added CUPS server-side print range support for apps that can't support print range option themselves Change-Id: Ia7784065ba5a8b53bb05ae46e982c718ef672fa5 Reviewed-by:
John Layt <jlayt@kde.org>
-
- Sep 19, 2013
-
-
Martin Klapetek authored
Prevents a crash in case the user did not open the properties dialog, in which case QUnixPrintWidgetPrivate::propertiesDialog is null. Change-Id: I43c8c6ab90053757835bbf41d6167204d42efcef Reviewed-by:
John Layt <jlayt@kde.org>
-
Martin Klapetek authored
On systems with CUPS support users can now choose how many pages from a document are to be printed on paper. This can vary from 1 page per document to 16 pages per document. The page preview changes upon the users selection. Also included in the patch is an option to choose the flow for text. Users can now print documents in the "Right to Left" order or "Bottom to Top", including many other options. [ChangeLog][QtPrintSupport][QPrintDialog] Added support for setting CUPS Pages Per Sheet and Pages Per Sheet Layout options Change-Id: I4e60a4523c6e06d4c15fe9ee9590248fa7ae2038 Reviewed-by:
John Layt <jlayt@kde.org>
-
- Sep 17, 2013
-
-
Martin Klapetek authored
Adds combobox to select CUPS Page Set option (even/odd pages) into the Unix print dialog [ChangeLog][QtPrintSupport][QPrintDialog] Added support for setting CUPS Page Set (even/odd pages only) in the print dialog. Change-Id: I27dd846f58c164039fe2759064aafdf726a1287e Reviewed-by:
John Layt <jlayt@kde.org>
-
- Sep 10, 2013
-
-
Martin Klapetek authored
This adds new tab 'Job Options' into Properties dialog in print dialog. In this tab it's possible to set some advanced printing job options such as print schedule, job priority or job billing. Patch also adds new utility methods into QCUPSSupport, which are used to set particular CUPS job options. [ChangeLog][QtPrintSupport][QPrintDialog] Added support for setting CUPS job options in the print dialog. Change-Id: If2640eedb3d83f50cbb20491f7ec50b325f54f22 Reviewed-by:
John Layt <jlayt@kde.org>
-
- Jan 18, 2013
-
-
Sergio Ahumada authored
Change-Id: Ic804938fc352291d011800d21e549c10acac66fb Reviewed-by:
Lars Knoll <lars.knoll@digia.com>
-
- Nov 22, 2012
-
-
Teemu Katajisto authored
Update printer defaults in UNIX print dialog when printer is changed. Task-number: QTBUG-23037 Task-number: QTBUG-6239 Task-number: QTBUG-15351 Task-number: QTBUG-19233 Task-number: QTBUG-22036 Change-Id: Ib03635035211bd69b5b23da20ffd2c03ac318a1a Reviewed-by:
Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@digia.com>
-
Teemu Katajisto authored
The Advanced tab shows CUPS options and duplicates some of the settings in Page tab. These duplicate settings cannot be kept in synchronization and thus the Advanced tab causes confusion which settings are used. Remove the Advanced tab because the same settings are either available in Page tab or can be configured in system printer settings. Change-Id: I2dc2bf8b3b84dd19f24b2e6c1c9539c925d5d725 Reviewed-by:
Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@digia.com> Reviewed-by:
Lars Knoll <lars.knoll@digia.com>
-
- Sep 22, 2012
-
-
Iikka Eklund authored
Change copyrights and license headers from Nokia to Digia Change-Id: If1cc974286d29fd01ec6c19dd4719a67f4c3f00e Reviewed-by:
Lars Knoll <lars.knoll@digia.com> Reviewed-by:
Sergio Ahumada <sergio.ahumada@digia.com>
-
- Jul 17, 2012
-
-
Friedemann Kleint authored
Change-Id: Ieefe602dc8328a2e4188f7fa341016f8e330526e Reviewed-by:
Joerg Bornemann <joerg.bornemann@nokia.com>
-
- Jun 19, 2012
-
-
Oswald Buddenhagen authored
qrc_ files are generally not meant to be included, so there is not much point in doing this. qprintsupport was a notable exception - which broke on mac and thus needed a hack. just remove the qrc_ inclusion. Change-Id: If5115665f331a280869e800673bf7b81d3ab559a Reviewed-by:
Joerg Bornemann <joerg.bornemann@nokia.com>
-
- Jun 01, 2012
-
-
John Layt authored
Move QUnixPrintWidget from the header to the UNIX implementation as it is not used anywhere else and doesn't need to be exported. Make the private slots only compile under UNIX, remove the Mac and Win stubs for them as unneeded. Add some documentation to the UNIX dialog Change-Id: I8f30504285df877e17ac8eeace875f666f43d94d Reviewed-by:
Teemu Katajisto <teemu.katajisto@digia.com> Reviewed-by:
John Layt <jlayt@kde.org>
-
- May 31, 2012
-
-
John Layt authored
Move CUPS code around to create a new CUPS printsupport plugin, this fixes QPrinterInfo for CUPS which depends on the plugin to work. It QT_NO_CUPS is defined then the plugin is not built and only Print to PDF is supported under Linux. * Move unused genericiunixprintersupport plugin to start new CUPS printsupport plugin * Split QPdfPrintEngine to create QCupsPrintEngine * Remove LPR related code from QPdfPrintEngine * Move CUPS specific code from plugin base class to derived CUPS class * Remove forcing CUPS print engine to use PDF mode as PDF is now Native * Move qt_getCupsPrinterPaperSizes from qprinterinfo_unix to QCUPSSupport * Remove qprinterinfo_unix as no longer used * Remove all QT_NO_LPR uses There is now no CUPS specific code left in printsupport/kernel except QCUPSSupport which is needed for the dialogs. Task-number: QTBUG-23060 Change-Id: Ie8fa4512a2424edc8943068e0fa9fb714cc42db9 Reviewed-by:
Teemu Katajisto <teemu.katajisto@digia.com> Reviewed-by:
Lars Knoll <lars.knoll@nokia.com> Reviewed-by:
John Layt <jlayt@kde.org>
-
- May 28, 2012
-
-
John Layt authored
Fix an assert that wasn't changed when the "Print to PS" option was removed Change-Id: Ife7350976707059861660a74dc2f89d302d861f0 Reviewed-by:
Teemu Katajisto <teemu.katajisto@digia.com> Reviewed-by:
John Layt <jlayt@kde.org>
-
- May 08, 2012
-
-
Rohan McGovern authored
This doesn't compile with a typical cross-compilation setup, which generally won't include cups headers. The commit should have been rejected, but wasn't, due to a bug in the Qt Project CI. Since it now causes all other modules depending on qtbase to fail their CI, it must be reverted to minimize disruption while the commit can be amended and/or the test toolchain updated to include cups headers. This reverts commit 80f7a388 . Change-Id: I315ae275b37de358a74af28ab7bd691c9849acba Reviewed-by:
Sergio Ahumada <sergio.ahumada@nokia.com> Reviewed-by:
Toby Tomkins <toby.tomkins@nokia.com>
-
- May 07, 2012
-
-
John Layt authored
CUPS is the only supported print system on UNIX, LPR/PS support has already been dropped but some LPR specific code still remains. * Move qt_getCupsPrinterPaperSizes from qprinterinfo_unix to QCUPSSupport * Remove qprinterinfo_unix as no longer used * Remove LPR related code from QPdfPrintEngine * Remove all QT_NO_LPR uses * Remove most QT_NO_CUPS uses, use QT_NO_PRINTER where necessary Some QT_NO_CUPS uses remain in QPdfPrintEngine, these will be removed in a following change implementing a CUPS plugin. Change-Id: I439b6fad9cf88c3d24aa48e49475f49ad310dbad Reviewed-by:
Lars Knoll <lars.knoll@nokia.com>
-
- Apr 19, 2012
-
-
Konstantin Ritt authored
Task-number: QTBUG-4902 Change-Id: Ie9124de45be2d8e859f8b0aaea246e660145a1c5 Reviewed-by:
John Layt <jlayt@kde.org> Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
-
- Mar 28, 2012
-
-
hjk authored
Task-number: QTBUG-23272 Change-Id: Idcdb9620910577b3c0fc9a792a0446665bd2eab6 Reviewed-by:
Lars Knoll <lars.knoll@nokia.com>
-
- Mar 27, 2012
-
-
Qt4iOS authored
Some code intended to be disabled when QT_NO_PRINTDIALOG is defined was being compiled due to misplaced #ifdef and/or #endif. Change-Id: Ic8587872fae03cac2895e54e34f8f20cb575d92b Reviewed-by:
John Layt <jlayt@kde.org>
-
- Jan 30, 2012
-
-
Jason McDonald authored
As in the past, to avoid rewriting various autotests that contain line-number information, an extra blank line has been inserted at the end of the license text to ensure that this commit does not change the total number of lines in the license header. Change-Id: I311e001373776812699d6efc045b5f742890c689 Reviewed-by:
Rohan McGovern <rohan.mcgovern@nokia.com>
-
- Jan 23, 2012
-
-
Jason McDonald authored
Replace Nokia contact email address with Qt Project website. Change-Id: I431bbbf76d7c27d8b502f87947675c116994c415 Reviewed-by:
Rohan McGovern <rohan.mcgovern@nokia.com>
-
- Jan 05, 2012
-
-
Jason McDonald authored
Change-Id: I02f2c620296fcd91d4967d58767ea33fc4e1e7dc Reviewed-by:
Rohan McGovern <rohan.mcgovern@nokia.com>
-
- Oct 26, 2011
-
-
Friedemann Kleint authored
Compile without -qpa. Change-Id: Icfbf733964a7d6db80f8ec706a4b6fe84cd71b4d Reviewed-by:
Oliver Wolff <oliver.wolff@nokia.com>
-
- Oct 03, 2011
-
-
Lars Knoll authored
The only place that now still knows about it is moc, so it can still parse old headers. Change-Id: Iafec080f99c67560974e9ebc0cbfb27d9a4b2d6f Reviewed-on: http://codereview.qt-project.org/5755 Reviewed-by:
Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@nokia.com>
-
- Aug 23, 2011
-
-
Morten Sorvig authored
Recompiling QtWidgets on Mac fails with: "ld: duplicate symbol qInitResources_qprintdialog() in .obj/debug-shared/qrc_qprintdialog.o and .obj/debug-shared/qprintdialog_unix.o " Ifdef out the include from qprintdialog_unix, leaving us with one instance of the synbol. Change-Id: I7e1f45de65020253e0cad4155fca94944e66c177 Reviewed-on: http://codereview.qt.nokia.com/3270 Reviewed-by:
Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by:
Richard Moe Gustavsen <richard.gustavsen@nokia.com>
-
- Aug 19, 2011
-
-
Lars Knoll authored
Create a libQtPrintSupport library that contains our current printing infrastructure. Long term this will get replaced with a libQtPrint, as the current architecture is not really maintainable. Change-Id: I7362fff6786b58c5b4e9213c23eda36d15048aa2 Reviewed-on: http://codereview.qt.nokia.com/3209 Reviewed-by:
Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by:
Gunnar Sletta <gunnar.sletta@nokia.com>
-
Lars Knoll authored
Introduce a QPagedPaintDevice class that has a newPage() method and page dimensions. QPdfWriter and QPrinter inherit from it. Add a bit of API to QPdfWriter. Change-Id: Ibf23e7fe741f3a5ed854faf5d249a272acc75f35 Reviewed-on: http://codereview.qt.nokia.com/3206 Reviewed-by:
Gunnar Sletta <gunnar.sletta@nokia.com>
-