- 01 Dec, 2014 - 5 commits
-
-
Thiago Macieira authored
Those functions weren't getting properly namespaced. Even if we're testing WinRT namespaced builds, it wouldn't catch this mistake: those functions would simply all be in the global namespace. I guess we don't have a "namespace cleanliness" test. Change-Id: I2d3d09dc66dad476563dbf51c171683be155ebfd Reviewed-by:
Maurice Kalinowski <maurice.kalinowski@theqtcompany.com> Reviewed-by:
Andrew Knight <andrew.knight@theqtcompany.com>
-
Thiago Macieira authored
Keep the WinRT specific parts for WinRT only. This commit is a partial reversal of 67c83f32 "Tighten Q_OS_WINRT ifdefs in qfunctions_winrt.h", which let the WinRT definitions out too wide. Strictly speaking, the C++ code that uses Microsoft::WRL::ComPtr<IAsyncInfo> without the #include is broken. The forward definition is not enough, but since Visual Studio is also broken, two wrongs made a right... (MSVC does not implement two-stage parsing of template code properly). But if you accidentally tried to compile qfunctions_winrt.h with a non-broken compiler, like GCC (MinGW), it would correctly complain. Change-Id: I7591015861d291a82050afe0f4df0cb18b43e23d Reviewed-by:
Andrew Knight <andrew.knight@theqtcompany.com> Reviewed-by:
Maurice Kalinowski <maurice.kalinowski@theqtcompany.com>
-
Thiago Macieira authored
Whenever a binary is created and linked against a static lib that was compiled with LTCG, the final linking step requires the compiler flags so that the pre-compiled data in the shared library can get properly compiled. This could happen for a static build of Qt with LTCG, but also happens frequently for Qt's own build when linking regular libraries and applications against QtBootstrap or QtPlatformSupport. The linking fails when the target is a shared library (example: QtWaylandClient linking against QtPlatformSupport). The .prl file actually contains the "ltcg" flag, so the best solution would actually be to process that flag there and add link_ltcg if any dependent .prl has "ltcg", but I couldn't find out how to do that. Change-Id: I4a75a14d1dcb8c2089a427285e25d5555df7d7d3 Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
-
Thiago Macieira authored
Change-Id: I51384b4c3ceca25b6e010ccf67fa0f1995cfa557 Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
-
Tor Arne Vestbø authored
Combining them could lead to intermediate builds having cached the path, but not the version, resulting in later version checks failing. Change-Id: Ia10f4268ce7b9e82c81627970236d68c00b80391 Reviewed-by:
Richard Moe Gustavsen <richard.gustavsen@theqtcompany.com> Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@digia.com>
-
- 28 Nov, 2014 - 3 commits
-
-
Richard Moe Gustavsen authored
If using an older version of Xcode, Xcode will sometimes complain that LaunchScreen.xib uses auto layout while the project at the same time has deployment target set to 5.0 (where auto layout is not supported). This is a bug in Xcode really, since LaunchScreen.xib will only be used when running on iOS 7 (otherwise a LaunchImage will be used). This has been fixed in Xcode 6. This patch adds a check for this early on. Change-Id: Ie612c25b413add23e15fc3cb4f9e30bb5292369d Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@digia.com>
-
David Faure authored
(clang warning) Change-Id: Id751443e03be4f2bd1721cbe9d9a898d9619b29b Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@theqtcompany.com>
-
Albert Astals Cid authored
The loop is there because watchers may have two Watcher for the same fd, one for read and one for write, but after we're processed the correct one we don't need to keep looping. This fixes a crash since it's possible that while in processing q_dbus_watch_handle we get a watch added/remove this invalidating the iterator and crashing Change-Id: Icb61deae272d2f237a4c616fae598404d419af90 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
- 27 Nov, 2014 - 15 commits
-
-
Frederik Gladhorn authored
Conflicts: dist/changes-5.4.0 7231e1fb went into 5.4 instead of the 5.4.0 branch, thus the conflict. Change-Id: I70b8597ab52506490dcaf700427183950d42cbd1
-
Richard Moe Gustavsen authored
propagate size hints means that we should forward minimum/maximum size set on QWindow to the underlying native window to restrict how the user can resize the window. On iOS this does not make sense, but nevertheless, if we don't override the function, the default implementation will issue a warning. This again will always make creator inform that the application ended with error upon exit. Change-Id: I0a8bd74c47fafe2115add5b6eb4e77616fcbc365 Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@digia.com>
-
Richard Moe Gustavsen authored
Change-Id: Ie8dc10be7ac8a73857a2b47e9bfb00954a7421a9 Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@digia.com>
-
BogDan Vatra authored
This is a temporary "fix" until we'll fix all the problems with the new Android Material theme. Task-number: QTBUG-42900 Change-Id: I5485cfd5ac5fdd66cb85da423fe2e63e65be010f Reviewed-by:
Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@theqtcompany.com> Reviewed-by:
J-P Nurmi <jpnurmi@theqtcompany.com>
-
Thiago Macieira authored
See http://lists.qt-project.org/pipermail/development/2014-November/019331.html Change-Id: I54876dd210c87690117b6aacf78aef0961e704ef Reviewed-by:
Jani Heikkinen <jani.heikkinen@theqtcompany.com>
-
Friedemann Kleint authored
Add a virtual function QWindowPrivate::closestAcceptableGeometry() which is called from the platform plugin. Task-number: QTBUG-36220 Task-number: QTBUG-36318 Change-Id: I2b3d205e2c75f1d4dd2ba1d333b0d89bc0fcf13a Reviewed-by:
Jan Arve Sæther <jan-arve.saether@theqtcompany.com>
-
Benjamin Lutz authored
The size calculation in QByteArray::toBase64 overcalculates the size required for the output by up to 3 Bytes. This is fixed, which also implies that truncate() at the end is needed only if OmitTrailingEquals is used. Task-number: QTBUG-32436 Change-Id: I92a893047e7aca027c4aa0a6655bcca514585ff5 Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com> Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Allan Sandfeld Jensen authored
QString::clear() sets the string to the null QString, not just an empty one. Change-Id: Ie6f070f9f2e464105a7b87376e6dad90b5e4d2f2 Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
-
Allan Sandfeld Jensen authored
Clarify that shown here refers to where they are shown initially. Change-Id: I962fd4b98d80fb1d43e086660fb74eea6b8f532a Reviewed-by:
Laszlo Agocs <laszlo.agocs@theqtcompany.com>
-
Shawn Rutledge authored
configure -no-feature-STATEMACHINE -no-feature-ANIMATION Change-Id: Idb89c0bae8d699e76916317f83490c6c94c7d8b4 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@theqtcompany.com>
-
Friedemann Kleint authored
Fixes compilation with Qt 4. Change-Id: I66781089cd4c07a33f8136706e3211a21f41039f Reviewed-by:
Shawn Rutledge <shawn.rutledge@digia.com>
-
Samuel Gaist authored
ifdef panTouchPoints which is not used on OS X. Otherwise the build fails when the -Werror,-Wunused-function flags are used. Change-Id: I4f5498774905fcb2ba1fae40e41587d5821af8b9 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@theqtcompany.com>
-
Giuseppe D'Angelo authored
Just like the other typedefs; removes the doc warnings. Change-Id: I61142b8db57f4e0cc44cb8c459b1e82e69da3413 Reviewed-by:
Frederik Gladhorn <frederik.gladhorn@theqtcompany.com> Reviewed-by:
Olivier Goffart <ogoffart@woboq.com> Reviewed-by:
Jędrzej Nowacki <jedrzej.nowacki@theqtcompany.com>
-
David Faure authored
sizeHint() did it exactly like this, but minimumSizeHint() didn't, which made it too small. Didn't affect the actual size in most cases since the vertical size policy is fixed, so sizeHint() is called instead. But when writing a subclass, if one re-implements sizeHint() by calling the QLineEdit's minimumSizeHint(), it would then be wrong, when text margins are used. Change-Id: I29ae8dcab00842b3b5ca534cdb250efc0b496f45 Reviewed-by:
Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
-
Shawn Rutledge authored
If you build with configure -DQT_NO_DEPRECATED this will avoid some build errors. Change-Id: If2b2e57b6919091f3f077ebc2aeca0c3fd2421aa Reviewed-by:
Olivier Goffart <ogoffart@woboq.com> Reviewed-by:
Konstantin Ritt <ritt.ks@gmail.com>
-
- 26 Nov, 2014 - 16 commits
-
-
Friedemann Kleint authored
Associate a 0-context with the window if IME is disabled, store this state as a flag to QWindowsWindow. Associate default context again when enabled window gains focus. Task-number: QTBUG-40691 Change-Id: I78d5494a05f93a39e245ca7c096d45445e684ea8 Reviewed-by:
Liang Qi <liang.qi@theqtcompany.com>
-
Friedemann Kleint authored
Add a capability enumeration to QPlatformInputContext and use that to turn off input methods for hidden text depending on platform support. Disable on Windows. Task-number: QTBUG-40691 Change-Id: I9909005de1f21316ec8f64e2729f1fffcd37c7c3 Reviewed-by:
Lars Knoll <lars.knoll@digia.com> Reviewed-by:
Björn Breitmeyer <bjoern.breitmeyer@kdab.com> Reviewed-by:
Liang Qi <liang.qi@theqtcompany.com>
-
Laszlo Agocs authored
As pointed out in 13b939c7 the approach qdevicediscovery_p.h takes is just wrong. The defines it relies on will often be missing when the header is included from random places in qtbase. This results in different class layouts. It was working only because the interface of the class is very limited and the public part was matching regardless of having the macro defined. This is now corrected by introducing subclasses and a common, non-variated base class. QDEVICEDISCOVERY_UDEV is removed completely. Change-Id: I9c83b5b041440a3a6ea3a604eee4a325d4d74439 Reviewed-by:
Louai Al-Khanji <louai.al-khanji@theqtcompany.com> Reviewed-by:
Jørgen Lind <jorgen.lind@theqtcompany.com>
-
Richard Moe Gustavsen authored
The current approach of not activating transient windows with the popup flag set was found to be too restrictive, as it would e.g stop transient dialogs from being able to contain editable controls. This patch will restrict the number of popup types that we skip activation for to only contain a few subtypes. Task-number: QTBUG-41613 Change-Id: I381a5a79fb4f7082da18a6b4e06a7255ff400b1a Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@digia.com>
-
Richard Moe Gustavsen authored
On iOS, autoSIP is handled by the platform plugin. We therefore avoid letting widgets tell the input panel to hide on focus out so we can gain better control over this from the plugin. Note that we could also set QApplicationPrivate::autoSipEnabled to false and achieve the same. But since autoSIP is logically set on iOS, it's better to report it as set in case the app asks. Change-Id: I96c68bc446a1e299fd57afe03a9e273491df08a7 Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@digia.com>
-
Nico Vertriest authored
Task-number: QTBUG-40362 Change-Id: I1cdbde1f6b003556ba4b5e97a49c6d918518da0d Reviewed-by:
Venugopal Shivashankar <venugopal.shivashankar@digia.com> Reviewed-by:
Jerome Pasion <jerome.pasion@digia.com>
-
Alejandro Exojo authored
The enum was made public in f84b00c6 , but this makes it follow the convention to camel case acronyms too before it's too late to change it. Change-Id: Ibb81e9221cb73fe0502d0a26f2d73512dd142f08 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Eskil Abrahamsen Blomfeldt authored
There was an override for Android which would disable the configure error when doing an OpenSSL build without having the headers available. This has several times lead to packaging errors where OpenSSL gets disabled but it's not noticed before the package testing, which delays the process. I'm not 100% sure of the reasoning behind the override, but I think it's a left-over from Necessitas where OpenSSL was statically linked into Qt. Change-Id: I2bdc33fb60c59cd493987959d4bbbbb4e9735a92 Task-number: QTBUG-42851 Reviewed-by:
Frederik Gladhorn <frederik.gladhorn@theqtcompany.com> Reviewed-by:
BogDan Vatra <bogdan@kde.org> Reviewed-by:
Kai Koehne <kai.koehne@theqtcompany.com> Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
-
Richard Moe Gustavsen authored
On iOS 7.1 [UIScreen screens] sometimes (and against documentation) returns an empty array, which will lead to a crash. This patch will add a fallback path that uses [UIScreen mainScreen] instead when the screen count is 0. Task-number: QTBUG-42345 Change-Id: Ie72578ff7ecd0c8fbc971fafea45047bf1347cd9 Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@digia.com>
-
Richard Moe Gustavsen authored
The special-case that was added for OS X before the iOS port came to be stops the virtual keyboard from working correctly. Task-number: QTBUG-41613 Change-Id: I0b8c83e98584389ea4a8aada16a1ee1a64300400 Reviewed-by:
Jake Petroules <jake.petroules@petroules.com>
-
Tony Sarajärvi authored
Task-number: QTBUG-29941 Change-Id: Ieb3418a2d6d88ebd399964b5df20d9fe4d6ca37b Reviewed-by:
Simo Fält <simo.falt@digia.com>
-
Andrew Knight authored
This function is apparently optimized in a way that gives a bad return value (or leaves the variable where it is used uninitialized), leading to extreme memory allocations and eventual heap exhaustion. Task-number: QTBUG-42038 Change-Id: Ia4ee9fc6475a0bf40e25eed356b027a4dc68d119 Reviewed-by:
Maurice Kalinowski <maurice.kalinowski@theqtcompany.com>
-
Jørgen Lind authored
When a popup is opened it grabs the input, but the leave event to the other windows needs to be sent. Remove the popupEnterLeave test as it did not test any code. The Popup never gets any enter or leave events so it will succeed always succeed Task-number: QTBUG-36862 Change-Id: I625c616eeb74b5168af7b751485e2a9a53b76cd3 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@theqtcompany.com> Reviewed-by:
Giuseppe D'Angelo <giuseppe.dangelo@kdab.com> Reviewed-by:
Shawn Rutledge <shawn.rutledge@digia.com>
-
Shawn Rutledge authored
qFind is deprecated, so these cause build errors with configure -no-feature-DEPRECATED Change-Id: Iefcb061d5e8ce256445528f601ead4c9d5d1dfd2 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@theqtcompany.com>
-
Shawn Rutledge authored
so that it can build with configure -no-feature-DEPRECATED Change-Id: Id2decc05974bad249c79936d99ab63d3cfc375ad Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@theqtcompany.com>
-
Shawn Rutledge authored
to support configure -no-feature-CURSOR Change-Id: I8e7f9a7f80d3d44a1f8e25b909d552351b5f37e4 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@theqtcompany.com>
-
- 25 Nov, 2014 - 1 commit
-
-
Friedemann Kleint authored
- Fix prototype for glinfo() for Qt 4 - Add more event types and object type flags to event filter. Change-Id: Ia4160b40486d054e860a339e7b5c9c28695330ae Reviewed-by:
Shawn Rutledge <shawn.rutledge@digia.com> Reviewed-by:
Andy Shaw <andy.shaw@digia.com>
-