- 28 Nov, 2015 - 3 commits
-
-
Lars Knoll authored
De-inline the method, and return the file info that's already being cached by the model. This is ok to do in a minor release, as apps compiled against an older version of Qt will simply continue to use the less efficient implementation. Change-Id: I164c7961a8cf97447638af316512326442767dd8 Task-number: QTBUG-30902 Reviewed-by:
Marc Mutz <marc.mutz@kdab.com> Reviewed-by:
Edward Welbourne <edward.welbourne@theqtcompany.com> Reviewed-by:
Konstantin Ritt <ritt.ks@gmail.com>
-
Marc Mutz authored
For qDebug() and qWarning(), this is just an optimization. For qCritical(), which can be fatal, the old code was just wrong. Change-Id: I6d8ab1d7531d766cd41b49569dc0fd4420ecab8b Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@theqtcompany.com> Reviewed-by:
Olivier Goffart (Woboq GmbH) <ogoffart@woboq.com>
-
Marc Mutz authored
This information is already registered by the QMessageLogger ctor. Where, by dropping the << Q_FUNC_INFO in ostream-style qDebug(), only a string literal remained, converted to printf-style qDebug() on the go. Change-Id: I3f261c98fd7bcfa1fead381a75a82713bb75e6f3 Reviewed-by:
Olivier Goffart (Woboq GmbH) <ogoffart@woboq.com>
-
- 27 Nov, 2015 - 15 commits
-
-
Friedemann Kleint authored
The driver causes crashes when switching orientation in full screen mode. Task-number: QTBUG-49541 Change-Id: I8293d4b2f2981fa627654d06894a74c922304ac3 Reviewed-by:
Laszlo Agocs <laszlo.agocs@theqtcompany.com>
-
Friedemann Kleint authored
In QMenuPrivate::hideMenu(), delay clearing of 'causedPopup.widget' to after the QMenu::close() call, so that it is still accessible in QMenu::hideEvent() which calls QMenuBarPrivate::setCurrentAction(0) if the caused widget is a QMenuBar. Task-number: QTBUG-47377 Task-number: QTBUG-49592 Change-Id: Idbda48e918dae799afea84068a60d7383d7b4971 Reviewed-by:
Marc Mutz <marc.mutz@kdab.com>
-
Friedemann Kleint authored
Change-Id: I5943c6656da93d36e1955ac038bf656831da0c5c Reviewed-by:
Jędrzej Nowacki <jedrzej.nowacki@theqtcompany.com>
-
Friedemann Kleint authored
The platform window geometry can be misleading until it has been properly positioned and QWindowPrivate::resizeEventPending has been cleared. Task-number: QTBUG-49588 Task-number: QTBUG-48396 Change-Id: Ie065f62478fc8522a9ad51391bb897510afa5aad Reviewed-by:
Marc Mutz <marc.mutz@kdab.com>
-
Friedemann Kleint authored
Add a flag to disable rotation to the Renderers enumeration of QWindowsOpenGLTester triggered by the keyword "disable_rotation". Specifying this keyword forces the application to landscape mode for Desktop GL. It is intended for drivers that have issues with rotation. Task-number: QTBUG-49541 Change-Id: I0f0bb7415c59e98648be09b34a59dd201d52b211 Reviewed-by:
Laszlo Agocs <laszlo.agocs@theqtcompany.com>
-
Friedemann Kleint authored
Dynamically load the Win32 API functions for setting the rotation preference and map this to static functions taking a Qt::ScreenOrientation in QWindowsScreen. Task-number: QTBUG-49541 Change-Id: I1c81cf6274d79a023a2ee755dd7c085ffd7cc015 Reviewed-by:
Laszlo Agocs <laszlo.agocs@theqtcompany.com>
-
Marc Mutz authored
Remove unused ctors and dtor, add Q_OBJECT, indent, privatize slots, don't check for nullptr before delete'ing a pointer, and add one override keyword. Setting test_box (a QPointer) to nullptr is already done by the variable's default ctor. Change-Id: I13f06dc8104ef1c0ac08a25c960641c076f10499 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@theqtcompany.com>
-
Liang Qi authored
-
Joerg Bornemann authored
Do not iterate separately over all header files. This removes duplicated header iteration code which already was out of sync. As a side-effect, we do run the header check only on header files that are considered part of the module, if moduleheaders is set in sync.profile. Change-Id: Iec4c8febe9128139d2f377a1da8ce08c24110a77 Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
-
Joerg Bornemann authored
Another step towards the removal of the duplicated loop over header files. Change-Id: I542782627d8742a515a42034264e4569a2355823 Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
-
Joerg Bornemann authored
Turn lists into hashes and check for existence of an element using key lookup. This leads to simpler testing code and is potentially faster. Change-Id: Ibbf4f03ec64d6c295cc5e1664dfa73cd0ce8c272 Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
-
Friedemann Kleint authored
Output function, object name and class of the socket. Example: qt.winrtrunner.app: handleReadyRead(): Could not read into socket stream buffer ("QTcpServer:40000"/QTcpServer). (A method was called at an unexpected time.) Change-Id: Ic074c2c3a01221bd77dae0715db912e830f21435 Reviewed-by:
Oliver Wolff <oliver.wolff@theqtcompany.com>
-
Friedemann Kleint authored
Replace hardcoded interval by QTRY_COMPARE() ensuring that all tasks have finished, since otherwise QThreadPool::tryStart() fails in the next run. Remove blacklisting for MSVC2012 since it is not compiler-specific. Task-number: QTBUG-49654 Change-Id: If49b6eb9ef4da4ba2911839166c397d84c175e00 Reviewed-by:
Simon Hausmann <simon.hausmann@theqtcompany.com> Reviewed-by:
Jędrzej Nowacki <jedrzej.nowacki@theqtcompany.com>
-
Joni Poikelin authored
Warning about connecting to null object was printed when bearer plugin is missing when bearer management feature is enabled. Change-Id: Iac33081c5f301862c066eb69ec05ff6d95775c09 Reviewed-by:
Markus Goetz (Woboq GmbH) <markus@woboq.com>
-
Liang Qi authored
Conflicts: src/network/socket/qnativesocketengine_p.h src/network/ssl/qsslsocket_mac.cpp src/network/ssl/qsslsocket_mac_p.h src/widgets/kernel/qwidget.cpp Change-Id: I39592cb37d710dfaf8640769ba3c1b637927d7f4
-
- 26 Nov, 2015 - 17 commits
-
-
Laszlo Agocs authored
In some configurations we may end up using Mesa's EGL headers instead of the Broadcom ones. Make this work by setting the usual define to prevent including Xlib headers that then conflict with all sorts of things in QtCore. Change-Id: I4970553428e5b0e81bd76694980f3b6b194ae4c2 Reviewed-by:
Andy Nichols <andy.nichols@theqtcompany.com>
-
Oswald Buddenhagen authored
longer term, the redundant .dlls from the libdir will hopefully disappear. short term, this is a workaround for CI brokenness. Change-Id: Ia30173355f3aca222d4ca40e7a38c2cf535bbc03 Reviewed-by:
Joerg Bornemann <joerg.bornemann@theqtcompany.com>
-
Oswald Buddenhagen authored
amends 967372c9 . Change-Id: I898950d6847e43d565748cd8d1ea583cf5ca5c9d Reviewed-by:
Jake Petroules <jake.petroules@theqtcompany.com> Reviewed-by:
Eike Ziller <eike.ziller@theqtcompany.com>
-
Oswald Buddenhagen authored
Change-Id: I2b7d95c004ce045527b124ef25b6d224535c895b Reviewed-by:
Joerg Bornemann <joerg.bornemann@theqtcompany.com>
-
Allan Sandfeld Jensen authored
Since AArch64 NEON assembly is different from Arm32 NEON we need to write a separate version. Assembly is used over intrinsics as the intrinsics have trouble efficiently using the vstX and vldX instructions. Change-Id: I5b67fc87acb2433b503e658099b742d57a9cff18 Reviewed-by:
Erik Verbruggen <erik.verbruggen@theqtcompany.com>
-
Robin Burchell authored
As these are strongly typed, they won't implicitly convert to int, so make sure to cast explicitly. (cherry picked from commit 9626baae , auto test is not included) Task-number: QTBUG-49597 Change-Id: I29c4331a9b0c61f2e60c2bcab5a99f65daa7060f Reviewed-by:
Olivier Goffart (Woboq GmbH) <ogoffart@woboq.com>
-
Friedemann Kleint authored
Ensure the test works in a working directory with read-only permission and that the file names are unique. The test can then be executed repeatedly by COIN even in case left-over hanging process helpers still lock the files. Also disambiguate the "data" files used by various tests. Task-number: QTBUG-47370 Change-Id: I3b9c7b70828da78f400196fcbba27bc61ea4538f Reviewed-by:
Jędrzej Nowacki <jedrzej.nowacki@theqtcompany.com>
-
Volker Krause authored
Speeds up application startup by a few percent, even with just a normal amount of fonts installed. Change-Id: I4c3d87119ddbc53e66166f21cb72946cdf7e4a41 Reviewed-by:
Olivier Goffart (Woboq GmbH) <ogoffart@woboq.com> Reviewed-by:
Konstantin Ritt <ritt.ks@gmail.com>
-
Friedemann Kleint authored
Introduce constants and make the interval for the 2nd thread a bit longer. Task-number: QTBUG-49653 Change-Id: I92ac0494ec6c9af5bde858007d08e26210215434 Reviewed-by:
Joerg Bornemann <joerg.bornemann@theqtcompany.com>
-
Friedemann Kleint authored
Introduce a base class for the threads that ensures termination in the destructor to ensure all QThreads instantiated on the stack are terminated. This should reduce crashes since the test thread classes have pointers to stack variables of the test slots. Set object names on the threads for better diagnostics. Decouple wakeOne()/wakeAll() that impact each other via the static count variables of the thread class by introducing a base class WakeThreadBase keeping a pointer to an QAtomicInt count variable on the stack instead (similar to the existing pointers to the mutexes, etc). Task-number: QTBUG-49653 Change-Id: I73537386bf36019efa81e8e24ba9af92506f7794 Reviewed-by:
Frederik Gladhorn <frederik.gladhorn@theqtcompany.com>
-
Ilya Kotov authored
QSystemTrayIcon's window should send QEvent::ToolTip to QSystemTrayIcon main class under X11. This patch fixes regression inroduced in Qt 5.0. Change-Id: I81f6d85e13f492e5e7d13dacc44185a511e5085d Task-number: QTBUG-46130 Reviewed-by:
Błażej Szczygieł <spaz16@wp.pl> Reviewed-by:
Laszlo Agocs <laszlo.agocs@theqtcompany.com>
-
Allan Sandfeld Jensen authored
The __ARM_NEON is the standard define for NEON instructions support __ARM_NEON__ is only legacy, and specifically not defined in AArch64 builds, which causes us not to detect NEON support there. The NEON assembler files doesn't build with AArch64, so the NEON drawhelper methods must be excluded for now. Change-Id: Ie32f855bde94ee7efd8a8ddb7766c931778e729b Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Tor Arne Vestbø authored
The xcodebuild tool only supports the install action for devices, not for the iOS simulator platform. Change-Id: I47e8bb7d44962bd4a433a314fa9d315ed3683ca6 Reviewed-by:
Richard Moe Gustavsen <richard.gustavsen@theqtcompany.com>
-
Nicolas Capens authored
In a Chrome Remote Desktop session the htotal and/or vtotal timings can be zero and lead to a SIGFPE exception. Task-number: QTBUG-49322 Change-Id: Id530335cc760d1938ed888ad095427fcf32c651d Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com> Reviewed-by:
Nicolas Capens <nicolas.capens@gmail.com> Reviewed-by:
Gatis Paeglis <gatis.paeglis@theqtcompany.com>
-
Laszlo Agocs authored
The ifdef gave an impression of the code path being hit only when texture-backed widgets are present and OpenGL-based compositing is active. This is false. Asserting on having a context current is wrong (as shown by autotests on the 5.6 branch). Change-Id: I2539f0aac75b26597f49f63edcd9580428be79b7 Reviewed-by:
Gunnar Sletta <gunnar@sletta.org>
-
Tor Arne Vestbø authored
As 3D touch can be disabled/enabled at runtime on those devices, we need to watch for changes to the relevant settings and update the touch device capabilities that we report to the user. Note that iOS will deliver touchesBegan with a touch force of 0, which we will reflect/propagate as a 0 pressure, but there is no clear alternative, as we don't want to wait for a touchedMoved before sending a touch press event to Qt, just to have a valid pressure. Change-Id: I47fb8a9f98ab3244e16a337bbfcf1fe24e4c7aa2 Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@theqtcompany.com>
-
Allan Sandfeld Jensen authored
We test that inline conversion between same image depths always succeed inline, but that requires that any direct conversions exists both in non-inline and inline versions. This patch adds a non-sse2 inline conversion from ARGB32 to ARGB32PM which was missing. Change-Id: I71937cd4b77fb41fe2064da937f6dcbf2a6534e6 Reviewed-by:
Gunnar Sletta <gunnar@sletta.org>
-
- 25 Nov, 2015 - 5 commits
-
-
Friedemann Kleint authored
Change-Id: I4c0baeaf01f0b3d6162a16ef7fda822f5a4cb1db Task-number: QTBUG-49511 Reviewed-by:
Joerg Bornemann <joerg.bornemann@theqtcompany.com>
-
Friedemann Kleint authored
It was used to verify waitForFinished() and printed QProcess::errorString() on failure, which is misleading, since the process is not in an error state - it is still running. Example: QWARN : tst_QProcess::setStandardOutputFileAndWaitForBytesWritten() QProcess error: 5: Unknown error FAIL! : tst_QProcess::setStandardOutputFileAndWaitForBytesWritten() 'ret' returned FALSE. () Use a plain QVERIFY instead. Task-number: QTBUG-47370 Change-Id: Iacfa6e1a5ffd2be4e1257a27a400ccc59671e8c8 Reviewed-by:
Jędrzej Nowacki <jedrzej.nowacki@theqtcompany.com>
-
Friedemann Kleint authored
Silence warning: Don't know how to handle 'hint', use qRegisterMetaType to register it. Task-number: QTBUG-49623 Change-Id: Iec0a823c7af87eddd9a3f126a1b970da1ff2f03f Reviewed-by:
Olivier Goffart (Woboq GmbH) <ogoffart@woboq.com>
-
Friedemann Kleint authored
Don't know how to handle 'hint', use qRegisterMetaType to register it. becomes: QSignalSpy: Unable to handle parameter 'hint' of type 'QAbstractItemModel::LayoutChangeHint' of method 'layoutChanged', use qRegisterMetaType to register it. Task-number: QTBUG-49623 Change-Id: I5020bb5b6f4ba87438d0f862279bed1ceb203d12 Reviewed-by:
Olivier Goffart (Woboq GmbH) <ogoffart@woboq.com>
-
J-P Nurmi authored
0e99f3c8 broke tst_qquicktextinput::horizontalAlignment_RightToLeft() and tst_qquicktextedit::hAlign_RightToLeft(). This fix was proposed by Konstantin. Change-Id: I602b7301d415f266224ae2c1ffd81244e9565862 Reviewed-by:
Simon Hausmann <simon.hausmann@theqtcompany.com> Reviewed-by:
Lars Knoll <lars.knoll@theqtcompany.com>
-