Skip to content
Snippets Groups Projects
  1. Jun 14, 2016
  2. Jun 13, 2016
    • James McDonnell's avatar
      Fix cast warnings when pthread_t is smaller than a pointer · e969e6d2
      James McDonnell authored
      
      Push conversions from pthread_t to Qt::HANDLE and back into functions.
      The casts that were being used didn't work for the unusual 64-bit
      pointer/32-bit int combination that QNX is using for 7.0.  HANDLE ends
      up as a 64-bit pointer and pthread_t ends up as a 32-bit integer.  g++
      considers the precision loss when converting from the 64-bit pointer
      to the 32-bit integer an error.  Better to have the casts hidden in
      functions so it's easier to adjust them for unusual combinations such
      as this.
      
      Change-Id: Ia156b26224a0f7edc1c31e3d1ee8b21191381698
      Reviewed-by: default avatarThiago Macieira <thiago.macieira@intel.com>
      e969e6d2
    • Maurice Kalinowski's avatar
      winrt: Fix potential crash in QCoreApplication · 27e94bd9
      Maurice Kalinowski authored
      
      GetModuleFileName exists for Windows 10 and upwards, hence use the
      generic version from the win32 mkspec. This allows to create a
      QCoreApplication object with nullptr argv, as the application filename
      is identified via the binary itself and not via arguments. A couple of
      auto-tests use this method to create multiple application objects during
      runtime.
      
      Unfortunately we cannot apply this for msvc2013, even though MSDN states
      the GetModuleFileName exists, it fails to compile for Windows Phone 8.1.
      
      Change-Id: I2b8b988107487ef3785462f8ca40b0a6e0623e32
      Reviewed-by: default avatarThiago Macieira <thiago.macieira@intel.com>
      Reviewed-by: default avatarOliver Wolff <oliver.wolff@qt.io>
      27e94bd9
    • Maurice Kalinowski's avatar
      winrt: Close IAsyncInfo manually in case of error · 038c57f4
      Maurice Kalinowski authored
      
      In case QEventDispatcherWinRT::runOnXamlThread returns an error the
      runtime sets the status of IAsyncInfo to Error. At the point when the
      IAsyncInfo destructor is invoked, an unhandled exception is thrown
      indicating the error has not been handled, causing any application to
      just crash deep inside the Windows platform libraries.
      
      Hence, in case runOnXamlThread returns non-S_OK we have to manually
      invoke Close() of the IAsyncInfo to tell the system we have taken care
      of everything.
      
      Change-Id: I3ac1e2ec2726f42e44f4f9a92191e454711120dd
      Reviewed-by: default avatarOliver Wolff <oliver.wolff@qt.io>
      038c57f4
    • Maurice Kalinowski's avatar
      winrt: Add privateNetworkClientServer to default capabilities · 3394d97e
      Maurice Kalinowski authored
      
      Contrary to our initial assumption, this should be added by default to
      allow full functionality during development by default. Developers need
      to decide which capabilities to use during the publishing step already,
      hence improve DX by adding this.
      
      Task-number: QTBUG-50847
      Change-Id: I36e0214f7bcf8610d31851eea172aba3944cfd99
      Reviewed-by: default avatarOliver Wolff <oliver.wolff@qt.io>
      Reviewed-by: default avatarFriedemann Kleint <Friedemann.Kleint@qt.io>
      3394d97e
    • Oliver Wolff's avatar
      WinRT: Avoid asserts in socket function with bool return values · 6fa74764
      Oliver Wolff authored
      
      There is no need for the functions to assert. By returning false they
      show that something went wrong and the error will be handled
      gracefully.
      
      Change-Id: Ib026adf5c6fb23b5e6b5598533caec3b3669220c
      Reviewed-by: default avatarMaurice Kalinowski <maurice.kalinowski@qt.io>
      6fa74764
    • Oliver Wolff's avatar
      WinRT: fixed error reporting of QNativeSocketEngine::initialize · c111abe0
      Oliver Wolff authored
      
      If runOnXamlThread returns anything but S_OK an exception is thrown
      which might cause the application to terminate. So we give the lambda
      a reference to hr and check that reference instead of runOnXamlThread's
      return value for errors.
      
      Change-Id: I1188ea720c63f6fdf43400f2f3ff928b72afc58e
      Reviewed-by: default avatarMaurice Kalinowski <maurice.kalinowski@qt.io>
      c111abe0
    • Oliver Wolff's avatar
      WinRT: Proper error handling in socket engine's "bind" · 0f6ededb
      Oliver Wolff authored
      
      runOnXamlThread should always return S_OK (causes exceptions otherwise)
      so we need another way of error reporting to the outside (hr reference).
      A failed hr is reported to the outside (of the lambda) and interpreted
      as an unknown error.
      
      Specific error cases like the given address not being a local address
      or the given address being in use already are handled inside the lambda.
      The specificErrorSet variable is necessary in these cases so that the
      error is not overwritten by unknownError.
      
      Change-Id: I198d66fe97726d5127bf31e50c7eff3363d5259c
      Reviewed-by: default avatarMaurice Kalinowski <maurice.kalinowski@qt.io>
      0f6ededb
    • James McDonnell's avatar
      Move __cpp_constexpr check inside Q_COMPILER_CONSTEXPR check · d4e98a9a
      James McDonnell authored
      Q_COMPILER_CONSTEXPR can be undefined (or not defined at all) to
      indicate that constexpr should not be used regardless of the compiler's
      ability to support it.  This is done for QNX because some C library
      floating point functions used in the Dinkumware C++ library aren't
      constexpr functions; i.e., the library doesn't have proper constexpr
      support even though the compiler does.
      
      (cherry picked from commit d8724296
      
      )
      Change-Id: If0bdeb2180710dd9ccd97d79fa91cf9ff42f7990
      Reviewed-by: default avatarThiago Macieira <thiago.macieira@intel.com>
      d4e98a9a
  3. Jun 11, 2016
  4. Jun 10, 2016
  5. Jun 08, 2016