- Oct 31, 2018
-
-
Samuli Piippo authored
If QT_QPA_EGLFS_HIDECURSOR was enabled, m_deviceListener was never initialized, which caused segfault in the destructor. Task-number: QTBUG-71507 Change-Id: Id8b17f5312073249cd12995317213fd746753521 Reviewed-by:Laszlo Agocs <laszlo.agocs@qt.io>
-
- Oct 30, 2018
-
-
Andy Nichols authored
When we try to gracefully destroy a QOpenGLVertexArrayObject it is not possible to create an QOffscreenSurface from a thread that is not the GUI thread. In this case we just need to bail out instead. The side effect that was seen previously was that there would be a warning and a deadlock on Windows when closing QQuickWindows that contained a QQuickPaintedItem backed by a FrameBufferObject render target (which would be using the OpenGL paint engine) when using the threaded render loop. Task-number: QTBUG-70148 Change-Id: I4a20d74d9af850bb90d243212ad9f65c3fc9e616 Reviewed-by:Laszlo Agocs <laszlo.agocs@qt.io>
-
- Oct 29, 2018
-
-
Thiago Macieira authored
QPointer uses QWeakPointer / QSharedPointer internals in QObject and has the code to make sure two threads won't stomp on each other if both try to create a QPointer for the same QObject at the same time. The threading code was fine, but had a mistake in the clean up code for the loser thread: the QtSharedPointer::ExternalRefCountData destructor has a Q_ASSERT for the state of the reference counts. So we need to set the state correctly before calling the destructor. But we don't want to do it in case the Q_ASSERT compiled to nothing. So we use a hack that violates the Second Rule of Q_ASSERTs: don't do something with side-effects. This way, we can insert code that will only be compiled if Q_ASSERTs do something, without having to duplicate the preprocessor conditions from qglobal.h. Fixes: QTBUG-71412 Change-Id: I1bd327aeaf73421a8ec5fffd1560fdfc8b73b70c Reviewed-by:
Romain Pokrzywka <romain.pokrzywka@gmail.com> Reviewed-by:
Jędrzej Nowacki <jedrzej.nowacki@qt.io>
-
Błażej Szczygieł authored
"xcb_randr_get_screen_info" can be slow and in some configurations can cause short mouse cursor freezes (which will happen on Qt application startup). Initial screen rotation was used only to not handle possible redundant screen change event. Fixes: QTBUG-70760 Change-Id: I9f01325a045d2c82c4dd2fce91a18a34e54a4bcd Reviewed-by:Gatis Paeglis <gatis.paeglis@qt.io>
-
- Oct 25, 2018
-
-
Kirill Burtsev authored
Fixes: QTBUG-52279 Change-Id: I4f40fc9d3ce938b4c821f10cacd21e6f652a2227 Reviewed-by:Shawn Rutledge <shawn.rutledge@qt.io>
-
Tor Arne Vestbø authored
We want to inform the user when they have upgraded their Xcode version and hence have a new SDK version, which requires a complete rebuild. Explicit changes to the Xcode selection (be it via xcode-select or $DEVELOPER_DIR) do not affect the existing build directory, so we must record the Xcode selection inside the build to avoid false triggering. Change-Id: I7d13da1232226712a4951e8a360cf4b634c6fa2f Reviewed-by:Oswald Buddenhagen <oswald.buddenhagen@qt.io>
-
- Oct 24, 2018
-
-
Andy Shaw authored
If a tooltip was shown on an application modal dialog then it would end up blocking mouse events to the dialog while the tooltip was visible. Since tooltips are special in this case, they should not cause mouse events to be blocked. Fixes: QTBUG-65599 Change-Id: Ibf1729ca4942f5854e4f9687c5586382e23c1c31 Reviewed-by:Richard Moe Gustavsen <richard.gustavsen@qt.io>
-
- Oct 23, 2018
-
-
Michael Brüning authored
The AMD FirePro dual gpus on the Mac Pro have a problem with offline renderers in Chromium. Therefore, Chromium and thus Qt WebEngine disable this option via the pixel format attributes. The Qt Cocoa plugin on the other hand enables it in the recent versions, causing context creation in Qt WebEngine to fail when run on a Mac Pro with dual AMD FirePro gpus due to incompatible context options. This patch uses the environment variable QT_MAC_PRO_WEBENGINE_WORKAROUND which is set by Qt WebEngine upon application startup if the application is running on a late 2013 Mac Pro. It should typically not be set from anywhere else. [ChangeLog] Offline renderers will be disabled when the application is using Qt WebEngine and running on one of the late 2013 Mac Pro models. Fixes: QTBUG-70062 Change-Id: I0b0831efb6f4073ebd37672040aaed6370853fc0 Reviewed-by:Tor Arne Vestbø <tor.arne.vestbo@qt.io>
-
- Oct 22, 2018
-
-
Arnaud Bienner authored
Change-Id: I987a4129968e9af74e21a2d855c4576a9caada73 Reviewed-by:Friedemann Kleint <Friedemann.Kleint@qt.io>
-
- Oct 19, 2018
-
-
Giuseppe D'Angelo authored
Some Linux distributions patch OpenSSL's soname, making builds on such distributions not deployable elsewhere. The problem is that the code loading OpenSSL symbols would attempt to use the soname of the build machine, and therefore not finding the OpenSSL libraries on the deploy system. The binary builds of Qt for Linux are affected by this problem, as they build under RHEL7.4 which changes to soname of OpenSSL to a non-standard string. This makes the binary builds not pick up OpenSSL 1.0 from the machine where the build gets installed on. Given that in the pre-1.1 versions only the 1.0 series is supported, bump the minimum requirement of Qt to that. The 1.0.x releases (up to 1.0.2, at the time of this writing) have kept binary compatibility, and advertise a soname of "1.0.0", which is used by most distributions. So, if loading of OpenSSL with the build-time soname fails, try to load them with the "1.0.0" hardcoded soname. [ChangeLog][QtNetwork][SSL] OpenSSL >= 1.0 is now required to build Qt with OpenSSL support. Task-number: QTBUG-68156 Change-Id: Ieff1561a3c1d278b511f09fef06580f034f188c6 Reviewed-by:Timur Pocheptsov <timur.pocheptsov@qt.io>
-
Thiago Macieira authored
The event dispatcher can be null already but we may have outstanding QWinEventNotifier objects (like in a QProcess). Patch-By: Tamas Karpati Task-number: QTBUG-70214 Change-Id: I5e432e273def425ea334fffd154f34abfd6cb11a Reviewed-by:Friedemann Kleint <Friedemann.Kleint@qt.io>
-
- Oct 18, 2018
-
-
Giuseppe D'Angelo authored
[ChangeLog][Third-Party Code] PCRE2 was updated to version 10.32. Change-Id: Id3bf7df0003f626cd1135d0508a5a489ff02f1e5 Reviewed-by:Edward Welbourne <edward.welbourne@qt.io>
-
Eirik Aavitsland authored
A file with the correct QPicture magic bytes, but shorter than a full QPicture file header, could cause the header decoder to access memory out of bounds. Add a size check to avoid. As a driveby, generally harden the parsing against malformed files. [ChangeLog][QtGui][QPicture] Fix crash reading malformed picture file Task-number: QTBUG-71208 Change-Id: I86eb1f915ca9b3a4b91c7433036d76ed6061e2f0 Reviewed-by:Lars Knoll <lars.knoll@qt.io>
-
Thiago Macieira authored
Commit b7887f9b removed this explicit disabling because it shouldn't be needed anymore. Turns out it was, as new Android SDK do include modern Linux headers and those define the structs and constants needed for statx(). Repeat of 8eb3944d . Task-number: QTBUG-64490 Fixes: QTBUG-71200 Change-Id: If7e743cf8476463880ccfffd155e6d5c2b5a3da9 Reviewed-by:
Simon Hausmann <simon.hausmann@qt.io> Reviewed-by:
BogDan Vatra <bogdan@kdab.com>
-
- Oct 17, 2018
-
-
Andy Shaw authored
Removing the extra space before -MT ensures that the vcxproj generator gets valid input. Change-Id: Iccf88c5fc4473db406d714b646185a4fb60a3418 Reviewed-by:Oswald Buddenhagen <oswald.buddenhagen@qt.io>
-
- Oct 16, 2018
-
-
Allan Sandfeld Jensen authored
The script taken here is a QChar::Script, not a QFontDatabase::WritingSystem. This means it was passing QChar::Unknown. Change-Id: I919ae7187ba277346a7719116a94776dce24dd84 Reviewed-by:Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>
-
Eirik Aavitsland authored
The pdf engine uses a resource file, but Q_INIT_RESOURCE() was lacking. Task-number: QTBUG-71070 Change-Id: I685961b3f2eea0ffe6b5313c72d504a8ad9a98e5 Reviewed-by:Lars Knoll <lars.knoll@qt.io>
-
- Oct 12, 2018
-
-
Thiago Macieira authored
Those system calls are present in glibc 2.28. Instead of using syscall(3) to place the system calls directly, let's use only the glibc functions. That also means we no longer accept ENOSYS from either function, if they were detected in glibc. Change-Id: I44e7d800c68141bdaae0fffd1555b4b8fe63786b Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@qt.io> Reviewed-by:
Lars Knoll <lars.knoll@qt.io> Reviewed-by:
Jüri Valdmann <juri.valdmann@qt.io>
-
Liang Qi authored
Change-Id: I9b67c2cbc0891a38ece18d521c86fbc7344dce7a Reviewed-by:
Edward Welbourne <edward.welbourne@qt.io> Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@qt.io>
-
Liang Qi authored
Change-Id: Idee19112581bff64a2e0b8e331dd3d779aca165b Reviewed-by:
Edward Welbourne <edward.welbourne@qt.io> Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@qt.io>
-
Liang Qi authored
Change-Id: Ic23f4a1f81a21711cd81aaa2942b493aca5b38b8 Reviewed-by:
Edward Welbourne <edward.welbourne@qt.io> Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@qt.io>
-
Liang Qi authored
Change-Id: Ibc164b3df3cf87db569ef4813de458a9067b7f7d Reviewed-by:
Edward Welbourne <edward.welbourne@qt.io> Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@qt.io>
-
Kai Koehne authored
Change-Id: I67d06eae963c7fbbbbf13c5f9ab1195cbc5d7eb1 Reviewed-by:Oswald Buddenhagen <oswald.buddenhagen@qt.io>
-
Eirik Aavitsland authored
The remaining diff to clean 1.6.35 is archived in the qtpatches.diff file. [ChangeLog][Third-Party Code] libpng was updated to version 1.6.35 Change-Id: I925b3d95f6da20e12fc3274b4713e3fea05094f7 Reviewed-by:
Kai Koehne <kai.koehne@qt.io> Reviewed-by:
Liang Qi <liang.qi@qt.io>
-
Andy Shaw authored
Change-Id: Ia8d9e543fac4b6e790fa38cf04c5a782d72d72df Reviewed-by:
Eirik Aavitsland <eirik.aavitsland@qt.io> Reviewed-by:
Gatis Paeglis <gatis.paeglis@qt.io>
-
Paul Olav Tvete authored
According to the Khronos documentation, gbm_surface_create() will give a BAD_MATCH error if the format does not match the EGL_NATIVE_VISUAL_ID. Newer drivers have started to enforce this. Change-Id: I61360b0f52965ad8057e7de8f824ffca64fea904 Reviewed-by:
Laszlo Agocs <laszlo.agocs@qt.io> Reviewed-by:
Dominik Holland <dominik.holland@pelagicore.com>
-
- Oct 10, 2018
-
-
Mårten Nordheim authored
If you, directly after connecting, call "ignoreSslErrors()" followed by "resume()" then you will most likely crash. It is very contrived and there's no reason to do this. Change-Id: I949a303238f5012296d0e84eb76173764eb9de2e Reviewed-by:Timur Pocheptsov <timur.pocheptsov@qt.io>
-
- Oct 09, 2018
-
-
Edward Welbourne authored
It has had some changes and should be kept up to date. Fixes: QTBUG-70386 Task-number: QTBUG-70852 Change-Id: I868a558811c34cf5a800c3087a0ca96e7fb49b1a Reviewed-by:
Mårten Nordheim <marten.nordheim@qt.io> Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
- Oct 08, 2018
-
-
Alexandru Croitor authored
Modal sheets are supposed to appear below the toolbar if a toolbar exists, or below the title bar if a toolbar doesn't exist. In the unified title and toolbar mode, sheets should to appear directly below the toolbar, if the toolbar is positioned at the top of the window. Code-wise we achieve that by calling setUnifiedTitleAndToolBarOnMac on a QMainWindow, which results in adjusting the top content border of the NSWindow via [NSWindow setContentBorderThickness:forEdge], which Cocoa uses to position a modal sheet (the sheet top edge is aligned with the top edge of the content view + the Y border thickness value). The issue is that because NSWindow.titlebarAppearsTransparent is set to YES, for sheet presentation purposes, Cocoa considers the content view to begin at the position of the top left corner of the frame (where the title bar is), and thus sheets appear somewhere in the middle of the unified toolbar. To fix that we need to account for the title bar height in the border thickness value. Compute the title bar height from the window frame height - window content view height, and add it to the top border thickness value. Amends 8ac9addd Change-Id: Icf85c513035cc3710b438e60eb14dc04c5bbaced Fixes: QTBUG-65451 Reviewed-by:
Morten Johan Sørvig <morten.sorvig@qt.io>
-
- Oct 06, 2018
-
-
Sergio Martins authored
http://dejavu-fonts.org is something else nowadays Change-Id: Idb03b864fb145b016ce4ae1a2f0df02ff80280a8 Reviewed-by:
Rolland Dudemaine <rolland.dudemaine@esol.com> Reviewed-by:
Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
-
- Oct 05, 2018
-
-
Sergio Martins authored
qabstractitemmodeltester.cpp:223:31: internal compiler error: in expand_expr_real_1, at expr.c:9170 Change-Id: I098c1bdf706512c91c649205f4675de0ca374227 Reviewed-by:David Faure <david.faure@kdab.com>
-
- Oct 04, 2018
-
-
Leena Miettinen authored
In iOS, the system certificates cannot be accessed, so this function will return an empty list for the default configuration. Task-number: QTBUG-60407 Change-Id: I0d691a0dd5e6367594e71c7ebccfbdc866d4a3f0 Reviewed-by:
Edward Welbourne <edward.welbourne@qt.io> Reviewed-by:
Andy Shaw <andy.shaw@qt.io>
-
- Oct 02, 2018
-
-
Friedemann Kleint authored
The message is not sent to the QAbstractEventDispatcher, so it needs to be excluded from the list of input messages not sent to QAbstractNativeEventFilter. Amends a0a22037 . Fixes: QTBUG-70873 Change-Id: Id84d73b46e8954867c06a4ddf5dc9e536ecd897e Reviewed-by:
Oliver Wolff <oliver.wolff@qt.io>
-
Andy Shaw authored
There is no advantage to using repaint() here, so using update will give a performance improvement. Change-Id: Icc6a28dfc12dffb8ea3df0300fd14c66c775bf16 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@qt.io> Reviewed-by:
Richard Moe Gustavsen <richard.gustavsen@qt.io>
-
Edward Welbourne authored
When a time-zone does a spring-forward, skipping an hour (either to start DST or to move its standard time), there's an hour that doesn't exist on the day in question. That hour can be the first hour of the day, in which case using 0:0 as the default time is broken. So catch this case and use the first time that day that makes sense. Fixes: QTBUG-70823 Change-Id: I23dae9320a3cdd2c988841a7db1b111edb945730 Reviewed-by:Thiago Macieira <thiago.macieira@intel.com>
-
Edward Welbourne authored
QTimeZonePrivate::dataForLocalTime()'s handling of times in a spring-forward gap added offsets in seconds to values in milliseconds. Supply the missing factor of a thousand. Change-Id: Ic32d87675f902e1c7fd85025fb70c8272a4f2db2 Reviewed-by:Thiago Macieira <thiago.macieira@intel.com>
-
Kai Koehne authored
Follow spelling convention at https://spdx.org/licenses/Zlib.html Change-Id: Ib25b98cf7f3a052ec25ba6924748a962733e2ed8 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@qt.io>
-
- Sep 30, 2018
-
-
Andrew O'Doherty authored
When viewing "Supported HTML Subset" documentation in Qt Creator (in QTextBrowser), the first table that lists all tags is quite unreadable (see images). It happens because there is a code snippet in Comment column for tag "meta" that uses pre-formatted text. Because it should not be wrapped automatically, it ends up pushing first 2 columns into their minimum size, which mostly makes them take a single letter per row. Task-number: QTBUG-64126 Change-Id: I08bf6f61806d52e7a2f47bdbed1b5950825ce739 Reviewed-by:Leena Miettinen <riitta-leena.miettinen@qt.io>
-
- Sep 29, 2018
-
-
Thiago Macieira authored
QUrl::RemoveAuthority is RemoveUserInfo | RemovePort | 0x10, so the condition if (options & QUrl::RemoveAuthority) would match if any of the other bits for the username, password or port were set, which meant we would skip the host comparison. Ditto for username and RemovePassword. [ChangeLog][QtCore][QUrl] Fixed a bug that caused QUrl::matches to incorrectly compare two URLs with different hostnames or different usernames as equal, if certain QUrl::RemoveXxx options were passed. Change-Id: I015970a03b874898bba7fffd155856ab9d6cb1be Fixes: QTBUG-70774 Reviewed-by:Mårten Nordheim <marten.nordheim@qt.io>
-
- Sep 28, 2018
-
-
Alexander Akulich authored
Before this change we inserted newline only if an option has a description and ended up with an arbitrary long line with all options. [ChangeLog][QtCore][QCommandLineParser] Fixed a bug that caused the help output to show two options or more in the same line if the options didn't have a description. Task-number: QTBUG-70174 Change-Id: Id54b9ae13ee596869e4dc14e09301aea19eed2f8 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@qt.io> Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-