- 23 Jan, 2018 - 2 commits
-
-
Martin Storsjö authored
sljit, the JIT in pcre2, doesn't quite fully work on windows on arm yet (although the subset of functionality used by pcre2 might mostly work). On arm64, it fails to compile (although working around that failure is pretty easy), when using clang in MinGW mode (where __GNUC__ is defined, making the JIT auto-enabled). Disable it in these configurations until it has been fully tested and fixed upstream first. Change-Id: Ie9681cb7cdd1960586ba194c71e057eb918cb419 Reviewed-by:
Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
-
Friedemann Kleint authored
Correctly scale the requested geometry in the constructor of QWindowSystemInterfacePrivate::GeometryChangeEvent(). Amends 3a31c708 . Task-number: QTBUG-57608 Task-number: QTBUG-65580 Change-Id: I0ef60deda69bb61ab57972e02c342b7773e1da6b Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@qt.io>
-
- 22 Jan, 2018 - 3 commits
-
-
Alexander Shevchenko authored
mingw-w64 toolchain: - remove 'QMAKE_CFLAGS_AESNI' and 'QMAKE_CFLAGS_SHANI' definitions, which are already set in 'gcc-base.conf' toolchain; this is a continuation of 77347a36 relating variables, introduced in 5.10, - remove 'gcc-base.conf' duplicate inclusion, left after eef2d1af was merged into 5.10. Change-Id: I328def916ccfb93c3f6b8336eb8801defbac37ae Reviewed-by:
Kai Koehne <kai.koehne@qt.io> Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@qt.io>
-
Jeremy LUGAGNE authored
Change-Id: Ie7a2ff0e42131afef1bdec853d09c3b447f9748c Reviewed-by:
Sérgio Martins <sergio.martins@kdab.com>
-
Oliver Wolff authored
Task-number: QTBUG-65735 Change-Id: I7e0d19de4ac92603f2fd033007343f20a408618a Reviewed-by:
Nico Vertriest <nico.vertriest@qt.io>
-
- 20 Jan, 2018 - 2 commits
-
-
Liang Qi authored
-
Alex Trotsenko authored
Change-Id: Ic53a8a53b882f1e6b6434b943fff0a6fcd95f341 Reviewed-by:
Edward Welbourne <edward.welbourne@qt.io>
-
- 19 Jan, 2018 - 2 commits
-
-
Liang Qi authored
Conflicts: src/corelib/io/qprocess_win.cpp Change-Id: Ib61b74a69922ec1e9eecbba5f75352b4ec167fa9
-
Kai Koehne authored
We do add, remove or update third party code in minor releases, sometimes even in patch level releases. However, the documentation is supposed to be valid for all existing Qt 5 versions, but doing this for attributions would require infrastructure we don't have. Therefore rather make it explicit which Qt version the attributions apply to. Also mention since when Qt is available under LGPLv3 (starting with Qt 5.4). Task-number: QTBUG-65665 Change-Id: I328b5bf0c143f78ea61aad51f0644c3cbb6dee49 Reviewed-by:
Edward Welbourne <edward.welbourne@qt.io> Reviewed-by:
Topi Reiniö <topi.reinio@qt.io>
-
- 18 Jan, 2018 - 18 commits
-
-
Edward Welbourne authored
QFileInfo.isRelative() deems any path starting with a slash to be absolute; on MS-Win, such paths need a drive specifier (unless they're UNC), so use IoUtils's more robust test for absolute paths. Change-Id: I7d0872a87833cbf1cc1a6ef107941adc4c529624 Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@qt.io>
-
Allan Sandfeld Jensen authored
Gcc 8 now warns against casting functions taking references to functions taking pointers: warning: cast between incompatible function types from ‘QVariant (*)(const int&, const int&, double)’ to ‘QVariant (*)(const void*, const void*, double)’ [-Werror=cast-function-type] Suppressed by casting over void(*)(). Change-Id: I48bee53253b8e87110e8a49efa761fc2add89c5a Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Martin Storsjö authored
The __fastcall calling convention is silently ignored on other architectures. The GNU attribute regparm is allowed but doesn't make sense on x86_64. On other architectures, the attribute isn't supported at all. This fixes building with clang for MinGW/ARM and ARM64. Change-Id: Ice1c6eadd0e90b2e5e34736542ee49a25dc67fe6 Reviewed-by:
Lars Knoll <lars.knoll@qt.io> Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Allan Sandfeld Jensen authored
Don't use the full size of dest in strncpy, we override the last byte anyway afterwards. Change-Id: I9f1618cc9019e0060f01deed58a726caa1989d3f Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Edward Welbourne authored
The native APIs don't support previous transition, only next after a stipulated date. The prior code started its search at the epoch; if used for a time before the first transition after the epoch, this found no transitions so returned invalid data, when the last transition before the epoch would have been suitable. It also wound through all transitions since the epoch, on its way to the selected time, which was potentially laborious. Instead, start a year before the stipulated time; this should get a transition if the zone uses DST. If it doesn't, start with the first known transition and binary-chop our way to one within a year of the last before the stipulated time; then wind forward one transition at a time, as before. The chopping is actually faster than binary: each time we find a transition after the interval mid-point but early enough, we move the early end of our interval to the transition, which is later than the old interval's middle. Using halving, starting with a vast interval, should thus only incur modest cost, while ensuring we give up early when no transition data is available at all or the zone's first transition ever was after the stipulated time. Task-number: QTBUG-65443 Change-Id: I96c14540fc2600837e6a22e480fb8dc36cb37220 (cherry picked from commit 7c0b7064) (cherry picked from commit a090076e ) Reviewed-by:
Andy Shaw <andy.shaw@qt.io> Reviewed-by:
Jason Dolan <jason.t.dolan@gmail.com>
-
Oswald Buddenhagen authored
use a "use" entry instead of including the transitive dep into the list of libraries. this also removes the redundant check of freetype features from the fontconfig test code. Change-Id: I86b78028255c9bf0a62be5ec0f97a62ef3fda36f Reviewed-by:
Joerg Bornemann <joerg.bornemann@qt.io> Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Oswald Buddenhagen authored
amends a96656a8 . Change-Id: Ic434c272bfe985ea0410090537b8a22aad3192f1 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Oswald Buddenhagen authored
such a project structure violates the assumption that the referenced resources are specified relative to the sub-project root, so we must resolve them to absolute paths manually. Task-number: QTBUG-65753 Change-Id: I8bcd5c6e7d7c6a713e5fcd3668be7d2f23169501 Reviewed-by:
Joerg Bornemann <joerg.bornemann@qt.io>
-
Edward Welbourne authored
For Q_OS_WIN, a path is only truly absolute if it includes a drive letter; merely starting with a slash is not enough. (We can't support UNC paths, so don't even try: qmake runs various commands in the source directory using CMD.exe, which doesn't support UNC as PWD.) This requires, when resolving a path relative to a root, transcribing the root's drive to such not-quite-absolute paths. Changed QMakeGlobals, $$absolute_path() and $$relative_path() to now use IoUtils::resolvePath() rather than delegating to QDir's absolute path method, since that doesn't correctly recognize the need for a drive letter (and qmake did run into problems with some paths, from splitPathList and a failing test, as a result). Moved existing ioUtils tests for handling of relative / absolute paths out into separate functions and expanded significantly. Fixed some existing tests to use an absolute path where one is needed; added two tests involving driveless (but rooted) paths; and fixed the test init to set a value for QT_HOST_DATA/src property (the lack of which lead to an assertion failure with this fix). Task-number: QTBUG-50839 Change-Id: I2bfc13c1bfbe1ae09997274622ea55cb3de31b43 Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@qt.io>
-
Oswald Buddenhagen authored
Change-Id: Iad541f0d62ffdb2751da6225b9d40229d7d9a03f Reviewed-by:
Joerg Bornemann <joerg.bornemann@qt.io> Reviewed-by:
Edward Welbourne <edward.welbourne@qt.io>
-
Andy Shaw authored
QSettings does not preserve the original key type in the registry, it will set the type for the key based on the value that is being set. Therefore we should make it clear that existing key types will be overridden as this can cause some problems with types we do not directly support (such as REG_EXPAND_SZ). Task-number: QTBUG-2894 Change-Id: Ib2f2eed02759591e69fefb98a4a1f3cf897dd5cb Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@qt.io>
-
Martin Storsjö authored
Windows on arm (which uses clang, or msvc, but no gcc is available for that setup) can't assemble these sources. (On linux, builds with clang force deferring it to the external assembler, but for windows on arm, no gas compatible external assembler is available). Change-Id: I139572257884cfdc57d3c32061a8c2e28c6e24de Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Liang Qi authored
-
Liang Qi authored
Change-Id: If83012432650a697fe4e8e773ade366589b63b0d
-
Nico Vertriest authored
Task-number: QTBUG-60635 Change-Id: Iec6cae8c3caeac4bfabddae79b6ed2b47c5f2edf Reviewed-by:
Frederik Gladhorn <frederik.gladhorn@qt.io>
-
Frank Richter authored
Showing file dialogs if running on a system that has an older GTK3 version installed results in a crash. Do a version check at runtime and disable native file dialog support if the version is too old. (GTK3 bug: https://bugzilla.gnome.org/show_bug.cgi?id=725164 ) Change-Id: I77bd23f1298333412bae04f52153e1a224ddf470 Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@qt.io> Reviewed-by:
J-P Nurmi <jpnurmi@qt.io> Reviewed-by:
Dmitry Shachnev <mitya57@gmail.com>
-
Frank Richter authored
Although qt_create_pipe() tries again if the pipe name is already in use, it doesn't handle the case when another user has created the pipe with the name (the error is "access denied" in that case). The chance that it happens is small, but it can be entirely eliminated by including a unique part in the pipe name, in this case the PID. [ChangeLog][Windows] Named pipes internally created by QProcess now contain the PID in their name to ensure uniqueness. Change-Id: I079f1b68695c1ddea3eccad241061d11e08b60f4 Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@qt.io> Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Martin Storsjö authored
After including windows.h, interface is a define that expands to "struct" (unless WIN32_LEAN_AND_MEAN is defined). This name is used as a normal identifier in multiple places within Qt. This has already been worked around in a number of places (in e.g. 3ba61d9b and 786d23bb ). After qrandom.h was included in <QtCore/QtCore>, this header implicitly includes <random>. In libc++ on windows, this header then transitively includes windows.h, exposing the clash with the name "interface" in even more locations than before. For cases within qtbase internals, it could also alternatively be handled by defining WIN32_LEAN_AND_MEAN while building QtDbus, but for occurrences in public headers, the undef trick needs to be used. Change-Id: I89754f38f55ae7f2145255a2c8a71b23492be6a1 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
- 17 Jan, 2018 - 4 commits
-
-
Andre Hartmann authored
Makes it easier to copy and paste the snippet into a code editor. Change-Id: I27c0a7aa268bd4fd0af885e929f67a28f083dabf Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Mitch Curtis authored
Saves people the trouble of trying it out themselves. When I tried "address" and "thread", I got: cc1plus: error: -fsanitize=address and -fsanitize=kernel-address are incompatible with -fsanitize=thread Change-Id: I48ae817e60d0b71d5349e1dbce8706cc8430c2c4 Reviewed-by:
Edward Welbourne <edward.welbourne@qt.io> Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@qt.io>
-
Tor Arne Vestbø authored
-
Alexander Shevchenko authored
mingw-w64 toolchain: - add missing compiler definitions, similar to 'msvc-desktop.conf' toolchain, - describe the reasons of missing compiler definitions, available in 'msvc-desktop.conf' toolchain, - add missing 'QMAKE_CXXFLAGS' and 'QMAKE_CXXFLAGS_WARN_ON' variables, similar to 'msvc-desktop.conf' toolchain. ICC on Windows toolchain: - add 'QMAKE_CFLAGS_OPTIMIZE_FULL' variable, similar to 'gcc-base.conf' toolchain, though left it unused for now, - add missing flags to 'QMAKE_CFLAGS' variable, similar to 'msvc-desktop.conf' toolchain, - update deprecated 'Qwd' flag with 'Qdiag-disable', - use 'QMAKE_CFLAGS_OPTIMIZE_DEBUG' variable instead of '-Od' flag, similar to 'gcc-base.conf' toolchain (ICC implies '-O2' optimization level by default, while MSVC implies '-Od'), - add 'QMAKE_CFLAGS_UTF8_SOURCE' variable, similar to 'msvc-version.conf' toolchain; use a workaround to initialize it, until '-utf-8' flag would be supported by ICC on Windows, - update deprecated '-Qstd=c++1z' flag with '-Qstd=c++17', MSVC toolchain: - remove 'incremental' from MSVC 'CONFIG' variable, since it has relevance only for the Unix generator, - add 'QMAKE_CFLAGS_OPTIMIZE_DEBUG' variable, used in ICC for Windows toolchain, - add empty 'QMAKE_LIBS' variable, similar to 'win32-g++' toolchain, - add 'uuid.lib' library to 'QMAKE_LIBS_GUI' variable, similar to 'win32-g++' toolchain, - add C++14 and C++17 language support flags, though left them disabled for now, similar to 'win32-icc' toolchain. Change-Id: Ideef62d0422674184836faa655bfc5d09a5f612f Reviewed-by:
Joerg Bornemann <joerg.bornemann@qt.io> Reviewed-by:
Kai Koehne <kai.koehne@qt.io> Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@qt.io>
-
- 16 Jan, 2018 - 7 commits
-
-
Friedemann Kleint authored
Add a check on the platform window to QWidgetPrivate::create_sys(). Task-number: QTBUG-65783 Change-Id: I077882e1cf22ef49bb6f578f7460493ef48c9627 Reviewed-by:
Richard Moe Gustavsen <richard.gustavsen@qt.io>
-
Nico Vertriest authored
Task-number: QTBUG-60635 Change-Id: Iceb53e7c0df88bb51589a1cc86e905dbc60a856e Reviewed-by:
Venugopal Shivashankar <Venugopal.Shivashankar@qt.io>
-
Nico Vertriest authored
Task-number: QTBUG-60630 Change-Id: I228b8257839115c561529184faa75275c69bb8a8 Reviewed-by:
Venugopal Shivashankar <Venugopal.Shivashankar@qt.io>
-
Tor Arne Vestbø authored
Change-Id: I896b0cf54f317c4336cc3d3db319a0b89e421728
-
Erik Verbruggen authored
When a deleteLater event is queued, a check if done if the same event for the same receiver is queued before by scanning all pending events. This leads to quadratic behavior, which is quite noticeable. By using an unused bit in QObjectData, this can be prevented. Now the duplicate event scanning in QCoreApplication is only done for the quit event. Task-number: QTBUG-65712 Change-Id: Ie505acbbec802f91ebd0b94ac067e362c2476113 Reviewed-by:
Erik Verbruggen <erik.verbruggen@qt.io> Reviewed-by:
Simon Hausmann <simon.hausmann@qt.io> Reviewed-by:
Lars Knoll <lars.knoll@qt.io>
-
Gabriel de Dietrich authored
The changes introduced in 0e810e27 turn out to be incompatible with our style sheets styling. We partially revert the style option state check, so that the look for a highlighted PE_IndicatorMenuCheckMark only depends on State_On, as it's expected in QWindowsStyle and QCommonStyle. [ChangeLog][QtWidgets][QMacStyle] PE_IndicatorMenuCheckMark goes back to only depend on State_On for its highlighted look. Change-Id: I20f8e712196b5515bd5528ff6eedcdca9df5856f Task-number: QTBUG-65773 Reviewed-by:
Thorbjørn Lund Martsum <tmartsum@gmail.com>
-
Andy Shaw authored
If the stylesheet does not have a rule that manipulates the font at all for the menu item, then it should use the one passed into the style option instead. Task-number: QTBUG-65034 Change-Id: I6cae3fad3cc22d5ab2b984e4a58b14303bcd6d03 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@qt.io> Reviewed-by:
Gabriel de Dietrich <gabriel.dedietrich@qt.io>
-
- 15 Jan, 2018 - 2 commits
-
-
Tor Arne Vestbø authored
The protocol may be namespaced, in which case the string lookup would fail, so we iterate the protocols of QNSWindow instead (of which there is only one, QNSWindowProtocol). Change-Id: Ic45752c9e3a40f5d42ec82c4287402a3d7a47b09 Reviewed-by:
Gabriel de Dietrich <gabriel.dedietrich@qt.io>
-
Eirik Aavitsland authored
The documentation of the QImage file loader methods contained a simplified and somewhat misleading description of the format auto detection algorithm. Fix up the language and link to the detailed explanation. Task-number: QTBUG-51596 Task-number: QTBUG-65438 Change-Id: I33ebc81c78e685c7ec4803fa56efd4e9cbc4eda5 Reviewed-by:
Venugopal Shivashankar <Venugopal.Shivashankar@qt.io>
-