- 08 Sep, 2017 - 3 commits
-
-
Simon Hausmann authored
The cgl convenience module does not exist anymore. Task-number: QTBUG-63081 Change-Id: Ifda69ba4384258e0ba67b2badd1eb79026908e32 Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@qt.io>
-
Tor Arne Vestbø authored
QMacAutoReleasePool is backed by an NSAutoreleasePool, which documents that "you should always drain an autorelease pool in the same context (invocation of a method or function, or body of a loop) that it was created". This means allocating QMacAutoReleasePool on the heap is not a supported use-case, but unfortunately we can't detect it on construction time. Instead we detect whether or not the associated NSAutoreleasePool has been drained, and prevent a double-drain of the pool. Change-Id: Ifd7380a06152e9e742d2e199476ed3adab326d9c Reviewed-by:
Simon Hausmann <simon.hausmann@qt.io>
-
Tor Arne Vestbø authored
Tying the pool to the lifetime of QCoreApplication becomes a problem when the application is allocated on the heap, for example when Qt is used to create plugins, as NSAutoreleasePool should be allocated and drained in the same context, typically a function scope. The feature is disabled for now, until we can find a better way to achieve the same thing. Change-Id: I600587df62a8cc7caded5172ad914c0e04d794d9 Reviewed-by:
Simon Hausmann <simon.hausmann@qt.io> Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@qt.io>
-
- 07 Sep, 2017 - 1 commit
-
-
Gatis Paeglis authored
Tests should not use QCursor to emulate mouse move, see QCursor::setPos() docs. The flakiness of the test on XCB is not surprising when the test queries geometry even before the window has been shown. With the re-factored version I could not reproduce flakiness anymore. Removed Q_OS_MAC and closed QTBUG-26274 as test passes on macOS from which I assume that the underlying issue has been fixed. Removed Q_OS_QNX ifdef as test does not rely on QCursor anymore. This patch also fixes the issues on minimal / offscreen platform plugins. QCursor::setPos() is evil for auto test purposes. Note: We intentionally use QTest::mouseMove(QWindow *window, ..), not the QWidget overload. The QWindow version gets routed through QWSI, which ensures that all necessary events are generated as expect. In QWidget code path this is currently disabled by QTEST_QPA_MOUSE_HANDLING. Change-Id: I285c26cff09e3f2750f8c2abbb1f46c8f7be984a Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@qt.io>
-
- 06 Sep, 2017 - 13 commits
-
-
Liang Qi authored
-
Gabriel de Dietrich authored
macOS doesn't use different colors for alternate rows between blue and graphite themes. It's always the same light gray, as seen on Finder, and we're already getting it right. Change-Id: Ic9ff1712ed90728bcc7613d9fe9eeb7a9c90f59b Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@qt.io>
-
Gabriel de Dietrich authored
This ain't used nowhere. Change-Id: I107bbc4d8cd223bbc726c3ce2ea00059d97e6f2c Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@qt.io>
-
Gabriel de Dietrich authored
Change-Id: Iae56312a78431613737b69c0e16472cafff35da9 Reviewed-by:
Timur Pocheptsov <timur.pocheptsov@qt.io>
-
Gabriel de Dietrich authored
This provides proper support for proxy styles wanting to override only parts of QSlider. Change-Id: Ica1e87c42c8d793708c388cb19f11105c0fc97ad Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@qt.io>
-
Gabriel de Dietrich authored
This one uses a hybrid approach. Standalone NSSliderCell has proven to be quite useless. However, we can access the cell of a properly configured NSSlider. Then, the cell can be to render all the QSlider parts as well as getting their rects. Change-Id: Idedad3e6d80e70631b01125596ed24dae5fde6c7 Reviewed-by:
Morten Johan Sørvig <morten.sorvig@qt.io>
-
Gabriel de Dietrich authored
These are written into, but never read from. Change-Id: I23af5dbb2d162b06ed93f32459140a8385d65a95 Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@qt.io>
-
Gabriel de Dietrich authored
Change-Id: I00805bf55566059f842203faaad13a6d4a5b96f4 Reviewed-by:
Jake Petroules <jake.petroules@qt.io>
-
Liang Qi authored
Conflicts: examples/opengl/qopenglwidget/main.cpp src/3rdparty/pcre2/src/pcre2_printint.c src/plugins/platforms/cocoa/qnsview.mm src/widgets/widgets/qcombobox.cpp Change-Id: I37ced9da1e8056f95851568bcc52cd5dc34f56af
-
Stephan Binner authored
Change-Id: I8ba76ba1c7210169df14ffab7dabf4b4be086fb9 Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@qt.io>
-
Stephan Binner authored
The sources were already added conditionally in the project file since 179fe598 . Change-Id: I0baaec2e772f3e596d311c1973b9745aa2b80423 Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@qt.io>
-
Stephan Binner authored
QUrlInfo is used only by the FTP implementation, so it uses the same conditionals. Change-Id: Ia15abf44d2a538e90b792a31c65926cc9e16aecf Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@qt.io>
-
Thiago Macieira authored
One of those routines could recurse back. This was a pre-existing problem for Pre-Pre routines, but commit a92ee2518fdbd77fcbe3f8ef4f412aa made qAddPostRoutine also use the same mutex. Task-number: QTBUG-63008 Change-Id: I38341f8155354cc4a776fffd14e17a037d25475f Reviewed-by:
Simon Hausmann <simon.hausmann@qt.io> Reviewed-by:
J-P Nurmi <jpnurmi@qt.io>
-
- 05 Sep, 2017 - 16 commits
-
-
Jani Heikkinen authored
Task-number: QTBUG-62722 Change-Id: Ibb2f27774b3080eceead5c2228cf59db382205e3 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Gatis Paeglis authored
It has been there since the first commit 6d70e543 of VNC platform plugin, and it has never actually been used. Change-Id: I6a9c4e6a27de042e18650fa88728a1849a99b094 Reviewed-by:
Laszlo Agocs <laszlo.agocs@qt.io>
-
Gatis Paeglis authored
Default scroll increment on other platforms (e.g. XCB, Windows) is 120. With libinput it was 15 * 120 = 1800, which results in non-smooth scolling experience. This patch also replaces deprecated versions of QWindowSystemInterface::handleWheelEvent(). Change-Id: I363f13a2922fd871a93dbd1bd611778fa18f6122 Reviewed-by:
Laszlo Agocs <laszlo.agocs@qt.io>
-
Gatis Paeglis authored
I guess this signal pattern was copy-pasted from evdev input integration code, where we use similar signals in combination with QDeviceDiscovery. In libinput, device notifications are delivered via libinput APIs, so these signals are not necessary. In evdev we do some logging from slots that are connected to these signals. In libinput this is handled via libinput_log_set_handler. As we can see, we can simply drop this code. Change-Id: I50b519784e89b59ceeb3cf296780705fe98a8cbf Reviewed-by:
Laszlo Agocs <laszlo.agocs@qt.io>
-
Gatis Paeglis authored
This results in less boilerplate code, among other benefits that come with functor-based connections. Simple expressions have been converted to use lambda. Change-Id: I6887980524027eada24beed95e6f9ba43f0fc8d5 Reviewed-by:
Laszlo Agocs <laszlo.agocs@qt.io>
-
Mitch Curtis authored
This gives the user a much clearer understanding of which part of the test caused the warning. Old warning: WARNING: tst_controls::Default::Dial::test_linearInputMode(mouse) Mouse event occurs outside of target window. New warning: WARNING: tst_controls::Default::Dial::test_linearInputMode(mouse) Mouse event at 501, 179 occurs outside of target window (450x450). Change-Id: I2943d79bab5a808e9b5b721758db216b91a07bbd Reviewed-by:
Liang Qi <liang.qi@qt.io> Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@qt.io>
-
Friedemann Kleint authored
It causes artifacts when moving the windows between monitors. Amends e8ecde99 . Task-number: QTBUG-53255 Task-number: QTBUG-62901 Change-Id: Ia8b0f760370887a75efa05bc9736075afebfe069 Reviewed-by:
Oliver Wolff <oliver.wolff@qt.io>
-
Friedemann Kleint authored
Bail out of cleanup() when run 2nd time. Task-number: QTBUG-60626 Change-Id: I8a9be2fcfb0e8a5584ce8ed7952affff24bd2a33 Reviewed-by:
Laszlo Agocs <laszlo.agocs@qt.io>
-
Friedemann Kleint authored
Task-number: QTBUG-60626 Change-Id: I6d102327c89206fcdce10f3ac04e112270b11ad2 Reviewed-by:
Laszlo Agocs <laszlo.agocs@qt.io>
-
Tor Arne Vestbø authored
Enabled via configure --ccache, or CONFIG += ccache in 3rd party projects. Ensures that we use the right sloppiness and other ccache options during compilation. Task-number: QTBUG-31034 Change-Id: I696b3d3f0398873a29b93d1bc2b4d4e06ef23dc9 Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@qt.io>
-
Morten Johan Sørvig authored
The backing store was assigned the sRGB color profile as an unintended side effect of the QImage -> CGImage conversion function refactoring in ac899f6d . This caused Core Graphics to add a color convert step, which in some cases caused performance issues. Restore fast, previous behavior by assigning the target display color profile to the backing store image. Color correctness is still a goal, but we’ll add API for it and make it opt-in. Task-number: QTBUG-61384 Change-Id: Ia36d29404c64d8030a100f6a71816d84e484308b Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@qt.io>
-
Morten Johan Sørvig authored
The backing store was assigned the sRGB color profile as an unintended side effect of the QImage -> CGImage conversion function refactoring in ac899f6d . This caused Core Graphics to add a color convert step, which in some cases caused performance issues. Restore fast, previous behavior by assigning the target display color profile to the backing store image. Color correctness is still a goal, but we’ll add API for it and make it opt-in. Task-number: QTBUG-61384 Change-Id: I107f06a881a34fa711b386265d8dc2edfb246624 Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@qt.io>
-
Andre de la Rocha authored
Adds QWindowsDropDataObject as a QWindowsOleDataObject subclass specialized for handling Drag & Drop, which only allows "text/uri-list" data to be exported as CF_HDROP, to allow files dragged from Qt applications and dropped into other applications to be recognized as attachments or opened. Otherwise, files would be imported as URLs and inserted as local hyperlinks. [ChangeLog][Important Behavior Changes][Windows] On Windows, a drag & drop operation of local files URIs, like QListView items backed by a QFileSystemModel, will result in the attachment or opening of the files by the target application, instead of the creation of hyperlinks. Task-number: QTBUG-62662 Change-Id: I51efa4a56574b5e5fb3ee736ede14b5da24caac4 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@qt.io>
-
Giuseppe D'Angelo authored
Follow up of fc37e036 : while the file is #included from pcre2_compile.c, it's never actually compiled (seems to be about a debugging aid for developing PCRE2). So it's safe to get rid of it. Change-Id: I0affaad730e8c5678d3431e47d5fee0dbedc0e78 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Giuseppe D'Angelo authored
Both iOS and tvOS need to have JIT disabled, so use the uikit qmake scope for that. This was already done for PCRE 1, but the corresponding change was lost for PCRE 2 (probably due to a bad merge). Change-Id: Iac7997880c13b34ced46c63b748980c6fb700a0f Task-number: QTBUG-62993 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com> Reviewed-by:
Jake Petroules <jake.petroules@qt.io>
-
Tor Arne Vestbø authored
AppKit will clear the needsDisplay state of a view when finishing the display cycle, so if the client requested an update when delivering the expose event, the update request would not be delivered unless the view was otherwise exposed in some way at a later point. Task-number: QTBUG-62964 Task-number: QTBUG-62963 Change-Id: I5ac9bf2f19af775294d093c8b7a414af22efee92 Reviewed-by:
Shawn Rutledge <shawn.rutledge@qt.io>
-
- 04 Sep, 2017 - 7 commits
-
-
Tor Arne Vestbø authored
Change-Id: Id9650dde73e1cfbe8626b4d31b86e9bbf007be89 Reviewed-by:
Timur Pocheptsov <timur.pocheptsov@qt.io>
-
Gatis Paeglis authored
This patch does not attempt to add the necessary functionality to support other tablet buttons, it simply replaces deprecated version of QWindowSystemInterface::handleTabletEvent(), by keeping the previous logic. Task-number: QTBUG-62886 Change-Id: I23597077774d482492136fda2e998700f8b27e9c Reviewed-by:
Laszlo Agocs <laszlo.agocs@qt.io>
-
Gatis Paeglis authored
Logic that utilizes these event handlers was added by f610814b and few months later broken by 2b20ed5a . The original code used an event mask to select press/release/ motion events when creating window with XCreateWindow. The XCB replacement (xcb_create_window) changed event mask to 0, which means that these event handlers have been unused for about ~4 years and can be safely removed. The eglfs_x11 integration receives mouse input directly from libinput/evedev. Change-Id: Iac1521365445b8423898a16c3e609deb0806ce5e Reviewed-by:
Laszlo Agocs <laszlo.agocs@qt.io>
-
Àlex Fiestas authored
The QWindow passed to eventFilter is static so it might be in a different screen when we call getNativeMousePos, resulting in negative position and all sorts of glitches. Change-Id: Ibc848c6d85d8b6932ee379aa77851094212a0db2 Reviewed-by:
David Edmundson <davidedmundson@kde.org> Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@qt.io>
-
Eskil Abrahamsen Blomfeldt authored
When the focus object inside a window changes and we are currently composing text, we have to cancel composition to avoid getting into an inconsistent state. This is what already happens if you switch to a different top level window. Note: Because we limit the user's ability to change focus inside a window when composing text, this would only happen under certain circumstances, such as creating a new MDI window with an editor while still composing text in a previous one. [ChangeLog][macOS] Switching focus objects inside a top level window while composing text using dead keys or input method events would leave the application in an inconsistent state. The composition now automatically cancels when the focus object changes. Task-number: QTBUG-59222 Change-Id: I06792a7db1441dcc5c87e4bf0861b422a25f7f7c Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@qt.io>
-
Tony Sarajärvi authored
Task-number: QTBUG-51399 Change-Id: I7fcc52da2ce539251f6bad0394c4580dd76439a7 Reviewed-by:
Heikki Halmet <heikki.halmet@qt.io>
-
Tony Sarajärvi authored
Task-number: QTBUG-62967 Change-Id: I42f25120f1a9e2ef6a9a147e4f36edcdff2922a6 Reviewed-by:
Heikki Halmet <heikki.halmet@qt.io>
-