1. 04 Oct, 2017 - 3 commits
    • Tor Arne Vestbø's avatar
      macOS: Prevent backingstore image detach during color space assignment · 5b4cf7af
      Tor Arne Vestbø authored
      
      The call to CGImageCreateCopyWithColorSpace took a naked toCGImage(),
      which left the resulting CGImageRef without a release, causing the
      extra ref by toCGImage() to never be derefed, and a subsequent detach
      of the image data on the next paint event.
      
      Wrapping the call in a QCFType<CGImageRef> solves the problem. The code
      has also been moved directly into QCocoaBackingStore::flush(), as there
      is no need to keep the CGImageRef a member.
      
      A local autorelease pool has been added to QCocoaBackingStore::flush(),
      so that the NSImage used for blitting the backingstore is released upon
      exit of the function, thereby releasing the corresponding CGImageRef.
      
      Note that for layered mode, the QImage will still detach, as the view's
      layer.contents property keeps a reference to the image data until being
      replaced in a subsequent flush.
      
      Task-number: QTBUG-63559
      Change-Id: I06b9298f65a84deae7cc2eff617ba75c92ec3b87
      Reviewed-by: default avatarMorten Johan Sørvig <morten.sorvig@qt.io>
      v5.10.0-beta1
      5b4cf7af
    • Tor Arne Vestbø's avatar
      iOS: Bump deployment target to 10.0 as planned for 5.10 · 1b473ee6
      Tor Arne Vestbø authored
      
      [ChangeLog][iOS] The minimum deployment target for applications is now
      iOS 10.0.
      
      Change-Id: Icb37e4eaecbf6f62fd3c9293b2abf19a0954a02d
      Reviewed-by: default avatarJake Petroules <jake.petroules@qt.io>
      1b473ee6
    • Richard Moe Gustavsen's avatar
      Widgets: change QWidget::setTabOrder to understand compound widgets · b4981f9d
      Richard Moe Gustavsen authored
      
      A "compound widget" is a widget that has a focus proxy set to an inner
      child. This is normal for complex black-box components where focus handling
      is delegated to the children. Since the compound can have several
      children, a local tab order might exist between them.
      
      The current implementation of setTabOrder had no idea about
      compound widgets. As such, when connecting two compounds in the
      tab chain, it would just break up their inner tab order and
      cause tabbing to ignore children other than the proxy.
      
      The new implementation recognizes compound widgets, and add some
      extra code to figure out the correct tab targets. This way, the
      local tab order between the children will be preserved.
      
      This implementation was inspired by the patches of Marek Wieckowski posted
      in the linked bug report, and later modified by Nikita Krupenko.
      
      [ChangeLog][Widgets] QWidget::setTabOrder() will now preserve the local
      tab order inside a widget if it has a focus proxy set to an inner child.
      
      Task-number: QTBUG-10907
      Change-Id: I0673d39d70ec8c6bf64af30bf978d67c651b2f3c
      Reviewed-by: default avatarAndy Shaw <andy.shaw@qt.io>
      Reviewed-by: default avatarFrederik Gladhorn <frederik.gladhorn@qt.io>
      b4981f9d
  2. 03 Oct, 2017 - 4 commits
    • Gabriel de Dietrich's avatar
      QMacStyle: Remove HITheme calls for QSizeGrip · b8947e91
      Gabriel de Dietrich authored
      
      That's no longer a thing on macOS. We still keep it around for
      QMdiSubWindow, but we should support 4-edge resizing there as
      do native windows.
      
      In practice, because of WA_MacOpaqueSizeGrip, we were already
      rendering the size grip manually instead of relying on HITheme.
      
      Change-Id: If613a14f03dc650b457688f3f2f57631b5fb30a3
      Reviewed-by: default avatarJake Petroules <jake.petroules@qt.io>
      b8947e91
    • Gabriel de Dietrich's avatar
      QMacStyle: De-HITheme QGroupBox · d47a467c
      Gabriel de Dietrich authored
      
      NSBox is good enough for this and pixel equivalent with
      the previous HITheme calls.
      
      Change-Id: I32b2a1cc8a9cd2a6ef17d1e01032540344808ebc
      Reviewed-by: default avatarJake Petroules <jake.petroules@qt.io>
      d47a467c
    • Gabriel de Dietrich's avatar
      QMacStyle: Refactor QMacStylePrivate::cocoaControl() · 475243a7
      Gabriel de Dietrich authored
      
      That switch following the if looked a bit corny.
      
      Also made cocoaCells hash mutable to get rid of the
      const_cast(this) in QMSP::cocoaCell().
      
      Change-Id: I4facec827409314cf1214152c19efb9688715eb2
      Reviewed-by: default avatarJake Petroules <jake.petroules@qt.io>
      475243a7
    • Tor Arne Vestbø's avatar
      macOS: Tighten up window icon and represented filename handling · bccbb52b
      Tor Arne Vestbø authored
      
      Window icons on macOS are tied to document windows, and should not show
      up unless a represented filename has also been set according to the HIG.
      
      We follow this, and no longer create a document button based on the window
      title if one did no exists. We also fall back to using the filename of
      the file if a title has not been set, including being able to restore
      this default title after setting a custom title.
      
      The icon is no longer reset to nil after setting a QIcon(), which would
      remove the icon completely, but instead we restore the default behavior
      of showing the default filetype icon of the file.
      
      Finally, the two callbacks in QNSWindowDelegate dealing with the document
      icon/title popups and drags have been taught to look for spaces in the
      represented filename. This allows clients who really want the old
      behavior of setting an icon without caring about the filename to set
      the filename to a single space character, which will prevent the
      dropdowna and drag from occurring.
      
      The reason for not tying this behavior to the existence of the file in
      the filesystem is that being able to represent a file that is yet to
      be saved is a valid usecase.
      
      Task-number: QTBUG-63338
      Change-Id: I7d4377c6358226fb6058f8c2b3c28588eec77ce5
      Reviewed-by: default avatarMorten Johan Sørvig <morten.sorvig@qt.io>
      bccbb52b
  3. 02 Oct, 2017 - 2 commits
    • Timur Pocheptsov's avatar
      QtNetwork (examples) - update the second download manager example · d8922924
      Timur Pocheptsov authored
      
      It's the one that is more complex - with a text-based 'progress-bar'
      and queueing (for some, probably educational, reason) of requests.
      
      Changes:
      
      - update the C++ syntax (mem-initializers, range for, etc.)
      - new-style headers
      - redirects should not result in creating an empty file.  Since we
        have no UI, and this example is already complex enough, settle
        for just reporting the redirect and removing the empty file.
      
      Task-number: QTBUG-60628
      Change-Id: I0b69cd77414ecac7c0bc6b2f8f787befc978de28
      Reviewed-by: default avatarEdward Welbourne <edward.welbourne@qt.io>
      d8922924
    • Timur Pocheptsov's avatar
      QtNetwork (examples) - update network download manager · 42d7bc4c
      Timur Pocheptsov authored
      
      Mainly 'modernizing' - use <c...> c-library includes (<stdio.h> -> <cstdio>),
      add appropriate using directive; minor fixes in formatting + removal of a
      hated double negation (aka ifndef QT_NO_NOTHING). Also, as our rules
      ('how to write examples') suggest - replace too many inclusion directives
      with module-level headers. Basic redirects handling - do not create empty files
      for redirected requests (or even files with some useless html).
      
      Task-number: QTBUG-60628
      Change-Id: Ia4398d39126313e6213bc7244d11a55958e64dec
      Reviewed-by: default avatarEdward Welbourne <edward.welbourne@qt.io>
      42d7bc4c
  4. 01 Oct, 2017 - 1 commit
  5. 29 Sep, 2017 - 13 commits
  6. 28 Sep, 2017 - 10 commits
  7. 27 Sep, 2017 - 5 commits
  8. 26 Sep, 2017 - 2 commits