- 15 Apr, 2018 - 1 commit
-
-
Timur Pocheptsov authored
When releasing a STACK_OF(GENERAL_NAME). Actually, GENERAL_NAME_free is a special function, not the same as OPENSSL_sk_free. Task-number: QTBUG-57679 Change-Id: I3ed300bb95e8be35bd9cd06b6dbc6e59c7c6a4ee Reviewed-by:
Mårten Nordheim <marten.nordheim@qt.io> Reviewed-by:
Edward Welbourne <edward.welbourne@qt.io>
-
- 14 Apr, 2018 - 4 commits
-
-
Allan Sandfeld Jensen authored
The android mkspecs had their own way of doing the same as optimize_size Change-Id: Id05822df6bdeb8b3aafada2901bd61530c490fe9 Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@qt.io> Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com> Reviewed-by:
BogDan Vatra <bogdan@kdab.com>
-
Gatis Paeglis authored
We were using xcb_render_* APIs without checking if the server even supports this extension. Attempting to use an extension which is not present will always result in a crash. This patch adds the required guards and refactors how we detect presence of XRender extension. Also instead of falling back to some odd-looking bitmapped version just leave the current cursor unchanged. That is how we did it in Qt4 AFAICT. Task-number: QTBUG-66935 Change-Id: I4f27f1d65a77563ec34f3e0e94492c9236d7f9a6 Reviewed-by:
Laszlo Agocs <laszlo.agocs@qt.io>
-
Gatis Paeglis authored
... introduced by 42283868. Instead of completely droping caching for bitmap cursors we can do the same what is done in libXcursor - have a fixed size cache, with oldest entries eventually being replaced with new bitmaps. This fixes the original issue, where the hash was growing indefinitely until running out of file descriptors and won't have the performance penalty as in 42283868 . Task-number: QTBUG-66897 Change-Id: I14f80b46f97fd0e2c920e17a31ffbc0441cd9d22 Reviewed-by:
Uli Schlachter <psychon@znc.in> Reviewed-by:
Robin Burchell <robin.burchell@crimson.no> Reviewed-by:
Laszlo Agocs <laszlo.agocs@qt.io>
-
Gatis Paeglis authored
- removed the check for "m_segmentSize > 0" as according to the code it will never be <= 0. - wrap the entire logic in connection()->hasShm() { .. } as that is when the logic becomes relevant. This makes the code more readable. Change-Id: I572420df8e29cc46593f8a13c250f8c05c6a9108 Reviewed-by:
Laszlo Agocs <laszlo.agocs@qt.io>
-
- 13 Apr, 2018 - 5 commits
-
-
Kari Oikarinen authored
Task-number: QTBUG-63992 Change-Id: I795e564b051bbabd1fc2d2fca8171da6072f99eb Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@qt.io> Reviewed-by:
Gatis Paeglis <gatis.paeglis@qt.io>
-
Lars Knoll authored
Avoid creating a QDateTime in the resource that will almost never get used. Constructing the date time is expensive as we convert the time stamp to local time. Task-number: QTBUG-65713 Change-Id: I3638e108a8fbd237cd93e98aa2adc0ca2127822c Reviewed-by:
Simon Hausmann <simon.hausmann@qt.io> Reviewed-by:
Tuukka Turunen <tuukka.turunen@qt.io>
-
Oliver Wolff authored
QPlatformOpenGLContext::isValid always returns true but it is possible that creation of the context fails in QWinRTEGLContext. This case should be reflected in isValid because other places (like QOpenGLContext::isValid()) rely on it and not having proper information about the validity of the context might lead to crashes. Task-number: QTBUG-67568 Change-Id: If989ca47cdf7b27c44961beee5d97a4647184b0a Reviewed-by:
Maurice Kalinowski <maurice.kalinowski@qt.io>
-
Akihito Izawa authored
Change-Id: Ieb76ecc406c25ca11a108775ebd46a8e597401b5 Reviewed-by:
Andy Shaw <andy.shaw@qt.io> Reviewed-by:
J-P Nurmi <jpnurmi@qt.io>
-
Kari Oikarinen authored
Task-number: QTBUG-63992 Change-Id: I1696ccbdf0523ece694f2dac52c015443c8b19fb Reviewed-by:
Gatis Paeglis <gatis.paeglis@qt.io>
-
- 12 Apr, 2018 - 19 commits
-
-
Eirik Aavitsland authored
The output routine used a fixed size scratch buffer, with no attempt to handle overrun. Add a simple fallback code path for such (extremely rare) cases. Task-number: QTBUG-66788 Change-Id: I52531b829baeaa48a8fb5a637a020ee9f89d270a Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@qt.io>
-
Eirik Aavitsland authored
This static method can be called before QGuiApplication is created. At that point there is yet no primary screen, so the implementation needs to guard against dereferencing a nullptr. Task-number: QTBUG-67309 Change-Id: I6b7b9e97b1c3c79bf2f9c6d6247c3b10f39f7a55 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@qt.io>
-
Alex Trotsenko authored
To read data from a named pipe, QWindowsPipeReader uses the ReadFileEx() function which runs asynchronously. When reading is completed and the thread is in an alertable wait state, the notified() callback is called by the system, reporting a completion status of that operation. Then the callback queues a readyRead signal and starts a new sequence. The latter is skipped if the pipe is broken or the read buffer is full. Thus, if an application does not run the event loop, the next call to QWindowsPipeReader::waitForReadyRead() should emit the queued signal and report true to the caller even if no new read operation was started. Change-Id: I37102dbb1c00191d93365bfc2e94e743d9f3962a Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@qt.io>
-
Gabriel de Dietrich authored
We also remove the old documentation file that is now mostly outdated. Change-Id: I32c9c6b0984be5e41653a92b0b9287a89f73ee38 Reviewed-by:
Morten Johan Sørvig <morten.sorvig@qt.io>
-
Oswald Buddenhagen authored
instead of relying on more or less accidental qmake behaviors regarding the base dir for relative paths (esp. if a file does not exist yet), make everything explicit. to that effect, clearly define the base tree (source or build) for every syncqt-generated variable, and write only in-tree relative paths to the variables. on the receiving end, resolve the paths as soon as headers.pri was read. Task-number: QTBUG-67111 Change-Id: I32ae5760fb62ebc650fdb69e46aac786a8141564 Reviewed-by:
Lars Knoll <lars.knoll@qt.io> Reviewed-by:
Alexandru Croitor <alexandru.croitor@qt.io>
-
Oswald Buddenhagen authored
the source file must not be written with an absolute path to the makefile, as this won't match the name of the target which generates it, thus leading to an unsatisfied dependency. this is the proper fix for QTBUG-60413 and a bunch of others. amends historical f173e217cd. Change-Id: I28140351c4b4759de35e60daf63bc54b82d104ec Reviewed-by:
Alexandru Croitor <alexandru.croitor@qt.io>
-
Timur Pocheptsov authored
1. If a request was redirected or some error was encountered, we try to reset the uploading byte-device. 2. Disconnecting from the byte-device is not enough, since we have a queued connection, _q_uploadDataReadyRead() gets called even if byte-device was deleted and thus sender() can return null - we have to check this condition. 3. Update auto-test with a case where our server immediately replies with a redirect status code. Task-number: QTBUG-67469 Task-number: QTBUG-66913 Change-Id: I9b364cf3dee1717940ddbe50cba37c3398cc9c95 Reviewed-by:
Edward Welbourne <edward.welbourne@qt.io>
-
Sergio Martins authored
Bug can be seen on the .gif attached to QTBUG-67611, the floating group window resizes, but the rubber band still has the old size. Change-Id: I7232a39574ea06fe036c75c21e7496c0f32f4632 Reviewed-by:
Olivier Goffart (Woboq GmbH) <ogoffart@woboq.com>
-
Allan Sandfeld Jensen authored
There are too many combinations and the data is not very useful when it is impossible to get an overview. This cuts a few rare formats out and reduces the sizes tested to one small for overhead benchmarking and one large for bandwidth benchmarking. Change-Id: If0fe33e0e02b8cba771094a79072036f2cd4cf48 Reviewed-by:
Jędrzej Nowacki <jedrzej.nowacki@qt.io> Reviewed-by:
Eirik Aavitsland <eirik.aavitsland@qt.io>
-
Kari Oikarinen authored
This failed (occasionally) in finding the editor widget, so wait for the window to be shown properly. Also enter the event loop with QTRY_VERIFY and not for a fixed time of 1 s. This however just moved the point of failure. Now the test fails since the clearing and setting of focus does not dismiss the editor widget sometimes, so still blacklist it. Task-number: QTBUG-67282 Task-number: QTBUG-66216 Change-Id: Iec598609fce23a25d7b955082d0973685d612715 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@qt.io> Reviewed-by:
Gatis Paeglis <gatis.paeglis@qt.io>
-
Kari Oikarinen authored
Change-Id: Id3fef4e66bd8f96c8f87dd94bbca216cc65f8489 Reviewed-by:
Gatis Paeglis <gatis.paeglis@qt.io> Reviewed-by:
Simon Hausmann <simon.hausmann@qt.io> Reviewed-by:
Qt CI Bot <qt_ci_bot@qt-project.org>
-
André Klitzing authored
[ChangeLog][Third-Party Code] Sqlite was updated to version 3.23.1 Change-Id: I27edf023fdcad30fb2171b04fa374910dd4d9122 Reviewed-by:
Kai Koehne <kai.koehne@qt.io> Reviewed-by:
Andy Shaw <andy.shaw@qt.io>
-
Kai Koehne authored
Change-Id: Ie31c56369baf26f5592c95dacea60ae58fdbccfe Reviewed-by:
Leena Miettinen <riitta-leena.miettinen@qt.io>
-
Kari Oikarinen authored
Use QTRY_COMPARE instead of a wait followed by QCOMPARE. Unless the condition doesn't change and the wait provides the opportunity for things to go wrong. Task-number: QTBUG-63992 Change-Id: I13474a45f1f4df9d77a418729a5748235ae0dd1a Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@qt.io> Reviewed-by:
Gatis Paeglis <gatis.paeglis@qt.io>
-
Gabriel de Dietrich authored
This should be the last bit of QMacStyle depending on HIToolBox APIs. Small and mini sizes support coming later. Same for the focus ring. Change-Id: If625fccb87ebd0607b96a8c5040888df5a2a1032 Reviewed-by:
Morten Johan Sørvig <morten.sorvig@qt.io>
-
Gabriel de Dietrich authored
Change-Id: I34f1325adc661edde7bba7d7374bc8cfb80900ae Reviewed-by:
Morten Johan Sørvig <morten.sorvig@qt.io>
-
Gabriel de Dietrich authored
Change-Id: If14e67bdae41099bb87fe2d7c4f65926d325766b Reviewed-by:
Morten Johan Sørvig <morten.sorvig@qt.io>
-
Gabriel de Dietrich authored
We go for direct drawing for now. Some of the logic was a bit sketchy, and we need to measure how useful is caching and eventually compatible with the focus frame animation. Change-Id: Id30a68f77a4129197536e8ca251906ee8a730925 Reviewed-by:
Morten Johan Sørvig <morten.sorvig@qt.io>
-
Gabriel de Dietrich authored
For the time being, no more stretched QComboBox. They were already looking bad before and nobody complained, so it's a non-issue. In the future, we might use square combo boxes in the same way as we do for push buttons but for non-editable QComboBox only. Removes what is now dead code, including some leftovers. tst_QMacStyle updated to reflect size changes to accom- modate the focus ring. Change-Id: I60fac86b9acb52cc96373bca0b3cad598ec4f1e7 Reviewed-by:
Morten Johan Sørvig <morten.sorvig@qt.io>
-
- 11 Apr, 2018 - 11 commits
-
-
Sergio Martins authored
Animated .git attached to the bug report for easy understanding. Looks like we shouldn't set window flags after a setGeometry() and before having the window resources. If we do that, then the requested geometry won't be honoured. No idea if it can be fixable in the QPA and won't risk doing it there. Fixes the problem on macOS and Windows. On Linux it was OK, and still is. Task-number: QTBUG-67611 Change-Id: I8244b4956a5ac9afcf257bea762c2c3084b563f8 Reviewed-by:
Olivier Goffart (Woboq GmbH) <ogoffart@woboq.com>
-
Sergio Martins authored
the drop target would create a floating group window, which would have higher z-order since it just had show() called on it. raise the window we're dragging when the target is mutated into group window. Bug can be seen on the .gif attached to QTBUG-67611. Change-Id: I5dad058468e24327b14d1e7f76c3ad0287d26ee8 Reviewed-by:
Olivier Goffart (Woboq GmbH) <ogoffart@woboq.com>
-
Oswald Buddenhagen authored
creating private deprecated forwarding headers is rather pointless, as keeping source compatibility for private headers is unnecessary. consequently, the feature wasn't used anywhere. remove it to reduce complexity. Change-Id: I6202e5141f0387615f90efa0ec707ac208419227 Reviewed-by:
Lars Knoll <lars.knoll@qt.io>
-
Oswald Buddenhagen authored
it's been a no-op (always on anyway) for quite some time now. Change-Id: I9611ca73ddaef4422a16d85338e1dae473a50fbf Reviewed-by:
Lars Knoll <lars.knoll@qt.io>
-
Oswald Buddenhagen authored
it's been dead code for ages. Change-Id: I0e2f976a5b02119d296bdaa20eb2ddb40a8fd0ba Reviewed-by:
Lars Knoll <lars.knoll@qt.io>
-
Timur Pocheptsov authored
Properly handle single protocol TLS configurations. Previously, due to the use of generic (non version-specific) client/server method they worked as ranges of protocols instead. This also fixes a couple of previously broken tests. Task-number: QTBUG-67584 Change-Id: Ied23113a4fab6b407a34c953e3bd33eab153bb67 Reviewed-by:
Mårten Nordheim <marten.nordheim@qt.io> Reviewed-by:
Edward Welbourne <edward.welbourne@qt.io>
-
Allan Sandfeld Jensen authored
With SSE2 or NEON interpolate_4_pixels is faster than interpolate_4_pixels_16, and using it saves a branch of duplicated code. Similar changes had already been done other places it was used, those have been updated to follow a similar logic. Change-Id: I040d96480f7f925f659602f66f931d28b59312a5 Reviewed-by:
Lars Knoll <lars.knoll@qt.io> Reviewed-by:
Eirik Aavitsland <eirik.aavitsland@qt.io>
-
Friedemann Kleint authored
Fix warning: eventtransitions.qdoc:50: (qdoc) warning: Unknown command '\s1' Amends 3b2d2ada5b1b66ad65eda10d70b5b48d32ef9c5. Task-number: QTBUG-60635 Change-Id: I4002c9769d30d9b8cb2a7255aa2258f6251ea39f Reviewed-by:
Martin Smith <martin.smith@qt.io>
-
Kari Oikarinen authored
This reduces the timeout from 10 seconds to the default 5, but the tested events (resize events, painting) seem like something that should happen in 5 seconds. Change-Id: I1d12372f37264bf7be64096e43813cd03f567102 Reviewed-by:
Laszlo Agocs <laszlo.agocs@qt.io>
-
Kari Oikarinen authored
Bumping the timeout removed flaky failures in an RHEL debug VM. Task-number: QTBUG-67151 Task-number: QTBUG-66216 Change-Id: I2fde636149f5104a41b757df956d84edc420e7c7 Reviewed-by:
Sami Nurmenniemi <sami.nurmenniemi@qt.io> Reviewed-by:
Olivier Goffart (Woboq GmbH) <ogoffart@woboq.com>
-
Kari Oikarinen authored
Instead of an unconditional wait. Change-Id: I360cd665c10c3fd4f936c95ef04957ae1c49c0de Reviewed-by:
Gatis Paeglis <gatis.paeglis@qt.io>
-