- 05 Nov, 2018 - 3 commits
-
-
Jani Heikkinen authored
-
BogDan Vatra authored
Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api'. It will be removed at the end of 2018. For more information see: http://d.android.com/r/tools/update-dependency-configurations.html Task-number: QTBUG-71570 Change-Id: I6f498d8cb3ff01ad641aee697496e3dc56059a72 Reviewed-by:
Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>
-
Liang Qi authored
Conflicts: src/plugins/platforms/cocoa/qcocoaglcontext.mm src/plugins/platforms/xcb/qxcbscreen.h Change-Id: If9b4c67288396ff7346088ce591c7a3588b51979
-
- 02 Nov, 2018 - 3 commits
-
-
Nico Vertriest authored
Due to name conflict with file from qtdeclarative Task-number: QTBUG-65769 Change-Id: I9ebf237701ce76b424f528feacb24e4158f06c0d Reviewed-by:
Venugopal Shivashankar <Venugopal.Shivashankar@qt.io>
-
Paul Wicking authored
Fixes: QTBUG-70926 Change-Id: Icfd13352cd64053c11502058188041ad16f6c287 Reviewed-by:
Edward Welbourne <edward.welbourne@qt.io> Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@qt.io>
-
Edward Welbourne authored
This only updates data on languages already present in 5.12; once it has merged up to dev, the scripts need to be run again to pick up a few more languages and possibly add any more new languages present in v34. Change some tests to match changes in en_AU's abbreviated day and month names. [ChangeLog][ThirdParty][CLDR] Update locale data to CLDR v34. Task-number: QTBUG-71144 Change-Id: I68402b5e7e9d3dba669b8ba31b9a8abd86675c6e Reviewed-by:
Lars Knoll <lars.knoll@qt.io>
-
- 31 Oct, 2018 - 1 commit
-
-
Samuli Piippo authored
If QT_QPA_EGLFS_HIDECURSOR was enabled, m_deviceListener was never initialized, which caused segfault in the destructor. Task-number: QTBUG-71507 Change-Id: Id8b17f5312073249cd12995317213fd746753521 Reviewed-by:
Laszlo Agocs <laszlo.agocs@qt.io>
-
- 30 Oct, 2018 - 1 commit
-
-
Andy Nichols authored
When we try to gracefully destroy a QOpenGLVertexArrayObject it is not possible to create an QOffscreenSurface from a thread that is not the GUI thread. In this case we just need to bail out instead. The side effect that was seen previously was that there would be a warning and a deadlock on Windows when closing QQuickWindows that contained a QQuickPaintedItem backed by a FrameBufferObject render target (which would be using the OpenGL paint engine) when using the threaded render loop. Task-number: QTBUG-70148 Change-Id: I4a20d74d9af850bb90d243212ad9f65c3fc9e616 Reviewed-by:
Laszlo Agocs <laszlo.agocs@qt.io>
-
- 29 Oct, 2018 - 5 commits
-
-
Oswald Buddenhagen authored
Change-Id: I31f8eff4fdfe56cbb7f1450be8d351991966c6d8
-
Thiago Macieira authored
QPointer uses QWeakPointer / QSharedPointer internals in QObject and has the code to make sure two threads won't stomp on each other if both try to create a QPointer for the same QObject at the same time. The threading code was fine, but had a mistake in the clean up code for the loser thread: the QtSharedPointer::ExternalRefCountData destructor has a Q_ASSERT for the state of the reference counts. So we need to set the state correctly before calling the destructor. But we don't want to do it in case the Q_ASSERT compiled to nothing. So we use a hack that violates the Second Rule of Q_ASSERTs: don't do something with side-effects. This way, we can insert code that will only be compiled if Q_ASSERTs do something, without having to duplicate the preprocessor conditions from qglobal.h. Fixes: QTBUG-71412 Change-Id: I1bd327aeaf73421a8ec5fffd1560fdfc8b73b70c Reviewed-by:
Romain Pokrzywka <romain.pokrzywka@gmail.com> Reviewed-by:
Jędrzej Nowacki <jedrzej.nowacki@qt.io>
-
Albert Astals Cid authored
Change-Id: Iaa015046cdcece10c28437da40fcd6cdc9d55eb3 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Błażej Szczygieł authored
"xcb_randr_get_screen_info" can be slow and in some configurations can cause short mouse cursor freezes (which will happen on Qt application startup). Initial screen rotation was used only to not handle possible redundant screen change event. Fixes: QTBUG-70760 Change-Id: I9f01325a045d2c82c4dd2fce91a18a34e54a4bcd Reviewed-by:
Gatis Paeglis <gatis.paeglis@qt.io>
-
Tor Arne Vestbø authored
We used to have logic that explicitly marked a QWindow as "embedded", but we now resolve this dynamically based on whether or not we have a parent window owned by Qt or not. As part of this refactoring the fix for QTBUG-63443 in ac35f9c4 got lost. We restore the behavior by treating Qt::SubWindow as a reason not to create a NSWindow for a view. This flag is set by QMenuPrivate::moveWidgetToPlatformItem already. Fixes: QTBUG-63443 Change-Id: I12bff546eefcb8f6c9ca43b1b879773d129a28f9 Reviewed-by:
Morten Johan Sørvig <morten.sorvig@qt.io> Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@qt.io>
-
- 28 Oct, 2018 - 2 commits
-
-
Rafael Roquetto authored
We need to to explicitly unhide popup windows that were previously explicitly hidden by applicationWillHide, so that their visibility will be effectively restored when the application is unhidden (otherwise the windows are gone forever even though their internal visibility is set to true). Change-Id: I4dbd209b07f769cc815851b40c41db0739ca2dc9 Task-number: QTBUG-71014 Reviewed-by:
Timur Pocheptsov <timur.pocheptsov@qt.io> Reviewed-by:
Edward Welbourne <edward.welbourne@qt.io> Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@qt.io>
-
Ivan Komissarov authored
Since Qt 5.10, qTo/FromBig/LittleEndian<float/double> stopped working. It may be confusing, but big endian floats do exist, so not to break old code, we should support them. Change-Id: I21cdbc7f48ec030ce3d82f1cd1aad212f0fe5dd0 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
- 26 Oct, 2018 - 2 commits
-
-
Tor Arne Vestbø authored
Prevents no-longer used QNSWindows from staying around (closed and invisible, but alive), due to being auto-released when there is no pool in place (during main(), before exec). Change-Id: I4eb63c7140290ffe6bded8a76732354c846ed579 Reviewed-by:
Timur Pocheptsov <timur.pocheptsov@qt.io> Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@qt.io>
-
Tor Arne Vestbø authored
We need to support apps building against the 10.13 SDK, so that they can opt out of dark mode and layer-backing. This does not mean we can't require 10.14 to build Qt itself, but doing so should not require the app to also build against the 10.14 SDK. Change-Id: I53bd0fc8bf56c0be6614acec14d5173589e2620f Reviewed-by:
Timur Pocheptsov <timur.pocheptsov@qt.io> Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@qt.io> Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@qt.io>
-
- 25 Oct, 2018 - 12 commits
-
-
Tor Arne Vestbø authored
The SDK and deployment target versions are helpful to know when diagnosing issues. Change-Id: I85026bd9c1d706a923e8953837bd59bf9ed0266f Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@qt.io> Reviewed-by:
Timur Pocheptsov <timur.pocheptsov@qt.io>
-
Lorn Potter authored
Change-Id: If39cdeedef60a47c0ba1afbab6adf1668bf5d0d6 Reviewed-by:
Morten Johan Sørvig <morten.sorvig@qt.io>
-
Kirill Burtsev authored
Fixes: QTBUG-52279 Change-Id: I4f40fc9d3ce938b4c821f10cacd21e6f652a2227 Reviewed-by:
Shawn Rutledge <shawn.rutledge@qt.io>
-
Simon Hausmann authored
Commit b4bd5f9d removed two members from the mwm hints structure but told xcb_change_property that the structure has still five members when it had been reduced to three. This lead to xcb_change_property accessing memory out of bounds. As identified by Gatis, the safest option to avoid the access is to add the two members again. Other window managers may be expecting their presence in the window property. Change-Id: Id4f0c9536cd317c35f2c6ebd1ac9ccc6f72de6a5 Reviewed-by:
Gatis Paeglis <gatis.paeglis@qt.io> Reviewed-by:
Mikhail Svetkin <mikhail.svetkin@qt.io>
-
Timur Pocheptsov authored
the test is stable in Qt 5.12. Task-number: QTBUG-60993 Change-Id: I0c366567121688d9518e90b5e8f9ec1b4006b7b9 Reviewed-by:
Mårten Nordheim <marten.nordheim@qt.io> Reviewed-by:
Edward Welbourne <edward.welbourne@qt.io>
-
Timur Pocheptsov authored
on macOS, the test seems to be stable nowadays. Task-number: QTBUG-39986 Change-Id: I18430c3feb27a5bee5474e1eb95f7d89b25f00a9 Reviewed-by:
Edward Welbourne <edward.welbourne@qt.io> Reviewed-by:
Mårten Nordheim <marten.nordheim@qt.io>
-
Timur Pocheptsov authored
on macOS, where it was skipped but where it now seems to be stable/work. Task-number: QTBUG-39983 Change-Id: I100a57f23b43074ebacc012be247d92acc6ae336 Reviewed-by:
Mårten Nordheim <marten.nordheim@qt.io> Reviewed-by:
Edward Welbourne <edward.welbourne@qt.io>
-
Gatis Paeglis authored
This patch amends d6721430 . The issue was caused by mistakenly interchanging m_hasXRender <-> m_hasXRandr. Also renamed selectXRandrEvents() -> xrandrSelectEvents() to be more consistent with xi2Select*() API. And moved the xrandrSelectEvents() to QXcbConnection ctor for the same reason. Fixes: QTBUG-71305 Change-Id: I26f9bac3ae1f997f53134eb97f3569fb6d3c13fe Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Andre de la Rocha authored
It seems some touchpads only send legacy WM_MOUSEWHEEL/WM_MOUSEHWHEEL messages for 2-finger scrolling, instead of WM_POINTERWHEEL/ WM_POINTERHWHEEL, even after EnableMouseInPointer(TRUE), in spite of sending the expected pointer messages for normal pointer movement/taps. This change adds a workaround to handle legacy wheel messages even when in pointer mode. Task-number: QTBUG-71257 Change-Id: Ib360051147c4521751a5b91d90fa7657496777fa Reviewed-by:
Oliver Wolff <oliver.wolff@qt.io> Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@qt.io>
-
Oliver Wolff authored
Task-number: QTBUG-71112 Change-Id: If1b81589f295657597a9dfa3671128a927cbe488 Reviewed-by:
Andre de la Rocha <andre.rocha@qt.io> Reviewed-by:
Edward Welbourne <edward.welbourne@qt.io>
-
Oliver Wolff authored
Calling rowCount inside another auto test function yields unexpected results, if rowCount fails. Without a check for QTest::currentTestFailed the failure will not stop the calling function and other functions like rowsInserted and rowsRemoved might happily continue even though their requirements are not met. That caused a crash on winrt under certain circumstances. In addition to that TRY_WAIT now does not only wait for the given amount of time, but also gives feedback about its result. Before this change TRY_WAIT was basically useless, as it gave no indication about its success/failure. Fixes: QTBUG-71121 Change-Id: Ibd3f233a0b913db799814be97c4274d510643c74 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@qt.io>
-
Tor Arne Vestbø authored
We want to inform the user when they have upgraded their Xcode version and hence have a new SDK version, which requires a complete rebuild. Explicit changes to the Xcode selection (be it via xcode-select or $DEVELOPER_DIR) do not affect the existing build directory, so we must record the Xcode selection inside the build to avoid false triggering. Change-Id: I7d13da1232226712a4951e8a360cf4b634c6fa2f Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@qt.io>
-
- 24 Oct, 2018 - 1 commit
-
-
Andy Shaw authored
If a tooltip was shown on an application modal dialog then it would end up blocking mouse events to the dialog while the tooltip was visible. Since tooltips are special in this case, they should not cause mouse events to be blocked. Fixes: QTBUG-65599 Change-Id: Ibf1729ca4942f5854e4f9687c5586382e23c1c31 Reviewed-by:
Richard Moe Gustavsen <richard.gustavsen@qt.io>
-
- 23 Oct, 2018 - 2 commits
-
-
Michael Brüning authored
The AMD FirePro dual gpus on the Mac Pro have a problem with offline renderers in Chromium. Therefore, Chromium and thus Qt WebEngine disable this option via the pixel format attributes. The Qt Cocoa plugin on the other hand enables it in the recent versions, causing context creation in Qt WebEngine to fail when run on a Mac Pro with dual AMD FirePro gpus due to incompatible context options. This patch uses the environment variable QT_MAC_PRO_WEBENGINE_WORKAROUND which is set by Qt WebEngine upon application startup if the application is running on a late 2013 Mac Pro. It should typically not be set from anywhere else. [ChangeLog] Offline renderers will be disabled when the application is using Qt WebEngine and running on one of the late 2013 Mac Pro models. Fixes: QTBUG-70062 Change-Id: I0b0831efb6f4073ebd37672040aaed6370853fc0 Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@qt.io>
-
Tor Arne Vestbø authored
The expression "m_context.view = view" always evaluates to the view, so the check was flawed. Change-Id: Icef4ba5244975ccd78a151c7d40c53b2364c6148 Reviewed-by:
Timur Pocheptsov <timur.pocheptsov@qt.io>
-
- 22 Oct, 2018 - 6 commits
-
-
Friedemann Kleint authored
The Qt QPA does not handle native double clicks as such; change the plugin not to send them. For Ink, remove the doubleclick detection. For the old code path, map them to Press. Fixes: QTBUG-70999 Change-Id: I54b858f9e146bf325a861554d5ef74143db7d2b7 Reviewed-by:
Oliver Wolff <oliver.wolff@qt.io>
-
Ivan Komissarov authored
There is no sense in testing the 'm_array' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. Task-number: QTBUG-71156 Change-Id: Ib76d16d38d2b0b0c4c9fae3d8d5bdd86af0d08ff Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Andre de la Rocha authored
Qt's PDF engine previously supported only the PDF v1.4 standard, which only allows pages of up to 200x200in (about 5x5m). This patch optionally enables the generation of PDF v1.6-compliant files that allow the redefinition of user space units, so that pages of up to 381x381km are now possible. By default, generated files are compliant to v1.4 spec. v1.6 compliance must be enabled by, e.g., calling QPrinter::setPdfVersion() with QPrinter::PdfVersion_1_6. PDF v1.6-compliant files require Adobe Reader 7.0 or newer (also worked with the built-in viewers in current versions of Chrome, Firefox and Edge). Task-number: QTBUG-69386 Change-Id: I21708e0d465d5d7d9e46ff06dd04acfe1dfb0858 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@qt.io> Reviewed-by:
Andy Shaw <andy.shaw@qt.io> Reviewed-by:
Oliver Wolff <oliver.wolff@qt.io>
-
Arnaud Bienner authored
Change-Id: I987a4129968e9af74e21a2d855c4576a9caada73 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@qt.io>
-
Frederik Gladhorn authored
The state was forgotten from the translation layer, this is important for tree views. Fixes: QTBUG-71223 Change-Id: Ief4004fe455889f9d5a7eb018bf34d37c36a6bd9 Reviewed-by:
Jan Arve Sæther <jan-arve.saether@qt.io>
-
Frederik Gladhorn authored
Change-Id: I96274ab0a0f5d942746de0166df47936e2390c65 Reviewed-by:
Jan Arve Sæther <jan-arve.saether@qt.io>
-
- 21 Oct, 2018 - 2 commits
-
-
Ivan Komissarov authored
There is no need to call a memset as long as class is initialized with new and default-constructor will initialize values. Change-Id: I02f9ec524e32cb72713f6b5e37b60f3dec72fb28 Reviewed-by:
Giuseppe D'Angelo <giuseppe.dangelo@kdab.com> Reviewed-by:
Allan Sandfeld Jensen <allan.jensen@qt.io>
-
Ivan Komissarov authored
A part of conditional expression is always false: if "c > 'z'" Task-number: QTBUG-71156 Change-Id: I6ee20c45d80e476d97e59167c481b157e4a233d0 Reviewed-by:
Mikhail Svetkin <mikhail.svetkin@qt.io> Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-