- 11 Feb, 2020 - 4 commits
-
-
Alexander Akulich authored
[ChangeLog][Deprecation Notice] QLocalSocket::error() (the signal) is deprecated; superseded by errorOccurred() Change-Id: I579c07564f5c470cf2867864755e0a26e6afce3b Reviewed-by:
Mårten Nordheim <marten.nordheim@qt.io>
-
Alexander Akulich authored
The method named like a signal and can lead to confusion especially if such a signal will be added. The new name taken from QAbstractSocketPrivate::setErrorAndEmit(), though in QLocalSocket the method is NOT the only place of the error set and the signal emission. Change-Id: I7cdc487a39ec290203cced7359527f888342a0ad Reviewed-by:
Mårten Nordheim <marten.nordheim@qt.io>
-
Alexander Akulich authored
This reverts commit 0de6c26a . The patch fixes ambiguity between a getter and a signal by changing the getter name, but we still have to rename the signal to follow the signals naming convention. Revert the commit to keep the getter as is and change the signal name instead. Change-Id: I67dbb5cada25da473bdd02e71b1e2d9bd03f039e Reviewed-by:
Mårten Nordheim <marten.nordheim@qt.io>
-
Vitaly Fanaskov authored
Task-number: QTBUG-81845 Change-Id: Ia0ff5321423a5d3d4853bd425dd7236926f16047 Reviewed-by:
Christian Ehrlicher <ch.ehrlicher@gmx.de> Reviewed-by:
Richard Moe Gustavsen <richard.gustavsen@qt.io>
-
- 10 Feb, 2020 - 8 commits
-
-
Kai Koehne authored
This allows for instance to show the current UI language in the UI, or to load additional translations that match the .qm file by other means. This is especially useful in the case of QTranslator::load(QLocale(), ...), in which case different language and country combinations might be tried. Another option is to inspect the file name via QTranslator::filePath(); however, this is more error-prone, and might also miss information (if the .qm file name doesn't have a country suffix, or no suffix at all). Change-Id: I6f565d53d8f50e21241ccae6c4de264747ac8f81 Reviewed-by:
Simon Hausmann <simon.hausmann@qt.io>
-
Kai Koehne authored
Task-number: QTBUG-36608 Change-Id: I8ef0968404370b8fc25dc8b4c1e2c9e4484ae55c Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@gmx.de> Reviewed-by:
Simon Hausmann <simon.hausmann@qt.io>
-
Marc Mutz authored
Centralize the search for the QMimeDataStruct with a given format in find() (overloaded on const and non-const, but implemented only once), and use it in the three other functions that performed lookup before. In setData(), optimize the case where data is overwritten. Use a std::vector to not have to think about hidden detaches when implementing the const find() in terms of the non-const one. Change-Id: I874e5c6ef9c97d98b42f29faccbc3043e8c6a855 Reviewed-by:
David Faure <david.faure@kdab.com>
-
Tor Arne Vestbø authored
Change-Id: I0e19b4c0dd7aa77063e02e6aac7e345dd7c8a5f5 Reviewed-by:
Simon Hausmann <simon.hausmann@qt.io>
-
Tor Arne Vestbø authored
Change-Id: Id0ac30fe0a63757ef722634e6dd90806015467aa Reviewed-by:
Simon Hausmann <simon.hausmann@qt.io>
-
Dmitriy Purgin authored
Some Qt classes already accept std::chrono durations in their methods (see, for example, QTimer). The proposed change adds an overload with std::chrono::milliseconds to QStateMachine::postDelayedEvent(). Change-Id: I360fd2bb54fedc7415e9ec17e096095be3604d41 Reviewed-by:
Erik Verbruggen <erik.verbruggen@me.com>
-
Jan Arve Sæther authored
Change-Id: I774b1647eff5fcfa0de5bcc50ca2638644b03613 Reviewed-by:
Edward Welbourne <edward.welbourne@qt.io>
-
Laszlo Agocs authored
Once the number of buffers or images exceeds the QVarLengthArray limit, it moves over to heap-based allocation, and then reallocated to grow as needed. Problem is, if we keep references to the elements, those may get invalidated on every grow. This was not an issue until the element count reached the preallocated (stack) count. So instead, store indices and fill in the pointers in the VkWriteDescriptorSet only before issuing vkUpdateDescriptorSets(). Change-Id: I99f26f5e14cb28107edb1db86a21afa135858589 Reviewed-by:
Paul Olav Tvete <paul.tvete@qt.io>
-
- 08 Feb, 2020 - 2 commits
-
-
Timur Pocheptsov authored
Apparently vertical shift and increased height were not enough, more adjustment needed horizontally also: the default NSBox draws itself smaller in both dimensions and shifted from the origin we wanted. Thus we trick it to think it's drawing a bigger thing. It will draw a smaller one (again), but closer to what we need. Fixes: QTBUG-72365 Change-Id: Ib3a4c0b3eafb9f2f9d3b24bcbdd8335e73053622 Reviewed-by:
Volker Hilsheimer <volker.hilsheimer@qt.io>
-
Qt Forward Merge Bot authored
Change-Id: I5d80d84d1fd9f52e7c8e4895cc34d4d29043f400
-
- 07 Feb, 2020 - 4 commits
-
-
Mårten Nordheim authored
The iterator is a QMultiMap iterator, not QMap, so the QDoc would complain. Change-Id: I1e3d2b454e21049d676387945e1e860e50854de8 Reviewed-by:
Lars Knoll <lars.knoll@qt.io>
-
Volker Hilsheimer authored
Moving a file to the trash should preferably done via IFileOperation. However, the implementation on Windows 7 ignores the operation flags that request the shell not to show any confirmation dialogs or other UI elements. SHFileOperation is an old API that doesn't show any UI, but has the limitation that it doesn't report the location of the file in the trash after the move. So an application cannot restore the file, but the user can do so via Explorer. Overall, the better compromise is to not have dialogs at the expense of not being able to report the new path. This allows us to run the unit test on Windows 7 as well. Change-Id: Ib8e651a69e2c6750f668b52d2a70925d156cc8ae Fixes: QTBUG-81927 Reviewed-by:
Vitaly Fanaskov <vitaly.fanaskov@qt.io>
-
Volker Hilsheimer authored
On macOS, the registerTimer test case fails frequently, and blocks valid integrations. With this change we try to detect the condition and skip the test. Change-Id: Id2065f606abfd431971becf63034a4c1f0fdb9e5 Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@qt.io>
-
Wang Chuan authored
The font change in QComboBox might cause incorrect appearance of popup menu since it doesn't notify popup menu to relayout itself Fixes the issue by send font change event to the item view of popup menu when received a font change event in QComboBox Fixes: QTBUG-75846 Change-Id: I4821015cca95a7e233a22262596a6fbf27f10aef Reviewed-by:
Richard Moe Gustavsen <richard.gustavsen@qt.io>
-
- 06 Feb, 2020 - 17 commits
-
-
Tor Arne Vestbø authored
The test orchestrator shouldn't have to deal with the individual options needed for each test. Change-Id: I78bbf4850cc649e625bd08a7aedf02267ba1314d Reviewed-by:
Edward Welbourne <edward.welbourne@qt.io>
-
Tor Arne Vestbø authored
Change-Id: I2fd7a39684bde44d82c4d877086f606413d68520 Reviewed-by:
Edward Welbourne <edward.welbourne@qt.io> Reviewed-by:
Simon Hausmann <simon.hausmann@qt.io>
-
Tor Arne Vestbø authored
These tests are apparently not run at the moment, otherwise they would have failed to even start, but they should definitely not have the tst prefix. Change-Id: Iafcec2764ebb3570e6bc6ebfba27d92a94639893 Reviewed-by:
Simon Hausmann <simon.hausmann@qt.io>
-
Tor Arne Vestbø authored
The built in crash reporter on macOS will by default not show the dialog if the application is not one that will run in the foreground. Change-Id: I0020520ae2f14a0e2f84fdca1d80ec6fe1247ffd Reviewed-by:
Simon Hausmann <simon.hausmann@qt.io> Reviewed-by:
Timur Pocheptsov <timur.pocheptsov@qt.io>
-
Christian Ehrlicher authored
When a QPushButton has an icon, text and menu, the text is truncated. In RTL mode the menu indicator is also drawn on the wrong side. Fixes: QTBUG-81784 Change-Id: I27ecb67d12c68ac939540f0f836b2e2875706b4b Reviewed-by:
Volker Hilsheimer <volker.hilsheimer@qt.io>
-
Volker Hilsheimer authored
As discussed in the bug report, making sure that the reference counts are correct in such scenarios adds substantial complexity to the code, only to support a bad use-case for which QStandardItemModel was not designed. Change-Id: I663b490ed3471875386add17e7eadb7d8df50489 Fixes: QTBUG-78142 Reviewed-by:
Paul Wicking <paul.wicking@qt.io>
-
Andy Shaw authored
Since the patches applied previously are no longer required, we have removed those too. [ChangeLog][QtSQL][sqlite] Updated to v3.31.1 Change-Id: Ia80c31683a8cf92cfd114b6da32460ddcf38d502 Reviewed-by:
Volker Hilsheimer <volker.hilsheimer@qt.io>
-
Friedemann Kleint authored
Those types are used as properties of Q(Date)TimeEdit, QKeySequenceEdit. Fixes: PYSIDE-1215 Change-Id: I8b9ffebb8229fff447aa7dd6bee6e037d708333c Reviewed-by:
Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
-
Laszlo Agocs authored
Beware of the API terminology: GL 'factor' = 'slope scaled depth bias', GL 'units' = '(constant) depth bias'. Task-number: QTBUG-81843 Change-Id: I03e3618d007cbf7100add0de4950a6163d788cc7 Reviewed-by:
Eirik Aavitsland <eirik.aavitsland@qt.io>
-
Laszlo Agocs authored
...which is the natural default, and matches other backends. Task-number: QTBUG-81852 Change-Id: I6d0788b18eb7601661ef646e650114a503a12215 Reviewed-by:
Eirik Aavitsland <eirik.aavitsland@qt.io>
-
Laszlo Agocs authored
...before generating batches for the encoder's set* methods. Otherwise there is a chance we end up in an assertion in case the native binding number for a buffer/texture/sampler happens to be smaller than the native binding of the previous. (we pre-sort based on the SPIR-V binding but that is not what the Metal API works with in the end) Task-number: QTBUG-81822 Change-Id: Iddfed168e065e3c7f6a09ad6dd4efdafa891b339 Reviewed-by:
Eirik Aavitsland <eirik.aavitsland@qt.io>
-
Edward Welbourne authored
In tst_QLocale::windowsDefaultLocale(), we configure the long and short date formats and the short time format eccentrically, then verify that QLocale::system() does actually get these eccentric formats. However, we did not configure the long time format (whose MS-API name doesn't match that of the other formats), so had to rely on a guess at the system locale's format. That, however, is not robust; so now configure the long time format, too. Removed a duplicated test, at the same time. Fixes: QTBUG-36306 Change-Id: I04dc22c7eb1b58af55412b598873868f79e9c74f Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@qt.io>
-
Volker Hilsheimer authored
Change-Id: I7d8605221a28cd05b4ebdbf20adf00ec3e121b58 Reviewed-by:
Paul Wicking <paul.wicking@qt.io>
-
Qt Forward Merge Bot authored
-
Qt Forward Merge Bot authored
Conflicts: src/network/ssl/qsslsocket_openssl_symbols.cpp Change-Id: I8c13b5c48a8ecce96540b39c6d5f8ca146eb2339
-
Jan Arve Sæther authored
If we had one test function that just did tst_Mouse::f1() { QTest::mouseMove(w, QPoint(0,0)); } and another test function that did tst_Mouse::f2() { QTest::mouseMove(w, QPoint(500,500)); } their corresponding event timestamps were only 1 apart from each other. This meant that any code that tried to estimate the velocity of a mouse cursor would get a really high velocity estimate inside f2(). This would come as a surprise to most people. So to avoid this, we add a 500 ms timestamp delay between each test function call. In theory this could also prevent generating a mouseDoubleClickEvent when a pair of test functions containing a press-release sequence was run, but there is a separate pre-existing mechanism to handle that case. Change-Id: Icd4fc35853c09f080466d22411208c7b5c4174b5 Reviewed-by:
Shawn Rutledge <shawn.rutledge@qt.io>
-
Assam Boudjelthia authored
Allow Android apps to request qtvirtualkeyboard using environment variable QT_IM_MODULE. Similar to commit b46fe39d for Windows platform. Task-number: QTBUG-80357 Change-Id: I584859729e60f5d73943ca5840a9dcd169cc9ecb Reviewed-by:
Mitch Curtis <mitch.curtis@qt.io> Reviewed-by:
Andy Shaw <andy.shaw@qt.io>
-
- 05 Feb, 2020 - 5 commits
-
-
Sze Howe Koh authored
Copy the convention of QDeadlineTimer::ForeverConstant Task-number: QTBUG-48701 Change-Id: Ic7760b7ffec630f1cd47361f5adda3f17fffb9f6 Reviewed-by:
Richard Moe Gustavsen <richard.gustavsen@qt.io> Reviewed-by:
Lars Knoll <lars.knoll@qt.io>
-
Volker Hilsheimer authored
Due to the nature of QFile just operating on a file path, this also works for paths that are actually directories. The test covers files from different locations on which this operation should typically succeed, but tries to handle the case where trashing files will fail because of the file system structure. On Windows 7, running the test will open a confirmation dialog as the implementation of IFileOperation doesn't respect the various flags. This might depend on the specific Windows 7 patch level, and the option to always use SHFileOperation on that platform needs to be evaluated further. [ChangeLog][QtCore][QFile] Introduce QFile::moveToTrash to allow applications to move files to the trash. Change-Id: I45019040c25b30f7db293b6933c63aca2f319514 Fixes: QTBUG-47703 Reviewed-by:
Vitaly Fanaskov <vitaly.fanaskov@qt.io>
-
Morten Johan Sørvig authored
This way we produce valid xml also for the no-proxy case. Change-Id: I5a277255d22c3814fe463c0cd013c04ddc6ad919 Reviewed-by:
André Hartmann <aha_1980@gmx.de>
-
Assam Boudjelthia authored
Unregister the ActivityResultListener() after the result is handled. Fixes: QTBUG-78912 Change-Id: Ia2b45eca002e854492c409c70a3876fa8ce98de1 Reviewed-by:
Andy Shaw <andy.shaw@qt.io>
-
Morten Johan Sørvig authored
DISABLE_DEPRECATED_FIND_EVENT_TARGET_BEHAVIOR is now on by default, which means that functions like emscripten_set_keydown_callback() now expects CSS selectors (e.g. "#canvas_id" instead of "canvas_id"). In addition, Module.canvas is no more. Add a deprecation warning in case someone is setting it and expects Qt to use it. (qtloader.js sets qtCanvasElements instead). This bumps the minimum supported emsdk version to 1.39.5. Fixes: QTBUG-74601 Change-Id: I8c46ce170143f969e6281824f78b1bb809c267ab Reviewed-by:
Lorn Potter <lorn.potter@gmail.com>
-