Commit 2a52a400 authored by Alex Blasche's avatar Alex Blasche
Browse files

Fix bluez config test failure on clang


This compile failure used to be a warning only but these days is a failure
for clang:

> /home/ablasche/dev/qt/qt512/qtconnectivity/config.tests/bluez/main.cpp:36:11: error: taking the address of a temporary object of type 'bdaddr_t' [-Waddress-of-temporary]
>     bacmp(BDADDR_ANY, BDADDR_LOCAL);
>           ^~~~~~~~~~
> /usr/include/bluetooth/bluetooth.h:310:23: note: expanded from macro 'BDADDR_ANY'
> #define BDADDR_ANY   (&(bdaddr_t) {{0, 0, 0, 0, 0, 0}})
>                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /home/ablasche/dev/qt/qt512/qtconnectivity/config.tests/bluez/main.cpp:36:23: error: taking the address of a temporary object of type 'bdaddr_t' [-Waddress-of-temporary]
>     bacmp(BDADDR_ANY, BDADDR_LOCAL);
>                       ^~~~~~~~~~~~
> /usr/include/bluetooth/bluetooth.h:312:23: note: expanded from macro 'BDADDR_LOCAL'
> #define BDADDR_LOCAL (&(bdaddr_t) {{0, 0, 0, 0xff, 0xff, 0xff}})
>                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 2 errors generated.

The need for BDADDR_NONE is obsolete now since the test does not rely on
those defines anymore. The main purpose is to check that bluetooth.h
is available which is already tested by using bacmp and bdaddr_t.

Change-Id: I09da4dc5cd3945ffae7819628b45477a52789006
Reviewed-by: default avatarOliver Wolff <oliver.wolff@qt.io>
Reviewed-by: default avatarKai Koehne <kai.koehne@qt.io>
Showing with 4 additions and 5 deletions
...@@ -30,11 +30,10 @@ ...@@ -30,11 +30,10 @@
int main() int main()
{ {
#ifdef BDADDR_NONE bdaddr_t anyTmp = {{0, 0, 0, 0, 0, 0}};
bacmp(BDADDR_ANY, BDADDR_NONE); bdaddr_t localTmp = {{0, 0, 0, 0xff, 0xff, 0xff}};
#else
bacmp(BDADDR_ANY, BDADDR_LOCAL); bacmp(&anyTmp, &localTmp);
#endif
return 0; return 0;
} }
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment