Commits (7)
-
Alex Blasche authored
Multiple device discovery agents can influence each other as they monitor the same DBus BlueZ adapter. When one agent started and another just stopped/finished the discovery process, the newly started agent is caught in an unprepared state. The other use case where this might happen is when one agent stopped the discovery and another agent goes through the same start/stop cycle in very quick order, then the first agent may still have pending signals despiter adapter being deleted. In any case this patch simply ensures that an already inactive agent doesn't go through the finishing process again. Task-number: QTBUG-51307 Change-Id: If0e2b944f1ceadb9037179c4fde2f3f79741d0a5 Reviewed-by:
dmnikola <dmitry.nikolaev@theqtcompany.com> Reviewed-by:
Christian Kandeler <christian.kandeler@theqtcompany.com>
3e423699 -
Alex Blasche authored
Task-number: QTBUG-53616 Change-Id: Ie3a87abc61100ac8fe0a5b671725f54ae28e1501 Reviewed-by:
Martin Smith <martin.smith@theqtcompany.com> Reviewed-by:
Leena Miettinen <riitta-leena.miettinen@qt.io>
5e8994a4 -
Alex Blasche authored
Task-number: QTBUG-53749 Change-Id: I6e7832b4a5a70bed153fb8b0718b3c66177ffd58 Reviewed-by:
Martin Smith <martin.smith@theqtcompany.com>
f59d75eb -
Alex Blasche authored
PUBLIC_BROWSE_GROUP scans are not always supported. In such cases more targeted service scans are to be used. This patch modifies QBluetoothServiceDiscoveryAgent such that when a uuid filter is set targeted service scans are used rather than generic PUBLIC_BROWSE_GROUP ones. QBluetoothSocket always scans with an applied uuid filter and therefore directly benefits from the patch. Change-Id: I94997d2cf8f70fa7db5422d78c8bfdbe2aa1dbbc Task-number: QTBUG-53041 Reviewed-by:
Timur Pocheptsov <timur.pocheptsov@theqtcompany.com>
be8c8951 -
Alex Blasche authored
This may happen when the device discovery agent is quickly started and stopped and started again. If the stop-start combination is happening quicker than dbus can deliver the Discovering flag of the Adapter1 BlueZ interface, BlueZ's stop response will override the new start discovery request. Task-number: QTBUG-53715 Change-Id: I6a03fc525c7f390db009fc68a5313352ebba7f79 Reviewed-by:
Frank Meerkoetter <frank.meerkoetter@basyskom.com> Reviewed-by:
Alex Blasche <alexander.blasche@theqtcompany.com>
3bf621a5 -
Alex Blasche authored
When the model changes quickly from one discovery mode to the next, the public device discovery agent and the internal device discovery agent inside QBlutoothServiceDiscoveryAgent interact with each other. One agent is shutting down while the other is starting. Since both instances manage the same hardware, the resulting signals hit the agents in unexpected states which even leads to random crashes. The fix is to let one agent stop and only start the next one once the first has properly shut down. Unfortunately the public BluetoothModel API acts synchronously via its running property. Therefore the synchronous running property must be mapped to asynchronous state changes inside the agents. To achieve this the model uses an internal state transition table which determines how the next setRunning(bool) call is to be processed. As a consequence it is possible to have a non-running BluetoothModel but the internal agent is still shutting down. Another scenario might exhibit a running model whereas one internal agent is still finishing up and the next is waiting to start. Task-number: QTBUG-51307 Change-Id: I0a471b913b8784d2218a797442cee7ee4d00edf3 Reviewed-by:
Christian Kandeler <christian.kandeler@theqtcompany.com> Reviewed-by:
Timur Pocheptsov <timur.pocheptsov@theqtcompany.com> Reviewed-by:
Oliver Wolff <oliver.wolff@qt.io>
74916ede -
Timur Pocheptsov authored
qbluetoothdevicediscoveryagent_p.cpp not needed on iOS, since for iOS we already have iOS-specific version defined completely in the corresponding .mm file. This is quite obvious ODR violation, but not so obvious for compiler/linker apparently. Change-Id: I7b7d0c9596cccea307ec7acbafbb6cd31b41d885 Reviewed-by:
Alex Blasche <alexander.blasche@theqtcompany.com>
7b4d1325
Showing

| W: | H:
| W: | H:

